Fix response header for WASM assets during jekyll serve#8938
Fix response header for WASM assets during jekyll serve#8938ashmaroli wants to merge 1 commit intojekyll:masterfrom
jekyll serve#8938Conversation
|
This seems like a bandaid that gets around the real problem: binary types don't have a charset. We use mime-db (or did, anyway) to generate the mime.types file, and it does include if there's a charset. Perhaps we could write this such that we add the charset for types which support it? https://github.com/jshttp/mime-db#data-structure https://github.com/jshttp/mime-db/blob/master/db.json Only text-based files have a charset, all others are binary, so if we can solve this for all binary formats then we can also solve this for wasm. |
[insert now why didn't I think of that emoji] |
Summary
.wasmfiles cannot be served with response headerapplication/wasm; charset=utf-8.Therefore, don't inject UTF-8 charset for
application/wasmmime-type.Context
Resolves #8936
/cc @daveyarwood