Merged
Conversation
Contributor
|
No reviewable files after applying ignore patterns. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the communique tool in mise.lock from version 1.0.4 to 1.1.2 across various platforms. A review comment points out that the linux-x64-musl-baseline entry incorrectly references the gnu build instead of the musl build, which could lead to runtime compatibility issues on musl-based systems.
Comment on lines
+310
to
+312
| checksum = "sha256:5e74ead7037f42940c7dba4f6aa4ed968920cbb55a047aa0d291b0c675c65676" | ||
| url = "https://github.com/jdx/communique/releases/download/v1.1.2/communique-x86_64-unknown-linux-gnu.tar.gz" | ||
| url_api = "https://api.github.com/repos/jdx/communique/releases/assets/405963914" |
Contributor
There was a problem hiding this comment.
The linux-x64-musl-baseline platform entry is incorrectly pointing to the gnu asset instead of the musl asset. Since this is a musl-based platform, it should use the musl binary to ensure compatibility and avoid runtime issues related to missing glibc dependencies. This is inconsistent with the updates made to linux-x64-musl and linux-arm64-musl in this same pull request.
checksum = "sha256:01a6a8b49e635a5a209fdaf6c7b2e976374debc2db1c846c033f567fdba0d86c"
url = "https://github.com/jdx/communique/releases/download/v1.1.2/communique-x86_64-unknown-linux-musl.tar.gz"
url_api = "https://api.github.com/repos/jdx/communique/releases/assets/405964691"
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.22 x -- echo |
24.6 ± 0.4 | 23.7 | 27.1 | 1.00 |
mise x -- echo |
24.9 ± 0.7 | 24.0 | 32.2 | 1.01 ± 0.03 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.22 env |
24.3 ± 0.8 | 22.9 | 33.2 | 1.01 ± 0.03 |
mise env |
24.1 ± 0.3 | 23.5 | 25.4 | 1.00 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.22 hook-env |
24.4 ± 0.3 | 23.7 | 25.7 | 1.00 |
mise hook-env |
25.4 ± 0.4 | 24.4 | 27.5 | 1.04 ± 0.02 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.22 ls |
25.2 ± 0.6 | 24.4 | 32.8 | 1.00 |
mise ls |
25.7 ± 0.4 | 24.6 | 27.0 | 1.02 ± 0.03 |
xtasks/test/perf
| Command | mise-2026.4.22 | mise | Variance |
|---|---|---|---|
| install (cached) | 170ms | 178ms | -4% |
| ls (cached) | 82ms | 86ms | -4% |
| bin-paths (cached) | 84ms | 86ms | -2% |
| task-ls (cached) | 789ms | 789ms | +0% |
jdx
pushed a commit
that referenced
this pull request
Apr 26, 2026
### 🚀 Features - **(backend)** add global libc preference by @jdx in [#9404](#9404) - opt-in to pre-release versions for github and aqua backends by @jakedgy in [#9329](#9329) ### 🐛 Bug Fixes - **(backend)** allow unresolved latest opt-in by @jdx in [#9401](#9401) - **(install)** stop rewriting healthy runtime symlinks by @jdx in [#9410](#9410) - **(node)** route musl tarball URLs to unofficial-builds by @jdx in [#9409](#9409) - **(prune)** skip remote version resolution for tracked configs by @jdx in [#9406](#9406) - **(schema)** allow array values in tool additionalProperties by @JP-Ellis in [#9400](#9400) ### 📦️ Dependency Updates - bump communique to 1.1.2 by @jdx in [#9402](#9402) ### 📦 Registry - use aqua for rumdl by @scop in [#9397](#9397) ### Chore - **(ci)** improve pr-closer workflow by @jdx in [#9403](#9403) - **(release)** stop appending sponsor blurb when communique succeeds by @jdx in [#9395](#9395) ### New Contributors - @JP-Ellis made their first contribution in [#9400](#9400)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
mise install --locked communiqueNote
Low Risk
Low risk: only updates the
mise.lockentry for thecommuniquetool, changing pinned version plus release asset URLs/checksums with no runtime code changes.Overview
Bumps the pinned
communiquetool inmise.lockfromv1.0.4tov1.1.2.Refreshes the per-platform release asset metadata (URLs,
url_api, and checksums), including switching the Linux ARM64 musl entry to the correct musl artifact.Reviewed by Cursor Bugbot for commit c51648f. Bugbot is set up for automated code reviews on this repo. Configure here.