Conversation
Add Atlassian CLI (acli) to the registry using the aqua backend. acli is a CLI tool for interacting with Atlassian Cloud from the terminal. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Atlassian CLI (acli) to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the Atlassian CLI (acli) to the mise registry. However, the underlying aqua package definition it relies on appears to be incorrect, which will prevent the tool from being installed. I've provided a detailed comment with a corrected aqua package definition. Please update the aqua registry file for this change to work.
| backends = ["aqua:atlassian.com/acli"] | ||
| description = "Software to interact with Atlassian Cloud from the terminal" | ||
| os = ["linux", "macos"] | ||
| test = { cmd = "acli --version", expected = "acli/{{version}}" } |
There was a problem hiding this comment.
The underlying aqua package definition for atlassian.com/acli appears to be incorrect, which will cause mise install acli to fail. The registry.yaml for this package seems to use an incorrect URL template and also lists linux/arm64 as a supported environment, which is not officially provided by Atlassian.
To fix this, the file crates/aqua-registry/aqua-registry/pkgs/atlassian.com/acli/registry.yaml should be updated. Here is a corrected version:
# yaml-language-server: $schema=https://raw.githubusercontent.com/aquaproj/aqua/main/json-schema/registry.json
packages:
- type: http
repo_owner: ryan-pip
repo_name: acli-versions
name: atlassian.com/acli
description: Software to interact with Atlassian Cloud from the terminal
link: https://developer.atlassian.com/cloud/acli/
version_source: github_tag
url: https://acli.atlassian.com/acli-v{{.Version}}-{{.OS}}-{{.Arch}}.tar.gz
format: tar.gz
files:
- name: acli
src: acli-v{{.Version}}-{{.OS}}-{{.Arch}}/acli
replacements:
darwin: mac
amd64: x64
supported_envs:
- linux/amd64
- darwin/amd64
- darwin/arm64Key changes:
- Corrected
urlandfiles.srcto match the official distribution format. - Added
replacementsto map aqua's OS/Arch names to the ones used in the download URL (darwin->mac,amd64->x64). - Removed
linux/arm64fromsupported_envsas it's not officially available.
Since the registry.yaml file is not part of this diff, you'll need to update it in your branch for this change to work correctly.
Greptile SummaryThis PR adds the Atlassian CLI ( Key observations:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
actor User
participant mise
participant aqua_registry as aqua Registry<br/>(aquaproj/aqua-registry)
participant atlassian as Atlassian Download Server
User->>mise: mise install acli
mise->>aqua_registry: lookup "atlassian.com/acli"
aqua_registry-->>mise: package definition (download URL template)
mise->>atlassian: download acli binary for platform/version
atlassian-->>mise: binary archive
mise-->>User: acli installed
Reviews (2): Last reviewed commit: "Update acli.toml" | Re-trigger Greptile |
| @@ -0,0 +1,4 @@ | |||
| backends = ["aqua:atlassian.com/acli"] | |||
| description = "Software to interact with Atlassian Cloud from the terminal" | |||
| os = ["linux", "macos"] | |||
There was a problem hiding this comment.
Windows support omitted without explanation
The official Atlassian CLI documentation states that acli is "compatible with multiple platforms such as MacOS, Windows, and Linux." Excluding windows from the os field means mise install acli will fail silently for Windows users without a clear error message.
If the exclusion is intentional (e.g., the aqua backend's Windows package definition isn't yet in the registry, or there's a known aqua limitation for Windows on this package), a comment explaining the reason would be helpful. Otherwise, consider adding windows to the supported platforms.
| os = ["linux", "macos"] | |
| os = ["linux", "macos", "windows"] |
### 🐛 Bug Fixes - **(env)** improve hook-env watch_files tracking and early-exits by @rpendleton in [#8716](#8716) - **(install)** create runtime symlinks in system/shared install directories by @jdx in [#8722](#8722) - apply --silent flag to global settings to suppress output by @nkakouros in [#8720](#8720) ### 📦️ Dependency Updates - ignore RUSTSEC-2026-0066 astral-tokio-tar advisory by @jdx in [#8723](#8723) ### 📦 Registry - add acli by @ggoggam in [#8721](#8721) ### New Contributors - @rpendleton made their first contribution in [#8716](#8716) - @ggoggam made their first contribution in [#8721](#8721) ## 📦 Aqua Registry Updates #### Updated Packages (1) - [`astral-sh/ty`](https://github.com/astral-sh/ty)
Summary
Test plan
mise install acliworksacli --versionoutputs expected format🤖 Generated with Claude Code