Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inconsistency in the behavior of the global --silent CLI flag. Previously, it only suppressed task output but not mise's internal messages, making it less effective than intended. The changes ensure that --silent now correctly silences all output from mise and tasks, aligning its functionality with the help text and making it a comprehensive suppression option.

Highlights

• Fixing --silent CLI flag behavior: The --silent global CLI flag now correctly suppresses both mise's own info/warn messages and task output, making it a proper superset of --quiet as intended.
• Updated settings application logic: Modified the Settings struct to ensure that when --silent is used, it explicitly sets the quiet setting to true, thereby raising the log level to 'error' and suppressing mise's internal output.
• Added end-to-end tests: A new end-to-end test file was introduced to verify the correct behavior of --quiet, --silent, -q, and run -S flags for task output suppression.

Greptile Summary

This PR fixes a bug where the global --silent CLI flag had no effect on Settings, making it weaker than --quiet for suppressing mise's own output. The fix is two targeted lines in apply_cli_settings: --silent now sets both quiet=true (raising the log level to "error", suppressing info/warn messages) and silent=true (propagated to silent_bool() to suppress task stdout/stderr).

Key changes:

• src/config/settings.rs: --silent now writes both quiet and silent into Settings, matching the documented superset behaviour.
• e2e/tasks/test_task_quiet_silent_flags: New test covering --quiet, --silent, -q, and run -S; uses the project's standard assert/assert_empty inline-command pattern (the earlier fragile echo '$output' indirection flagged in review has been removed).

Context on correctness: For mise --silent run hello (with explicit run subcommand), the run subcommand's own silent field is not populated from the global flag — only Settings::get().silent is consulted by silent_bool(). Before this fix Settings::get().silent was always false here, so task output was not suppressed. The fix is the correct and necessary path.

Confidence Score: 5/5

• Safe to merge — minimal, targeted fix with correct logic and new e2e coverage.
• The change is two lines of idiomatic Rust in a well-understood settings-propagation function, the new test covers the four relevant flag combinations, and prior review concerns about test fragility have been fully addressed. No regressions are plausible given the additive nature of the change.
• No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["mise --silent run foo"] --> B["apply_cli_settings(cli)"]
    B --> C{"cli.quiet || cli.silent?"}
    C -- "yes (new: silent now matches)" --> D["s.quiet = Some(true)"]
    D --> E["Settings: log_level = 'error'\n(suppress mise info/warn messages)"]
    B --> F{"cli.silent?"}
    F -- "yes (new)" --> G["s.silent = Some(true)"]
    G --> H["Settings::get().silent = true"]
    H --> I["silent_bool() = true"]
    I --> J["TaskOutput::Silent\n(suppress task stdout/stderr)"]
    E --> K["✅ No mise messages"]
    J --> L["✅ No task output"]

    style D fill:#c8f7c5
    style G fill:#c8f7c5
    style K fill:#c8f7c5
    style L fill:#c8f7c5

_{Reviews (3): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile}