Skip to content

chore(ci): temporarily disable mise up in release-plz#8504

Merged
jdx merged 1 commit intomainfrom
fix/disable-mise-up-release-plz
Mar 7, 2026
Merged

chore(ci): temporarily disable mise up in release-plz#8504
jdx merged 1 commit intomainfrom
fix/disable-mise-up-release-plz

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Mar 7, 2026

Summary

  • Temporarily comments out mise up in xtasks/release-plz to unblock release-plz runs
  • fd v10.4.0 has a bad release — missing the fd-v10.4.0-x86_64-unknown-linux-musl.tar.gz asset, which causes mise up to fail

Test plan

  • release-plz workflow passes after merge

🤖 Generated with Claude Code


Note

Low Risk
Small CI-only change that skips a tool upgrade step; primary risk is releases using slightly outdated tool versions until re-enabled.

Overview
Temporarily disables the mise up step in xtasks/release-plz (leaving mise lock and subsequent steps intact) to unblock CI releases.

Adds a TODO comment documenting that this is a workaround for a broken fd v10.4.0 musl asset and should be re-enabled once upstream is fixed.

Written by Cursor Bugbot for commit 6283e4b. This will update automatically on new commits. Configure here.

fd v10.4.0 has a bad release — missing the
`fd-v10.4.0-x86_64-unknown-linux-musl.tar.gz` asset, which causes
`mise up` to fail and blocks all release-plz runs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a temporary workaround to resolve a critical dependency issue that was preventing release-plz workflows from executing. By disabling a specific command that was failing due to a problematic external release, the PR ensures that the release process can proceed without interruption until the underlying dependency problem is resolved.

Highlights

  • Temporary mise up disablement: The mise up command has been temporarily commented out in the xtasks/release-plz script to unblock release-plz workflows.
  • Dependency issue mitigation: This change addresses a failure caused by fd v10.4.0 having a bad release, specifically a missing asset (fd-v10.4.0-x86_64-unknown-linux-musl.tar.gz), which prevented mise up from completing successfully.
Changelog
  • xtasks/release-plz
    • Temporarily commented out the mise up command.
    • Added a comment explaining the reason for the disablement, referencing the fd v10.4.0 asset issue.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jdx jdx merged commit e6f73d0 into main Mar 7, 2026
27 checks passed
@jdx jdx deleted the fix/disable-mise-up-release-plz branch March 7, 2026 18:53
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request temporarily disables mise up in the release-plz script to work around a broken release of the fd tool. The change is correct and includes a helpful TODO comment. I've suggested a small improvement to the TODO to include a link to a tracking issue, which will make it easier to remember to revert this change once the upstream issue is fixed.

fi

mise up
# TODO: re-enable once fd v10.4.0 asset is fixed (missing fd-v10.4.0-x86_64-unknown-linux-musl.tar.gz)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better tracking of this temporary workaround, it's a good practice to include a link to the relevant issue (either in this repository or the upstream fd repository). This will make it easier to remember to re-enable this code once the issue is resolved.

# TODO(issue-link): re-enable once fd v10.4.0 asset is fixed (missing fd-v10.4.0-x86_64-unknown-linux-musl.tar.gz)

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 7, 2026

Greptile Summary

This PR is a minimal, targeted workaround that temporarily comments out mise up in xtasks/release-plz to unblock the release-plz workflow while fd v10.4.0 has a broken release (missing the fd-v10.4.0-x86_64-unknown-linux-musl.tar.gz asset). The rest of the release pipeline (mise lock, eval "$(mise env)", etc.) remains unaffected.

  • mise up is commented out with a clear TODO referencing the upstream fd issue.
  • mise lock still runs, which will lock the current (non-upgraded) tool versions — this is expected for the temporary workaround.
  • eval "$(mise env)" still executes and correctly sets up the PATH for the currently installed tools. The adjacent comment has been updated to accurately reflect the current state since mise up is temporarily disabled.

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, clearly-explained temporary workaround with no functional risk.
  • The change is a single-line comment-out with a descriptive TODO explaining the temporary workaround for a broken upstream release (fd v10.4.0). The remaining steps in the script (mise lock, eval "$(mise env)") are unaffected and will still run correctly. The workaround is clearly scoped and reversible. The adjacent comment has been improved to accurately describe the current state during the temporary period.
  • No files require special attention.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[release-plz script starts] --> B[Update CHANGELOG.md]
    B --> C{"mise up\n(DISABLED — fd v10.4.0 broken asset)"}
    C -->|"skipped (commented out)"| D[mise lock]
    D --> E["eval $(mise env)\n(refresh PATH for current tools)"]
    E --> F[Update embedded vfox plugins]
    F --> G[Continue release steps...]
Loading

Fix All in Claude Code

Last reviewed commit: 6283e4b

# TODO: re-enable once fd v10.4.0 asset is fixed (missing fd-v10.4.0-x86_64-unknown-linux-musl.tar.gz)
# mise up
mise lock
# Refresh PATH after mise up, since upgraded tools have new install paths
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on this line now refers to a step (mise up) that is commented out. While eval "$(mise env)" still runs (and is still useful for setting up the environment), the comment no longer accurately describes the context. Consider updating it to reflect that it sets up the environment for the currently installed tools, now that mise up is temporarily disabled.

Suggested change
# Refresh PATH after mise up, since upgraded tools have new install paths
# Refresh PATH to ensure tools have correct install paths
eval "$(mise env)"

Fix in Claude Code

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2026

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.3.4 x -- echo 23.1 ± 0.3 22.5 25.1 1.00
mise x -- echo 23.6 ± 0.7 22.7 31.8 1.02 ± 0.03

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.3.4 env 23.0 ± 0.6 22.0 29.1 1.00
mise env 23.0 ± 0.5 22.1 25.3 1.00 ± 0.03

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.3.4 hook-env 23.7 ± 0.6 22.6 30.7 1.01 ± 0.03
mise hook-env 23.6 ± 0.4 22.8 25.9 1.00

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.3.4 ls 22.7 ± 0.4 21.9 25.5 1.00
mise ls 22.9 ± 0.5 22.1 25.1 1.01 ± 0.03

xtasks/test/perf

Command mise-2026.3.4 mise Variance
install (cached) 150ms 151ms +0%
ls (cached) 83ms 83ms +0%
bin-paths (cached) 87ms 86ms +1%
task-ls (cached) 845ms 813ms +3%

jdx pushed a commit that referenced this pull request Mar 7, 2026
### 🚀 Features

- **(vfox)** add `RUNTIME.envType` for libc variant detection by @malept
in [#8493](#8493)
- store provenance verification results in lockfile by @jdx in
[#8495](#8495)

### 🐛 Bug Fixes

- **(env)** skip remote version fetching for "latest" in prefer-offline
mode by @jdx in [#8500](#8500)
- **(tasks)** deduplicate shared deps across task delegation by
@vadimpiven in [#8497](#8497)
- **(windows)** correctly identify mise binary without extension by @jdx
in [#8503](#8503)

### 🚜 Refactor

- **(core)** migrate cmd! callers to async with kill_on_drop by @jdx in
[a63f7d2](a63f7d2)

### Chore

- **(ci)** temporarily disable `mise up` in release-plz by @jdx in
[#8504](#8504)
- consolidate all linters into hk.pkl by @jdx in
[#8498](#8498)

## 📦 Aqua Registry Updates

#### New Packages (1)

- [`apache/ant`](https://github.com/apache/ant)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant