Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request constitutes the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Greptile SummaryThis is the Key changes:
Critical issue: The Confidence Score: 3/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["mise install ant@version"] --> B{"version <= 1.10.0?"}
B -->|yes| C["Error: Please use 1.10.1 or later"]
B -->|no| D["Build download URL<br/>archive.apache.org/dist/ant/binaries/<br/>apache-ant-SemVer-bin.Format"]
D --> E{"goos == windows?"}
E -->|yes| F["files: ant.bat<br/>format: tar.xz ⚠️"]
E -->|no| G["files: ant<br/>format: tar.xz ⚠️"]
F --> H["Fetch archive — HTTP 404<br/>tar.xz not available on archive.apache.org"]
G --> H
H --> I["Installation fails"]
style H fill:#f66,color:#fff
style I fill:#f66,color:#fff
style C fill:#fa0,color:#fff
Last reviewed commit: 2fbfce4 |
There was a problem hiding this comment.
Code Review
This pull request prepares for the 2026.3.5 release by updating the version across various files, including Cargo.toml, README.md, and completion scripts. It also adds a new package definition for apache/ant to the Aqua registry. I've found an issue in the new package definition that will cause checksum verification to fail.
Note: Security Review is unavailable for this PR.
| file_format: regexp | ||
| algorithm: sha512 | ||
| pattern: | ||
| checksum: ^(\b[A-Fa-f0-9]{128}\b) |
There was a problem hiding this comment.
The regular expression for the checksum appears to be incorrect. The checksum file for Apache Ant follows the format filename: HASH, but the provided regex ^(\b[A-Fa-f0-9]{128}\b) expects the hash to be at the beginning of the line. This will cause checksum verification to fail.
A more appropriate regex would capture the hash that appears after the colon at the end of the line.
checksum: ':\s*([a-fA-F0-9]{128})$'
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.4 x -- echo |
23.2 ± 0.9 | 22.0 | 40.0 | 1.00 |
mise x -- echo |
23.3 ± 0.4 | 21.7 | 28.1 | 1.00 ± 0.04 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.4 env |
22.6 ± 0.7 | 21.1 | 29.3 | 1.00 |
mise env |
22.7 ± 0.3 | 21.6 | 24.3 | 1.00 ± 0.03 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.4 hook-env |
23.3 ± 0.3 | 22.5 | 24.6 | 1.00 |
mise hook-env |
23.5 ± 0.3 | 22.8 | 25.0 | 1.01 ± 0.02 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.4 ls |
22.7 ± 0.4 | 21.7 | 24.8 | 1.00 |
mise ls |
22.7 ± 0.3 | 21.3 | 23.8 | 1.00 ± 0.02 |
xtasks/test/perf
| Command | mise-2026.3.4 | mise | Variance |
|---|---|---|---|
| install (cached) | 148ms | 149ms | +0% |
| ls (cached) | 82ms | 81ms | +1% |
| bin-paths (cached) | 84ms | 83ms | +1% |
| task-ls (cached) | 833ms | 820ms | +1% |
🚀 Features
RUNTIME.envTypefor libc variant detection by @malept in #8493🐛 Bug Fixes
🚜 Refactor
📦 Registry
Chore
mise upin release-plz by @jdx in #8504📦 Aqua Registry Updates
New Packages (1)
apache/ant