Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the mise installer by addressing a critical issue where setting MISE_INSTALL_PATH to an existing directory could lead to silent and unintended deletion of its contents. The changes introduce a preventative check and refine the file removal process, ensuring a safer installation experience and providing clearer feedback to users.

Highlights

• Installer Safety: Implemented a check to detect if MISE_INSTALL_PATH points to an existing directory, preventing accidental data loss by exiting with a clear error message.
• Refined Removal Command: Switched the rm -rf command to rm -f for the installation path, as the path is now confirmed not to be a directory, making the operation safer and more precise.

Greptile Summary

This PR fixes a destructive data-loss bug in the standalone installer where setting MISE_INSTALL_PATH to an existing directory (instead of a file path) caused the installer to silently run rm -rf on that directory. The fix adds a POSIX-compatible [ -d "$install_path" ] guard that exits with a clear, actionable error message before proceeding. The code also tightens rm -rf to rm -f now that a directory at the target path is guaranteed not to exist.

Key changes:

• Added a pre-rm directory check that aborts with a helpful error and example path when MISE_INSTALL_PATH resolves to a directory.
• Changed rm -rf "$install_path" → rm -f "$install_path" to eliminate any residual risk of recursive deletion (correct given the new guard).

The fix is minimal, safe, and uses standard POSIX shell constructs.

Confidence Score: 5/5

• This PR is safe to merge — it exclusively adds a safety guard for a destructive operation with no risk of regression.
• The change is minimal (3 lines added, 1 changed), targets a single clear bug, uses standard POSIX shell constructs, and the error() helper is already proven to exit cleanly with code 1. The directory check correctly prevents a data-loss scenario by catching user misconfiguration early.
• No files require special attention.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["User runs installer<br/>MISE_INSTALL_PATH set"] --> B["Resolve OS, arch, version"]
    B --> C["Construct tarball URL"]
    C --> D["Download tarball"]
    D --> E["Verify checksum"]
    E --> F{Is install_path<br/>a directory?}
    F -->|Yes| G["❌ Error: MISE_INSTALL_PATH is a directory<br/>exit 1"]
    F -->|No| H["Create install_dir"]
    H --> I["Remove old install_path if exists"]
    I --> J["Extract tarball"]
    J --> K["Move mise binary to install_path"]
    K --> L["✅ Success: mise installed"]
    G --> M["User sees clear error message<br/>and example correct path"]

_{Last reviewed commit: 7b763b8}

Hyperfine Performance

mise x -- echo

mise env

mise hook-env

mise ls

xtasks/test/perf