fix(schema): support structured objects in task depends#8463
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of task management by updating the JSON schemas for Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Greptile SummaryThis PR updates
Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Task dependency field\n(depends / depends_post / wait_for)"] --> B{Outer form}
B -->|string| C["Single task name\ne.g. 'build'"]
B -->|array| D["Array of items"]
D --> E{Item form — oneOf}
E -->|string| F["Task name\ne.g. 'lint'"]
E -->|array| G["Task + args\ne.g. ['test', '--fast']"]
E -->|object NEW| H["Structured object\n{ task, args?, env? }"]
H --> I["task: string (required)"]
H --> J["args: string[] (optional)"]
H --> K["env: Record<string,string> (optional)"]
Last reviewed commit: 9934bb2 |
There was a problem hiding this comment.
Code Review
This pull request introduces structured object support for task dependencies in the schema/mise.json and schema/mise-task.json files. The changes add a new schema definition for objects with task, args, and env properties, allowing more complex task dependency configurations. The env configuration remains a string-to-string IndexMap to align with Rust TaskDep deserialization constraints.
Note: Security Review has been skipped due to the limited scope of the PR.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the JSON schemas in schema/mise.json and schema/mise-task.json to support structured objects for task dependencies. A new definition, task_dependency_item, is introduced and applied to depends, depends_post, and wait_for. This new definition allows a dependency to be a string, an array of strings, or an object containing task, args, and env fields, which aligns the schema with the documented and implemented behavior. The changes also include numerous formatting adjustments across both schema files.
Note: Security Review has been skipped due to the limited scope of the PR.
### 🚀 Features - **(github)** keep exe extensions on Windows by @iki in [#8424](#8424) - **(task)** add `interactive` field for exclusive terminal access by @jdx in [#8491](#8491) - add header comment to generated lockfiles by @ivy in [#8481](#8481) - runtime musl/glibc detection for correct libc variant selection by @jdx in [#8490](#8490) ### 🐛 Bug Fixes - **(github)** use registry platform options during install by @jdx in [#8492](#8492) - **(http)** store tool opts as native TOML to fix platform switching by @jdx in [#8448](#8448) - **(installer)** error if MISE_INSTALL_PATH is a directory by @jdx in [#8468](#8468) - **(prepare)** resolve sources/outputs relative to `dir` when set by @jdx in [#8472](#8472) - **(ruby)** fetch precompiled binary by release tag instead of listing all releases by @jdx in [#8488](#8488) - **(schema)** support structured objects in task depends by @risu729 in [#8463](#8463) - **(task)** replace println!/eprintln! with calm_io in task output macros by @vmaleze in [#8485](#8485) - handle scoped npm package names without backend prefix by @jdx in [#8477](#8477) ### 📦️ Dependency Updates - update ghcr.io/jdx/mise:copr docker digest to c485c4c by @renovate[bot] in [#8484](#8484) - update ghcr.io/jdx/mise:alpine docker digest to 8118bc7 by @renovate[bot] in [#8483](#8483) ### 📦 Registry - disable sd version test by @jdx in [#8489](#8489) ### New Contributors - @ivy made their first contribution in [#8481](#8481) - @iki made their first contribution in [#8424](#8424) ## 📦 Aqua Registry Updates #### New Packages (5) - [`datadog-labs/pup`](https://github.com/datadog-labs/pup) - [`k1LoW/mo`](https://github.com/k1LoW/mo) - [`rtk-ai/rtk`](https://github.com/rtk-ai/rtk) - [`suzuki-shunsuke/docfresh`](https://github.com/suzuki-shunsuke/docfresh) - [`yashikota/exiftool-go`](https://github.com/yashikota/exiftool-go) #### Updated Packages (6) - [`cloudflare/cloudflared`](https://github.com/cloudflare/cloudflared) - [`mozilla/sccache`](https://github.com/mozilla/sccache) - [`owenlamont/ryl`](https://github.com/owenlamont/ryl) - [`spinel-coop/rv`](https://github.com/spinel-coop/rv) - [`technicalpickles/envsense`](https://github.com/technicalpickles/envsense) - [`weaviate/weaviate`](https://github.com/weaviate/weaviate)
Updates the JSON schema definitions in
schema/mise.jsonandschema/mise-task.jsonto officially support the structured{ task: string, args?: string[], env?: { [key]: string } }syntax fordepends,depends_post, andwait_for. The Rust codebase already properly supported this resolution via wildcards and matching.The
envconfiguration continues to be checked strictly as a string-to-stringIndexMapto align with the Rust TaskDep deserialization constraints.