fix(docs): improve favicon support for Safari#6567
Merged
Conversation
- Add .ico file as primary favicon for better Safari compatibility - Include PNG favicon variants (16x16, 32x32) with proper sizes - Keep SVG favicon for modern browsers - Fix apple-touch-icon to use proper PNG file instead of SVG - Proper fallback chain ensures all browsers get appropriate icon format Safari has historically had issues with SVG favicons, so providing .ico and PNG fallbacks ensures the favicon displays correctly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Improves favicon support for Safari by adding proper fallback formats and fixing apple-touch-icon configuration. This addresses historical Safari compatibility issues with SVG favicons.
- Added
.icofile as primary favicon with proper fallback chain - Included PNG favicon variants (16x16, 32x32) for better browser compatibility
- Fixed apple-touch-icon to use PNG format instead of SVG
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.10.4 x -- echo |
18.0 ± 0.7 | 17.3 | 27.4 | 1.00 |
mise x -- echo |
18.4 ± 0.4 | 17.3 | 20.1 | 1.03 ± 0.04 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.10.4 env |
17.8 ± 0.3 | 17.1 | 21.1 | 1.00 ± 0.04 |
mise env |
17.8 ± 0.6 | 16.8 | 22.9 | 1.00 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.10.4 hook-env |
16.9 ± 0.3 | 16.3 | 17.9 | 1.00 |
mise hook-env |
17.5 ± 0.7 | 16.7 | 25.9 | 1.03 ± 0.04 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.10.4 ls |
15.3 ± 0.4 | 14.6 | 18.6 | 1.02 ± 0.03 |
mise ls |
15.0 ± 0.2 | 14.5 | 16.1 | 1.00 |
xtasks/test/perf
| Command | mise-2025.10.4 | mise | Variance |
|---|---|---|---|
| install (cached) | 198ms | ✅ 105ms | +88% |
| ls (cached) | 63ms | 63ms | +0% |
| bin-paths (cached) | 69ms | 69ms | +0% |
| task-ls (cached) | 475ms | 463ms | +2% |
✅ Performance improvement: install cached is 88%
jdx
pushed a commit
that referenced
this pull request
Oct 7, 2025
### 📦 Registry - add jules by @alefteris in [#6568](#6568) ### 🐛 Bug Fixes - **(docs)** improve favicon support for Safari by @jdx in [#6567](#6567) - **(github)** download assets via API to respect GITHUB_TOKEN by @roele in [#6496](#6496) - **(task)** load toml tasks in `task_config.includes` in system/global config and monorepo subdirs by @risu729 in [#6545](#6545) - **(task)** handle dots in monorepo directory names correctly by @jdx in [#6571](#6571) ### 📚 Documentation - **(readme)** add GitHub Issues & Discussions section by @rsyring in [#6573](#6573) - **(tasks)** create dedicated monorepo tasks documentation by @jdx in [#6561](#6561) - **(tasks)** enhance monorepo documentation with tool comparisons by @jdx in [#6563](#6563)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes favicon display issues in Safari by adding proper fallback formats.
Changes
.icofile as primary favicon for better Safari compatibilityapple-touch-iconto use proper PNG file instead of SVGWhy
Safari has historically had issues with SVG favicons. By providing
.icoand PNG fallbacks in the proper order, the favicon will now display correctly across all browsers.🤖 Generated with Claude Code
Note
Adds .ico and PNG favicon variants and updates apple-touch-icon to PNG for broader browser compatibility.
docs/.vitepress/config.ts):favicon.ico(any),favicon-16x16.png,favicon-32x32.png.apple-touch-iconSVG withapple-touch-icon.png(180x180).Written by Cursor Bugbot for commit 581e465. This will update automatically on new commits. Configure here.