Conversation
task_config.include in system/global config and monorepo subdirs
task_config.include in system/global config and monorepo subdirstask_config.includes in system/global config and monorepo subdirs
76b0db5 to
9bea95a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes task loading from TOML files specified in task_config.includes configuration in system/global config and monorepo subdirectories. Previously, the code only worked for directories but failed to load tasks from individual TOML files.
- Refactored
load_tasks_includesto handle both files and directories properly - Simplified
load_tasks_in_dirby removing duplicate TOML file handling logic - Added comprehensive end-to-end test for monorepo task includes functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/config/mod.rs | Fixed task loading logic to support TOML files in includes and simplified duplicate code |
| e2e/tasks/test_task_monorepo_includes | Added comprehensive test coverage for monorepo task includes with both TOML and script files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Owner
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Owner
|
bugbot run |
jdx
pushed a commit
that referenced
this pull request
Oct 7, 2025
### 📦 Registry - add jules by @alefteris in [#6568](#6568) ### 🐛 Bug Fixes - **(docs)** improve favicon support for Safari by @jdx in [#6567](#6567) - **(github)** download assets via API to respect GITHUB_TOKEN by @roele in [#6496](#6496) - **(task)** load toml tasks in `task_config.includes` in system/global config and monorepo subdirs by @risu729 in [#6545](#6545) - **(task)** handle dots in monorepo directory names correctly by @jdx in [#6571](#6571) ### 📚 Documentation - **(readme)** add GitHub Issues & Discussions section by @rsyring in [#6573](#6573) - **(tasks)** create dedicated monorepo tasks documentation by @jdx in [#6561](#6561) - **(tasks)** enhance monorepo documentation with tool comparisons by @jdx in [#6563](#6563)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It works fine for directories, but not for TOML files.
This PR treats tasks in
tasks.tomlas "file tasks", but I think it won't cause any issues.I'll refactor the code around
includeslater, as currently it seems some parts are duplicated.Also, I noticed
task_includesinmise.local.tomlwas not honoured ifmise.tomlhad it.Note
Enable loading tasks from TOML files in
task_config.includesand unify include processing for files/dirs, with new e2e tests for monorepo task discovery/execution.load_tasks_includesnow supports.tomlfiles viaload_task_file; keeps dir scan for executable scripts.load_tasks_in_dir/load_file_taskssimplified to usetask_includes_for_dirand the unified loader; removed duplicate TOML-only path handling.e2e/tasks/test_task_monorepo_includesto validate monorepo task discovery and execution (root, subdir, wildcard), including TOML-defined tasks and script tasks with multiple-dot names.Written by Cursor Bugbot for commit afedda9. This will update automatically on new commits. Configure here.