[performance] Eliminate per-request regex and allocation overhead#2560
Merged
Conversation
Member
Author
|
augment review |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2560 +/- ##
============================================
- Coverage 86.24% 86.23% -0.02%
- Complexity 1507 1510 +3
============================================
Files 155 155
Lines 4356 4359 +3
Branches 525 526 +1
============================================
+ Hits 3757 3759 +2
Misses 366 366
- Partials 233 234 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 Augment PR SummarySummary: Reduces request-path overhead by removing regex/allocation-heavy operations in routing and request parsing hot paths. Changes: Uses lightweight loops/try-catch/prefix-suffix ops for method validation and decoding, adds a static-route early-exit in 🤖 Was this summary useful? React with 👍 or 👎 |
b768c73 to
e1331f8
Compare
Member
Author
|
augment review |
- Early-exit extractPathParams for static routes (skip regex/zip/toMap) - Replace regex replaceFirst with removePrefix/removeSuffix in pathParamOrThrow - Replace regex validation with char loop in HandlerType.findOrCreate - Cache MimeTypesConfig.mapping() (stop copying map per static file request) - Replace runCatching with try-catch in urlDecode (avoid Result boxing) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e1331f8 to
9f7da51
Compare
Member
Author
|
augment review |
mergify Bot
added a commit
to robfrank/linklift
that referenced
this pull request
Mar 19, 2026
Bumps `javalin.version` from 7.0.1 to 7.1.0. Updates `io.javalin:javalin-bundle` from 7.0.1 to 7.1.0 Release notes *Sourced from [io.javalin:javalin-bundle's releases](https://github.com/javalin/javalin/releases).* > 7.1.0 > ----- > > What's Changed > -------------- > > * Bump com.fasterxml.jackson.core:jackson-core from 2.21.0 to 2.21.1 by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2543](https://redirect.github.com/javalin/javalin/pull/2543) > * [deps]: Bump the dependencies group across 1 directory with 17 updates by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2545](https://redirect.github.com/javalin/javalin/pull/2545) > * [websocket] Fix WebSocket over HTTP/2 Extended Connect (RFC 8441) by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2547](https://redirect.github.com/javalin/javalin/pull/2547) > * fix(README): update artifactId for SSL plugin in `README.md` by [`@yvasyliev`](https://github.com/yvasyliev) in [javalin/javalin#2556](https://redirect.github.com/javalin/javalin/pull/2556) > * Add `wsExceptionHandler` to `MicrometerPlugin` for WebSocket exception tagging by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2557](https://redirect.github.com/javalin/javalin/pull/2557) > * [rendering] jte - introduce directoryTemplateEngine for (6.x-like), rename default to classPathTemplateEngine by [`@elwin013`](https://github.com/elwin013) in [javalin/javalin#2551](https://redirect.github.com/javalin/javalin/pull/2551) > * Add javalin-bom module by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2558](https://redirect.github.com/javalin/javalin/pull/2558) > * [performance] Reduce per-request overhead in hot path by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2559](https://redirect.github.com/javalin/javalin/pull/2559) > * [performance] Eliminate per-request regex and allocation overhead by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2560](https://redirect.github.com/javalin/javalin/pull/2560) > > New Contributors > ---------------- > > * [`@yvasyliev`](https://github.com/yvasyliev) made their first contribution in [javalin/javalin#2556](https://redirect.github.com/javalin/javalin/pull/2556) > * [`@elwin013`](https://github.com/elwin013) made their first contribution in [javalin/javalin#2551](https://redirect.github.com/javalin/javalin/pull/2551) > > **Full Changelog**: <javalin/javalin@javalin-parent-7.0.1...javalin-parent-7.1.0> Commits * [`e458dba`](javalin/javalin@e458dba) [maven-release-plugin] prepare for next development iteration * [`9766d2f`](javalin/javalin@9766d2f) [maven-release-plugin] prepare release javalin-parent-7.1.0 * [`12acf0b`](javalin/javalin@12acf0b) [performance] Eliminate per-request regex and allocation overhead ([#2560](https://redirect.github.com/javalin/javalin/issues/2560)) * [`f6a1e40`](javalin/javalin@f6a1e40) [performance] Reduce per-request overhead in hot path * [`1e59eda`](javalin/javalin@1e59eda) [pom] Add javalin-bom module ([#2558](https://redirect.github.com/javalin/javalin/issues/2558)) * [`b43f37a`](javalin/javalin@b43f37a) [rendering] jte - introduce directoryTemplateEngine for (6.x-like behavior) * [`72b2320`](javalin/javalin@72b2320) [micrometer] Add `wsExceptionHandler` to `MicrometerPlugin` * [`37c91c4`](javalin/javalin@37c91c4) [readme] Update artifactId for SSL plugin * [`9acf45e`](javalin/javalin@9acf45e) [cleanup] Use Header constants * [`0289084`](javalin/javalin@0289084) [headers] Add missing headers to Header.kt * Additional commits viewable in [compare view](javalin/javalin@javalin-parent-7.0.1...7.1.0) Updates `io.javalin.community.openapi:javalin-openapi-plugin` from 7.0.1 to 7.1.0 Release notes *Sourced from [io.javalin.community.openapi:javalin-openapi-plugin's releases](https://github.com/javalin/javalin-openapi/releases).* > 7.1.0 > ----- > > **Changes** > > * [javalin/javalin-openapi#275](https://redirect.github.com/javalin/javalin-openapi/issues/275) [Make ClassLoader used for loading resources configurable](javalin/javalin-openapi@de1b6b7) > * Support Javalin 7.1.0 > > **Sponsors** > Thanks to everyone who supported me this month 💜 > > **Minimal requirements** > > * Java 17+ / Kotlin 2.3+ > * Javalin 7.1.0 Commits * [`5388862`](javalin/javalin-openapi@5388862) [GH-275](https://redirect.github.com/javalin/javalin-openapi/issues/275) Cover missing resource loaders and release 7.1.1-rc.1 * [`cbbc8d0`](javalin/javalin-openapi@cbbc8d0) [GH-276](https://redirect.github.com/javalin/javalin-openapi/issues/276) Release 7.1.0 (Resolves [#276](https://redirect.github.com/javalin/javalin-openapi/issues/276)) * [`de1b6b7`](javalin/javalin-openapi@de1b6b7) [GH-275](https://redirect.github.com/javalin/javalin-openapi/issues/275) Make ClassLoader used for loading resources configurable (Resolves [#275](https://redirect.github.com/javalin/javalin-openapi/issues/275)) * See full diff in [compare view](javalin/javalin-openapi@7.0.1...7.1.0) Updates `io.javalin.community.openapi:javalin-swagger-plugin` from 7.0.1 to 7.1.0 Release notes *Sourced from [io.javalin.community.openapi:javalin-swagger-plugin's releases](https://github.com/javalin/javalin-openapi/releases).* > 7.1.0 > ----- > > **Changes** > > * [javalin/javalin-openapi#275](https://redirect.github.com/javalin/javalin-openapi/issues/275) [Make ClassLoader used for loading resources configurable](javalin/javalin-openapi@de1b6b7) > * Support Javalin 7.1.0 > > **Sponsors** > Thanks to everyone who supported me this month 💜 > > **Minimal requirements** > > * Java 17+ / Kotlin 2.3+ > * Javalin 7.1.0 Commits * [`5388862`](javalin/javalin-openapi@5388862) [GH-275](https://redirect.github.com/javalin/javalin-openapi/issues/275) Cover missing resource loaders and release 7.1.1-rc.1 * [`cbbc8d0`](javalin/javalin-openapi@cbbc8d0) [GH-276](https://redirect.github.com/javalin/javalin-openapi/issues/276) Release 7.1.0 (Resolves [#276](https://redirect.github.com/javalin/javalin-openapi/issues/276)) * [`de1b6b7`](javalin/javalin-openapi@de1b6b7) [GH-275](https://redirect.github.com/javalin/javalin-openapi/issues/275) Make ClassLoader used for loading resources configurable (Resolves [#275](https://redirect.github.com/javalin/javalin-openapi/issues/275)) * See full diff in [compare view](javalin/javalin-openapi@7.0.1...7.1.0) Updates `io.javalin:javalin-micrometer` from 7.0.1 to 7.1.0 Release notes *Sourced from [io.javalin:javalin-micrometer's releases](https://github.com/javalin/javalin/releases).* > 7.1.0 > ----- > > What's Changed > -------------- > > * Bump com.fasterxml.jackson.core:jackson-core from 2.21.0 to 2.21.1 by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2543](https://redirect.github.com/javalin/javalin/pull/2543) > * [deps]: Bump the dependencies group across 1 directory with 17 updates by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2545](https://redirect.github.com/javalin/javalin/pull/2545) > * [websocket] Fix WebSocket over HTTP/2 Extended Connect (RFC 8441) by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2547](https://redirect.github.com/javalin/javalin/pull/2547) > * fix(README): update artifactId for SSL plugin in `README.md` by [`@yvasyliev`](https://github.com/yvasyliev) in [javalin/javalin#2556](https://redirect.github.com/javalin/javalin/pull/2556) > * Add `wsExceptionHandler` to `MicrometerPlugin` for WebSocket exception tagging by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2557](https://redirect.github.com/javalin/javalin/pull/2557) > * [rendering] jte - introduce directoryTemplateEngine for (6.x-like), rename default to classPathTemplateEngine by [`@elwin013`](https://github.com/elwin013) in [javalin/javalin#2551](https://redirect.github.com/javalin/javalin/pull/2551) > * Add javalin-bom module by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2558](https://redirect.github.com/javalin/javalin/pull/2558) > * [performance] Reduce per-request overhead in hot path by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2559](https://redirect.github.com/javalin/javalin/pull/2559) > * [performance] Eliminate per-request regex and allocation overhead by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2560](https://redirect.github.com/javalin/javalin/pull/2560) > > New Contributors > ---------------- > > * [`@yvasyliev`](https://github.com/yvasyliev) made their first contribution in [javalin/javalin#2556](https://redirect.github.com/javalin/javalin/pull/2556) > * [`@elwin013`](https://github.com/elwin013) made their first contribution in [javalin/javalin#2551](https://redirect.github.com/javalin/javalin/pull/2551) > > **Full Changelog**: <javalin/javalin@javalin-parent-7.0.1...javalin-parent-7.1.0> Commits * [`e458dba`](javalin/javalin@e458dba) [maven-release-plugin] prepare for next development iteration * [`9766d2f`](javalin/javalin@9766d2f) [maven-release-plugin] prepare release javalin-parent-7.1.0 * [`12acf0b`](javalin/javalin@12acf0b) [performance] Eliminate per-request regex and allocation overhead ([#2560](https://redirect.github.com/javalin/javalin/issues/2560)) * [`f6a1e40`](javalin/javalin@f6a1e40) [performance] Reduce per-request overhead in hot path * [`1e59eda`](javalin/javalin@1e59eda) [pom] Add javalin-bom module ([#2558](https://redirect.github.com/javalin/javalin/issues/2558)) * [`b43f37a`](javalin/javalin@b43f37a) [rendering] jte - introduce directoryTemplateEngine for (6.x-like behavior) * [`72b2320`](javalin/javalin@72b2320) [micrometer] Add `wsExceptionHandler` to `MicrometerPlugin` * [`37c91c4`](javalin/javalin@37c91c4) [readme] Update artifactId for SSL plugin * [`9acf45e`](javalin/javalin@9acf45e) [cleanup] Use Header constants * [`0289084`](javalin/javalin@0289084) [headers] Add missing headers to Header.kt * Additional commits viewable in [compare view](javalin/javalin@javalin-parent-7.0.1...7.1.0) Updates `io.javalin:javalin-testtools` from 7.0.1 to 7.1.0 Release notes *Sourced from [io.javalin:javalin-testtools's releases](https://github.com/javalin/javalin/releases).* > 7.1.0 > ----- > > What's Changed > -------------- > > * Bump com.fasterxml.jackson.core:jackson-core from 2.21.0 to 2.21.1 by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2543](https://redirect.github.com/javalin/javalin/pull/2543) > * [deps]: Bump the dependencies group across 1 directory with 17 updates by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2545](https://redirect.github.com/javalin/javalin/pull/2545) > * [websocket] Fix WebSocket over HTTP/2 Extended Connect (RFC 8441) by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2547](https://redirect.github.com/javalin/javalin/pull/2547) > * fix(README): update artifactId for SSL plugin in `README.md` by [`@yvasyliev`](https://github.com/yvasyliev) in [javalin/javalin#2556](https://redirect.github.com/javalin/javalin/pull/2556) > * Add `wsExceptionHandler` to `MicrometerPlugin` for WebSocket exception tagging by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2557](https://redirect.github.com/javalin/javalin/pull/2557) > * [rendering] jte - introduce directoryTemplateEngine for (6.x-like), rename default to classPathTemplateEngine by [`@elwin013`](https://github.com/elwin013) in [javalin/javalin#2551](https://redirect.github.com/javalin/javalin/pull/2551) > * Add javalin-bom module by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2558](https://redirect.github.com/javalin/javalin/pull/2558) > * [performance] Reduce per-request overhead in hot path by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2559](https://redirect.github.com/javalin/javalin/pull/2559) > * [performance] Eliminate per-request regex and allocation overhead by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2560](https://redirect.github.com/javalin/javalin/pull/2560) > > New Contributors > ---------------- > > * [`@yvasyliev`](https://github.com/yvasyliev) made their first contribution in [javalin/javalin#2556](https://redirect.github.com/javalin/javalin/pull/2556) > * [`@elwin013`](https://github.com/elwin013) made their first contribution in [javalin/javalin#2551](https://redirect.github.com/javalin/javalin/pull/2551) > > **Full Changelog**: <javalin/javalin@javalin-parent-7.0.1...javalin-parent-7.1.0> Commits * [`e458dba`](javalin/javalin@e458dba) [maven-release-plugin] prepare for next development iteration * [`9766d2f`](javalin/javalin@9766d2f) [maven-release-plugin] prepare release javalin-parent-7.1.0 * [`12acf0b`](javalin/javalin@12acf0b) [performance] Eliminate per-request regex and allocation overhead ([#2560](https://redirect.github.com/javalin/javalin/issues/2560)) * [`f6a1e40`](javalin/javalin@f6a1e40) [performance] Reduce per-request overhead in hot path * [`1e59eda`](javalin/javalin@1e59eda) [pom] Add javalin-bom module ([#2558](https://redirect.github.com/javalin/javalin/issues/2558)) * [`b43f37a`](javalin/javalin@b43f37a) [rendering] jte - introduce directoryTemplateEngine for (6.x-like behavior) * [`72b2320`](javalin/javalin@72b2320) [micrometer] Add `wsExceptionHandler` to `MicrometerPlugin` * [`37c91c4`](javalin/javalin@37c91c4) [readme] Update artifactId for SSL plugin * [`9acf45e`](javalin/javalin@9acf45e) [cleanup] Use Header constants * [`0289084`](javalin/javalin@0289084) [headers] Add missing headers to Header.kt * Additional commits viewable in [compare view](javalin/javalin@javalin-parent-7.0.1...7.1.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HandlerType.findOrCreatewith a simple char loop (also removes redundanttoUpperCase())runCatchingwith try-catch inurlDecodeto avoidResultobject boxing on every callreplaceFirst(regex-based) withremovePrefix/removeSuffixinpathParamOrThrowPathParser.extractPathParamsfor static routes (no path params → skip regex matching)MapinMimeTypesConfigwith rebuild onadd()— eliminates defensivetoMap()copy on everymapping()call while maintaining proper encapsulationTest plan
HandlerType.findOrCreatestill validates input and rejects invalid method namesMimeTypesConfig.add()still correctly registers MIME typesemptyMap())