Client: Pass through flag for ctrlmidich used #2839

pljones · 2022-09-05T20:50:17Z

Short description of changes

Rather than changing the name of the connecting client (and losing the actual name), based on whether --ctrlmidich is used, pass that information to the fader itself.

Also, to partly undo the damage, attempt to recover fader details previously saved with the channel number prefix.

CHANGELOG: Client: Bugfix: Remove channel number from saved fader tag when --ctrlmidich is in use. In this release --cleanuplegacyfadersettings can be used on any saved fader settings that have been corrupted to attempt recovery.

Context: Fixes an issue?

Fixes: #2680

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

I've tested it local. The following should be borne in mind:

This does not remove entries from Jamulus.ini (it should match the old ones, but they'll still be there, cleaned values will get written).
I've not tested fader sort options.

What is missing until this pull request can be merged?

User test: @pcar75 and @rdica - can you take a look, please?

Checklist

I've verified that this Pull Request follows the general code principles
I tested my code and it does what I want
My code follows the style guide
I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
I've filled all the content above

ignotus666 · 2022-09-06T09:17:48Z

Won't be able to test until tomorrow but will do so.

pcar75 · 2022-09-06T16:00:53Z

Bonjour,

What is missing until this pull request can be merged?
User test: @pcar75 and @rdica - can you take a look, please?

Sorry I missed @pljones message above ... first time I participate in a project (since retirement he he :-).

Before any tests , I need to know that I could - and how I would - revert to my current Jamulus version ?
Given that , I can test in my Windows 10 env ... not my new Ubuntu Studio env as it is still somewhat unstable.

Where do I get the modified version and how to install it ?
Any specifics tests/procedures you would like me to run ?
Where and how do I report results ?
By what date & time are results expected (latest) ?

Thanks

Tests scenarios considered :

-Not broken :
01- Make a backup of original jamulus.ini (populated with fader info)
02- Execute jamulus (no ctrlmidich) and connect to a session with some known fader tag (user)
03- Modify 1 info (level) about it's fader
04- Use Save Mixer Channels Setup (to IETest01.jch )
05- End session and exit jamulus
06- Compare new and old jamulus.ini; verify that only 1 fader info was changed and that fadertags do not contain channel number.
07- Compare IETest01.jch and old jamulus.ini; verify that only 1 fader info was changed and that fadertags do not contain channel number.

-Currated1
01- Restore backup of original jamulus.ini
02- Modify jamulus shortcut to add -ctrlmidich "1:o2" argument
03- Execute jamulus on a session with some known fader tag
04- Modify 1 info (level) about it's fader
05- Use Save Mixer Channels Setup (to IETest02.jch )
06- End session and exit jamulus
07- Compare new and old jamulus.ini; verify that only 1 fader info was changed and that fadertags do not contain channel number.
08- Compare IETest02.jch and old jamulus.ini; verify that only 1 fader info was changed and that fadertags do not contain channel number.

pljones · 2022-09-06T16:37:23Z

Hi @pcar75

Where do I get the modified version and how to install it ?

Open the "Checks" tab on this pull request in a new browser tab then select the "Auto-Build" group. You'll see a number of "Artifacts". Pick whichever you need -- it will be a ZIP containing the normal install file for that platform.

When installing, I'd recommend using a separate folder, then "reverting" isn't a problem (the windows installer will remember this new location as the default for your next install but nothing else will care).

Never use one of your "real" inifiles for test purposes - back them up (just in case) and use copies (not the backups, fresh copies...).

For test purposes:

run 3.9.0 with a clean --inifile (either take a copy and manually just delete all the fader details or start afresh)
- save to a new save file
- check the bug is there
- check how fader sorting works
- exit the app and see the inifile has the bug, too
run the build from this pull request (again, either a copy of your 3.9.0 inifile with the fader details removed or a fresh one)
- save to a new save file
- check the bug fixed
- check how fader sorting works - it should be the same... hopefully...
- exit the app and see the inifile is also good
run the build from this pull request (ideally a copy of your 3.9.0 inifile with the buggy fader details)
- take a copy of a buggy save file
- load the settings from the copy
- save to a new save file
- check the bug is fixed
- exit the app and check the ini file is now sane

pcar75 · 2022-09-07T17:53:23Z

@pljones
Upgraded to 3.9.0. Tested that incorrect behavior is still there with jamulus.ini , fader sorting (by name is by "ChannelNumber:Name") and Export (same as .ini file).

But, per your instruction, I cannot find a downloadable file of your fix https://github.com/jamulussoftware/jamulus/runs/8226558392?check_suite_focus=true

pljones · 2022-09-07T18:54:21Z

You haven't followed the instructions.
Click: https://github.com/jamulussoftware/jamulus/pull/2839/checks
Click on ("Auto-Build", not the ">")
Scroll down and find the build you want:

The download will be a ZIP.

ignotus666 · 2022-09-07T20:30:13Z

Just did some testing and it seems to work as advertised. An old .ini file with the bug gets written over with correct fader tags (no prepending with a number) and sorting seems to be correct too.

pcar75 · 2022-09-07T22:51:42Z

run the build from this pull request (again, either a copy of your 3.9.0 inifile with the fader details removed or a fresh one)

Test Ok : --ctrlmidich does not make Jamulus write ini file with ChannelNumber,
ImportExport file also OK.
Sort by Name does not sort by ChannelNumber.

run the build from this pull request (ideally a copy of your 3.9.0 inifile with the buggy fader details)

Test Ok : buggy ini with Jamulus no --ctrlmidich is rewritten without ChannelNumber.
ImportExport file also OK
Sort by Name Ok

pljones · 2022-09-08T06:14:03Z

Thanks both!

pljones · 2022-09-08T06:18:26Z

src/settings.cpp

-        vecStoredFaderTags[iIdx] =
+        QString strFaderTag =
            FromBase64ToString ( GetIniSetting ( IniXMLDocument, "client", QString ( "storedfadertag%1_base64" ).arg ( iIdx ), "" ) );
+        bool        ok;


Move into the correct scope - inside the if.

src/settings.cpp

pcar75 · 2022-09-08T16:27:13Z

Bonjour,
Shouldn't there be a test with a real MIDI device ? (I don't have one.)

ignotus666 · 2022-09-08T16:55:36Z

I tested it with a MIDI device - works fine.

hoffie

The code looks good to me. I've got one behavioral question though:

Before this change, MIDI channel ifs were hacked into the fader name and neither the fader nor the settings logic knew about that, right?

With this change, the fader learns about that logic and keeps the information properly separated. This has the consequence that a user who used the feature previously would lose the stored fader values assignments as the fader tags would not match, right?

Therefore, this PR contains compatibility code to make those old entries fit into the new (better) scheme, right?

My worries are that this cleanup logic also applies to matching fader tags which did not stem from midi channel usage at all.

If my Jamulus name was hoffie:1, my name would be reduced to just hoffie and th entry would no longer match. Is that correct or is something preventing this?

If this is the case, do we really want that? It would help MIDI users but might introduce such bugs for non-MIDI users. Should we limit this conversion behavior to MIDI users maybe?
We should also add a note when this logic was introduced (version) and when it would be safe to drop.

(I'm writing this from mobile so I might have missed a relevant detail)

pljones · 2022-09-09T16:07:07Z

If my Jamulus name was hoffie:1, my name would be reduced to just hoffie and th entry would no longer match. Is that correct or is something preventing this?

No. The logic would "clean up" 1:hoffie to hoffie but leave any non-numeric:anything at all alone.

So yes, if you do insist on play with people who choose to name themselves with a leading number then a colon, you'll not have those settings loaded correctly (and it'll get duplicates the other way). The way around that would be to live with it and use some other separator instead.

I'm inclined to leave this as not requiring documentation as choosing a client name isn't really part of the protocol. I'm hoping the "clean up" code can be removed in 3.10.0 anyway. I'm not even sure the benefit of having it outweighs the ... potential confusion...

pljones · 2022-09-12T21:45:41Z

Maybe also document the special flag as part of the Changelog with a note saying that this flag is only required once and is about to be removed in an upcoming version again.

I've added it to the "changelog" tag on the PR - I've tried to keep it short but it can be edited/formatted better when we get there.

ann0see · 2022-09-13T15:31:38Z

src/main.cpp

        }

+        // Clean up legacy fader settings --------------------------------------
+        // Undocumented temporary command line argument: Clean up fader settings


Since we agreed to remove this soon, I'd prefer to document it in the help text, and remove it later on.

It's going to be totally meaningless to most users. To those for whom it's applicable, they'll use it once and never again. I can't see the point of making the help text get even larger than it is now for this.

As it's a short term feature, and if I wanted to use it, I'd like to know which version has it. If it shows up under --help, the version supports it, else not. It's much easier than going through the changelog on GH for end users.

If it shows up under --help, the version supports it,

If running the app with the option doesn't complain it's not recognised, that means it's supported, too.

Also, if it goes into help, that means we should update the website User Guide, too.

If running the app with the option doesn't complain it's not recognised, that means it's supported, too.

Fair point.

I'd still like to have it prominently documented somewhere besides the release announcement. I assume most users don't read the announcement at all.

Probably?
What about printing it to stdout if the --ctrlmidich option is set and to the website as long as it's in?

You mean in main.cpp when it parses --ctrlmidich, output a hint? Desktop client users generally won't see that (on Windows we launch without a terminal attached so output goes "nowhere") and most who use it will have edited their shortcuts, I'd expect.

The people it's likely relevant for are those who'll be searching the internet for a fix for the problem. I'm not sure how well our documentation gets picked up by search engines -- or how best to get new documentation into it so it's found in a timely manner.

We could write a forum post with a how to?

This all arose in https://github.com/orgs/jamulussoftware/discussions/2678 -- that could have a comment added with how to fix it.

I've noted on the Reminders for the release announcement to comment on the original discussion, so going ahead with the merge here.

ann0see

Other than my comment, I'm happy to approve it.

Related to: jamulussoftware/jamulus#2839

* Make recording toggle name consistent * AUTO: Updated .po files * AUTO: Add new language: (pt_BR) #802 * Repair corrections of various terms (#792) * AUTO: Updated .po files * Translations update from Hosted Weblate (#803) * Translated using Weblate (Portuguese (Brazil)) Currently translated at 3.9% (2 of 51 strings) Translation: Jamulus/Client-Troubleshooting Translate-URL: https://hosted.weblate.org/projects/jamulus/client-troubleshooting/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 13.3% (2 of 15 strings) Translation: Jamulus/Custom-Directories Translate-URL: https://hosted.weblate.org/projects/jamulus/custom-directories/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 10.0% (2 of 20 strings) Translation: Jamulus/Installation-for-Android Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-android/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 7.4% (2 of 27 strings) Translation: Jamulus/Installation-for-iOS Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 11.1% (2 of 18 strings) Translation: Jamulus/Server-Bandwidth Translate-URL: https://hosted.weblate.org/projects/jamulus/server-bandwidth/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 18.1% (2 of 11 strings) Translation: Jamulus/Command-Line-Options Translate-URL: https://hosted.weblate.org/projects/jamulus/command-line-options/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 5.4% (2 of 37 strings) Translation: Jamulus/Installation-for-Linux Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-linux/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 20.0% (2 of 10 strings) Translation: Jamulus/Contribution Translate-URL: https://hosted.weblate.org/projects/jamulus/contribution/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 28.9% (11 of 38 strings) Translation: Jamulus/Getting-Started Translate-URL: https://hosted.weblate.org/projects/jamulus/getting-started/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 5.5% (2 of 36 strings) Translation: Jamulus/FAQ Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 6.4% (2 of 31 strings) Translation: Jamulus/Installation-for-Macintosh Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-macintosh/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 4.0% (2 of 50 strings) Translation: Jamulus/Installation-for-Windows Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-windows/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 8.0% (2 of 25 strings) Translation: Jamulus/Privacy-Statement Translate-URL: https://hosted.weblate.org/projects/jamulus/privacy-statement/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 18.1% (2 of 11 strings) Translation: Jamulus/QOS-Windows Translate-URL: https://hosted.weblate.org/projects/jamulus/qos-windows/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 1.4% (2 of 139 strings) Translation: Jamulus/Running-a-Server Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 7.1% (2 of 28 strings) Translation: Jamulus/Server-Troubleshooting Translate-URL: https://hosted.weblate.org/projects/jamulus/server-troubleshooting/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 1.4% (2 of 135 strings) Translation: Jamulus/Software-Manual Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 4.2% (2 of 47 strings) Translation: Jamulus/Tips-Tricks-More Translate-URL: https://hosted.weblate.org/projects/jamulus/tips-tricks-more/pt_BR/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 4.0% (1 of 25 strings) Translation: Jamulus/navigation Translate-URL: https://hosted.weblate.org/projects/jamulus/navigation/pt_BR/ * Translated using Weblate (French) Currently translated at 96.2% (26 of 27 strings) Translation: Jamulus/1-index Translate-URL: https://hosted.weblate.org/projects/jamulus/1-index/fr/ * Translated using Weblate (French) Currently translated at 100.0% (36 of 36 strings) Translation: Jamulus/FAQ Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/fr/ * Translated using Weblate (French) Currently translated at 100.0% (36 of 36 strings) Translation: Jamulus/FAQ Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/fr/ * Translated using Weblate (French) Currently translated at 100.0% (19 of 19 strings) Translation: Jamulus/Include-Server-Commands Translate-URL: https://hosted.weblate.org/projects/jamulus/include-server-commands/fr/ * Translated using Weblate (French) Currently translated at 95.6% (133 of 139 strings) Translation: Jamulus/Running-a-Server Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/fr/ * Translated using Weblate (French) Currently translated at 100.0% (135 of 135 strings) Translation: Jamulus/Software-Manual Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/fr/ * Translated using Weblate (French) Currently translated at 91.4% (43 of 47 strings) Translation: Jamulus/Tips-Tricks-More Translate-URL: https://hosted.weblate.org/projects/jamulus/tips-tricks-more/fr/ * Translated using Weblate (French) Currently translated at 100.0% (47 of 47 strings) Translation: Jamulus/Tips-Tricks-More Translate-URL: https://hosted.weblate.org/projects/jamulus/tips-tricks-more/fr/ * Translated using Weblate (French) Currently translated at 100.0% (20 of 20 strings) Translation: Jamulus/Installation-for-Android Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-android/fr/ * Translated using Weblate (French) Currently translated at 100.0% (37 of 37 strings) Translation: Jamulus/Installation-for-Linux Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-linux/fr/ * Translated using Weblate (French) Currently translated at 100.0% (31 of 31 strings) Translation: Jamulus/Installation-for-Macintosh Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-macintosh/fr/ * Translated using Weblate (French) Currently translated at 100.0% (50 of 50 strings) Translation: Jamulus/Installation-for-Windows Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-windows/fr/ * Translated using Weblate (French) Currently translated at 100.0% (27 of 27 strings) Translation: Jamulus/Installation-for-iOS Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/fr/ * Translated using Weblate (French) Currently translated at 100.0% (47 of 47 strings) Translation: Jamulus/Tips-Tricks-More Translate-URL: https://hosted.weblate.org/projects/jamulus/tips-tricks-more/fr/ * Translated using Weblate (German) Currently translated at 91.8% (34 of 37 strings) Translation: Jamulus/Installation-for-Linux Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-linux/de/ * Translated using Weblate (German) Currently translated at 100.0% (31 of 31 strings) Translation: Jamulus/Installation-for-Macintosh Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-macintosh/de/ * Translated using Weblate (Spanish) Currently translated at 100.0% (51 of 51 strings) Translation: Jamulus/Client-Troubleshooting Translate-URL: https://hosted.weblate.org/projects/jamulus/client-troubleshooting/es/ * Translated using Weblate (Spanish) Currently translated at 100.0% (11 of 11 strings) Translation: Jamulus/Command-Line-Options Translate-URL: https://hosted.weblate.org/projects/jamulus/command-line-options/es/ * Translated using Weblate (Spanish) Currently translated at 97.2% (35 of 36 strings) Translation: Jamulus/FAQ Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/es/ * Translated using Weblate (German) Currently translated at 94.9% (132 of 139 strings) Translation: Jamulus/Running-a-Server Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/de/ * Translated using Weblate (Spanish) Currently translated at 94.2% (131 of 139 strings) Translation: Jamulus/Running-a-Server Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/es/ * Translated using Weblate (Spanish) Currently translated at 100.0% (28 of 28 strings) Translation: Jamulus/Server-Troubleshooting Translate-URL: https://hosted.weblate.org/projects/jamulus/server-troubleshooting/es/ * Translated using Weblate (Spanish) Currently translated at 98.5% (133 of 135 strings) Translation: Jamulus/Software-Manual Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/es/ * Translated using Weblate (Spanish) Currently translated at 97.8% (46 of 47 strings) Translation: Jamulus/Tips-Tricks-More Translate-URL: https://hosted.weblate.org/projects/jamulus/tips-tricks-more/es/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 63.1% (24 of 38 strings) Translation: Jamulus/Getting-Started Translate-URL: https://hosted.weblate.org/projects/jamulus/getting-started/pt_BR/ * Translated using Weblate (German) Currently translated at 100.0% (9 of 9 strings) Translation: Jamulus/Include-Backing-Up Translate-URL: https://hosted.weblate.org/projects/jamulus/include-backing-up/de/ * Translated using Weblate (German) Currently translated at 100.0% (20 of 20 strings) Translation: Jamulus/Installation-for-Android Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-android/de/ * Translated using Weblate (German) Currently translated at 91.8% (34 of 37 strings) Translation: Jamulus/Installation-for-Linux Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-linux/de/ * Translated using Weblate (German) Currently translated at 100.0% (31 of 31 strings) Translation: Jamulus/Installation-for-Macintosh Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-macintosh/de/ * Translated using Weblate (German) Currently translated at 98.0% (49 of 50 strings) Translation: Jamulus/Installation-for-Windows Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-windows/de/ * Translated using Weblate (German) Currently translated at 100.0% (27 of 27 strings) Translation: Jamulus/Installation-for-iOS Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/de/ * Translated using Weblate (French) Currently translated at 100.0% (27 of 27 strings) Translation: Jamulus/1-index Translate-URL: https://hosted.weblate.org/projects/jamulus/1-index/fr/ Co-authored-by: Melcon Moraes <melcon@users.noreply.github.com> Co-authored-by: Julien Taverna <jujudusud@users.noreply.github.com> Co-authored-by: Olivier Humbert <trebmuh@users.noreply.github.com> Co-authored-by: ann0see <ann0see@users.noreply.github.com> Co-authored-by: ignotus666 <ignotus666@users.noreply.github.com> * Document changes after r3.9.0 * Document JSON-RPC on privacy site * Privacy: Added disclaimer to only apply on website version * Update wiki/en/Privacy-Statement.md Co-authored-by: Peter L Jones <pljones@users.noreply.github.com> * AUTO: Updated .po files * Translated using Weblate (French) Currently translated at 99.2% (138 of 139 strings) Translated using Weblate (French) Currently translated at 100.0% (10 of 10 strings) Co-authored-by: Olivier Humbert <trebmuh@users.noreply.github.com> Translate-URL: https://hosted.weblate.org/projects/jamulus/contribution/fr/ Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/fr/ Translation: Jamulus/Contribution Translation: Jamulus/Running-a-Server * Translated using Weblate (Spanish) Currently translated at 100.0% (25 of 25 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (27 of 27 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (15 of 15 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (17 of 17 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (135 of 135 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (11 of 11 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (36 of 36 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (17 of 17 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (47 of 47 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (135 of 135 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (139 of 139 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (11 of 11 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (36 of 36 strings) Translated using Weblate (Spanish) Currently translated at 99.2% (138 of 139 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (19 of 19 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (10 of 10 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (27 of 27 strings) Co-authored-by: ignotus666 <ignotus666@users.noreply.github.com> Translate-URL: https://hosted.weblate.org/projects/jamulus/1-index/es/ Translate-URL: https://hosted.weblate.org/projects/jamulus/contribution/es/ Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/es/ Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/es/ Translate-URL: https://hosted.weblate.org/projects/jamulus/general/es/ Translate-URL: https://hosted.weblate.org/projects/jamulus/include-server-commands/es/ Translate-URL: https://hosted.weblate.org/projects/jamulus/include-shared-commands/es/ Translate-URL: https://hosted.weblate.org/projects/jamulus/privacy-statement/es/ Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/es/ Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/es/ Translate-URL: https://hosted.weblate.org/projects/jamulus/tips-tricks-more/es/ Translation: Jamulus/1-index Translation: Jamulus/Contribution Translation: Jamulus/Directories Translation: Jamulus/FAQ Translation: Jamulus/Include-Server-Commands Translation: Jamulus/Include-Shared-Commands Translation: Jamulus/Privacy-Statement Translation: Jamulus/Running-a-Server Translation: Jamulus/Software-Manual Translation: Jamulus/Tips-Tricks-More Translation: Jamulus/general * Translated using Weblate (French) Currently translated at 100.0% (15 of 15 strings) Translated using Weblate (French) Currently translated at 100.0% (28 of 28 strings) Translated using Weblate (French) Currently translated at 100.0% (15 of 15 strings) Co-authored-by: Julien Taverna Translate-URL: https://hosted.weblate.org/projects/jamulus/custom-directories/fr/ Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/fr/ Translate-URL: https://hosted.weblate.org/projects/jamulus/server-troubleshooting/fr/ Translation: Jamulus/Custom-Directories Translation: Jamulus/Directories Translation: Jamulus/Server-Troubleshooting * CLI: Rephrase recording options Fixes: #756 Co-Authored-By: Peter L Jones <pljones@users.noreply.github.com> * AUTO: Updated .po files * Mac: Link universal build This reverts the separate link for ARM releases * AUTO: Updated .po files * Unify headless Linux package and binary Related to: jamulussoftware/jamulus#2821 * Use configured Directory Public IP for Client when hole-punching * AUTO: Updated .po files * Remove references to 'footertext' * Style: Make TOC background darker in darkmode. Fixes: #761 This also moves the css for details into fw.css as the style is side wide and not restricted only to the wiki. * Remove obsolete files * Translations update from Hosted Weblate (#811) * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translation: Jamulus/Directories * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translation: Jamulus/Directories * Update translation files Updated by "Squash Git commits" hook in Weblate. Update French translation using Weblate Currently translated at 100.0% (18 of 18 strings) Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/fr/ Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-macintosh/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-Macintosh * Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-macintosh/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-Macintosh Co-authored-by: ann0see <ann0see@users.noreply.github.com> Co-authored-by: gbonaspetti <gbonaspetti@users.noreply.github.com> Co-authored-by: ignotus666 <ignotus666@users.noreply.github.com> Co-authored-by: trebmuh <trebmuh@users.noreply.github.com> * Remove potentially sensitive E-Mail exposure * Fix string This triggers the .po file creator and should notify weblate * Trigger .po file creation (#823) * AUTO: Updated .po files * --ctrlmidich fix does affect sort by name * Update "serverinfo" * AUTO: Updated .po files * AUTO: Updated .po files * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-macintosh/ Translation: Jamulus/Installation-for-Macintosh * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Jamulus/Directories Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ * AUTO: Updated .po files * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-windows/ Translation: Jamulus/Installation-for-Windows * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Jamulus/Directories Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ * Rephrase meta description (#835) Co-authored-by: jrd <mcfnord> * AUTO: Updated .po files * Remove old reference to setup page Fixes: #821 * AUTO: Updated .po files * Add infobox css class to website * Add infobox to website for midi fix Related to: jamulussoftware/jamulus#2839 * Document arm64 .deb files * Remove separate macOS ARM version * AUTO: Updated .po files * AUTO: Updated .po files * AUTO: Add new language: (ko_KR) #845 * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/ Translation: Jamulus/Software-Manual * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Jamulus/Tips-Tricks-More Translate-URL: https://hosted.weblate.org/projects/jamulus/tips-tricks-more/ * Remove weblate E-Mail again * Fix broken links * AUTO: Updated .po files * Fix another broken link * AUTO: Updated .po files * Update Client-Troubleshooting.md * AUTO: Updated .po files * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/ Translation: Jamulus/FAQ * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/ Translation: Jamulus/FAQ * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/ Translation: Jamulus/FAQ * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/ Translation: Jamulus/FAQ * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/ Translation: Jamulus/FAQ * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Jamulus/Tips-Tricks-More Translate-URL: https://hosted.weblate.org/projects/jamulus/tips-tricks-more/ * Remove email from translator files * Update Spanish translation using Weblate Currently translated at 100.0% (19 of 19 strings) Co-authored-by: ignotus Translate-URL: https://hosted.weblate.org/projects/jamulus/include-server-commands/es/ Translation: Jamulus/Include-Server-Commands * Translations update from Hosted Weblate (#860) * Update Dutch translation using Weblate Currently translated at 100.0% (19 of 19 strings) Update Dutch translation using Weblate Currently translated at 100.0% (19 of 19 strings) Co-authored-by: Henk De Groot <henkdegroot@users.noreply.github.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/jamulus/include-server-commands/nl/ Translation: Jamulus/Include-Server-Commands * Apply suggestions from code review Co-authored-by: ann0see <20726856+ann0see@users.noreply.github.com> * Remove E-Mail * Fix german translation * Update Portuguese (Brazil) translation using Weblate Currently translated at 20.7% (28 of 135 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Melcon Moraes Translate-URL: https://hosted.weblate.org/projects/jamulus/navigation/ Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/pt_BR/ Translation: Jamulus/Navigation Translation: Jamulus/Software-Manual * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Jamulus/Software-Manual Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/ * Remove E-Mail * Update links for release * Fix most important broken link Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan <4561747+gilgongo@users.noreply.github.com> Co-authored-by: Weblate (bot) <hosted@weblate.org> Co-authored-by: Melcon Moraes <melcon@users.noreply.github.com> Co-authored-by: Julien Taverna <jujudusud@users.noreply.github.com> Co-authored-by: Olivier Humbert <trebmuh@users.noreply.github.com> Co-authored-by: ann0see <ann0see@users.noreply.github.com> Co-authored-by: ignotus666 <ignotus666@users.noreply.github.com> Co-authored-by: Peter L Jones <pljones@users.noreply.github.com> Co-authored-by: gbonaspetti <gbonaspetti@users.noreply.github.com> Co-authored-by: John Dempsey <1750243+mcfnord@users.noreply.github.com>

pljones force-pushed the bugfix/#2680-ctrlmidich-ini-fadertags-have-channel branch 4 times, most recently from 6a92d21 to 2efa32b Compare September 5, 2022 21:37

pljones added the bug Something isn't working label Sep 5, 2022

pljones added this to the Release 3.9.1 milestone Sep 5, 2022

pljones self-assigned this Sep 5, 2022

ann0see requested a review from ignotus666 September 6, 2022 08:09

pljones force-pushed the bugfix/#2680-ctrlmidich-ini-fadertags-have-channel branch 3 times, most recently from 0ada6a1 to 38a751d Compare September 7, 2022 11:03

pljones mentioned this pull request Sep 7, 2022

Checkbox controls should be "self-labelling" #2723

Closed

ignotus666 approved these changes Sep 7, 2022

View reviewed changes

pljones force-pushed the bugfix/#2680-ctrlmidich-ini-fadertags-have-channel branch from 38a751d to 3e08216 Compare September 7, 2022 20:48

pljones commented Sep 8, 2022

View reviewed changes

src/settings.cpp Outdated Show resolved Hide resolved

pljones requested review from a team and ann0see September 8, 2022 20:11

hoffie reviewed Sep 9, 2022

View reviewed changes

hoffie changed the title ~~Pass through flag for ctrlmidich used~~ Client: Pass through flag for ctrlmidich used Sep 12, 2022

pljones force-pushed the bugfix/#2680-ctrlmidich-ini-fadertags-have-channel branch from 69b2765 to 7507d26 Compare September 12, 2022 21:36

This was referenced Sep 12, 2022

Prepare Release 3.9.1 #2813

Closed

Remove --cleanuplegacyfadersettings command line option #2850

Closed

ann0see reviewed Sep 13, 2022

View reviewed changes

ann0see approved these changes Sep 13, 2022

View reviewed changes

pljones force-pushed the bugfix/#2680-ctrlmidich-ini-fadertags-have-channel branch 2 times, most recently from edd2585 to be57440 Compare September 14, 2022 16:27

Pass through flag for ctrlmidich used

fd2096b

pljones force-pushed the bugfix/#2680-ctrlmidich-ini-fadertags-have-channel branch from be57440 to fd2096b Compare September 18, 2022 22:29

pljones merged commit 1f9cf89 into jamulussoftware:master Sep 19, 2022

pljones deleted the bugfix/#2680-ctrlmidich-ini-fadertags-have-channel branch September 19, 2022 10:21

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 2, 2022

Add infobox to website for midi fix

6a8750d

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 2, 2022

Add infobox to website for midi fix

789e246

Related to: jamulussoftware/jamulus#2839

ann0see mentioned this pull request Oct 2, 2022

Add infobox for legacy channel fader option jamulussoftware/jamuluswebsite#837

Merged

3 tasks

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 2, 2022

Add infobox to website for midi fix

e5221df

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 2, 2022

Add infobox to website for midi fix

21c5f01

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 2, 2022

Add infobox to website for midi fix

f0a0cb1

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 2, 2022

Add infobox to website for midi fix

f989f24

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 2, 2022

Add infobox to website for midi fix

2a4c45a

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 2, 2022

Add infobox to website for midi fix

9934993

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 6, 2022

Add infobox to website for midi fix

f306d2e

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 6, 2022

Add infobox to website for midi fix

83f9aa0

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 6, 2022

Add infobox to website for midi fix

2798e5b

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 6, 2022

Add infobox to website for midi fix

cece83c

Related to: jamulussoftware/jamulus#2839

ann0see added a commit to ann0see/jamuluswebsite that referenced this pull request Oct 6, 2022

Add infobox to website for midi fix

27655fd

Related to: jamulussoftware/jamulus#2839

pljones mentioned this pull request Jul 29, 2023

#2850 Remove --cleanuplegacyfadersettings command line option #3116

Merged

5 tasks

Client: Pass through flag for ctrlmidich used #2839

Client: Pass through flag for ctrlmidich used #2839

Uh oh!

Conversation

pljones commented Sep 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

ignotus666 commented Sep 6, 2022

Uh oh!

pcar75 commented Sep 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pljones commented Sep 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pcar75 commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pljones commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ignotus666 commented Sep 7, 2022

Uh oh!

pcar75 commented Sep 7, 2022

Uh oh!

pljones commented Sep 8, 2022

Uh oh!

pljones Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pcar75 commented Sep 8, 2022

Uh oh!

ignotus666 commented Sep 8, 2022

Uh oh!

hoffie left a comment

Choose a reason for hiding this comment

Uh oh!

pljones commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pljones commented Sep 12, 2022

Uh oh!

ann0see Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pljones Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

ann0see Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pljones Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ann0see Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

ann0see Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

pljones Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ann0see Sep 14, 2022

Choose a reason for hiding this comment

Uh oh!

pljones Sep 14, 2022

Choose a reason for hiding this comment

Uh oh!

pljones Sep 19, 2022

Choose a reason for hiding this comment

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

pljones commented Sep 5, 2022 •

edited

Loading

pcar75 commented Sep 6, 2022 •

edited

Loading

pljones commented Sep 6, 2022 •

edited

Loading

pcar75 commented Sep 7, 2022 •

edited

Loading

pljones commented Sep 7, 2022 •

edited

Loading

pljones commented Sep 9, 2022 •

edited

Loading

ann0see Sep 13, 2022 •

edited

Loading

ann0see Sep 13, 2022 •

edited

Loading

pljones Sep 13, 2022 •

edited

Loading

pljones Sep 13, 2022 •

edited

Loading