-
Notifications
You must be signed in to change notification settings - Fork 238
Description
Describe the bug
When using the --ctrmidich option, the jamulus.ini file is rewritten with fader tags identified by ChannelNumber:Name which defeats the purpose of conserving fader info since the same user only has a 1/250 (I think) chance of being assigned the same channel number in a future session.
To Reproduce
- Provided a previous Jamulus usage was without this option, the jamulus.ini fader tags are identified with the Base64 hash as
Nameonly. - While Jamulus is not executing , make a backup copy of jamulus.ini file
- Launch the Jamulus client with the --ctrlmidich option (ex.:
--ctrlmidich "1;o2"; will work even if you don't have a midi device) - Connect to a site with participants : notice that if one was muted in previous session, it will not be so now and you will have to mute it again (should apply to any other fader settings)
- For each participant's fader, the diplayed information is now identified with
ChannelNumber:Namealong with instrument and country if provided. - Disconnect and quit Jamulus
- The rewritten Jamulus .ini file will now contain fader tags identified as
ChannelNumber:Name
Note: the Base64 encryption/decryption can be verified with http://www.unit-conversion.info/texttools/base64/
Expected behavior
The usage of fader info in .ini file should always be written and used as identification as Name , not ChannelNumber:Name .
Screenshots
jamulus.ini file when using the --ctrlmidich option.
<storedfadertag5_base64>OTpObyBOYW1l</storedfadertag5_base64>
<storedfaderlevel5>2</storedfaderlevel5>
<storedpanvalue5>50</storedpanvalue5>
<storedfaderissolo5>0</storedfaderissolo5>
<storedfaderismute5>1</storedfaderismute5>
<storedgroupid5>-1</storedgroupid5>
In Base64 "OTpObyBOYW1l" equals "9:No Name" i.e. channel number, ":" and name.
It should stay as "Tm8gTmFtZQ==" equals "No Name" i.e name only
Operating system
This was observed on up-to-date Windows 10.
Version of Jamulus
Jamulus standard 3.8.2 from the Jamulus site.
Additional context
From Discussion/Bug Investigation/Negative impact of --ctrlmidich on jamulus.ini #2678
