Fix for #1451 - unicode in mixer should wrap on character boundaries (take 2) #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Kaistra <admin@djfun.de>
Signed-off-by: Martin Kaistra <admin@djfun.de>
58bbea9 to
a8853b6
Compare
softins
approved these changes
Oct 25, 2021
Member
softins
left a comment
There was a problem hiding this comment.
This appears to fix the issue on my Pi.
Collaborator
Author
|
@jamulussoftware/maindevelopers I can't approve this as I raised the PR. |
Member
|
Currently don’t have time testing/helping out much, but happy to approve. (my studies are challenging – especially dynamic programming is hard 😀). Would it be worth to elect another main-dev (Ignotus,DonC,corrados (?),…)? |
Member
Or maybe dtinth? |
Member
|
Depends on who wants/finds the time and fits the team. I‘d like to see corrados back 😀 but definitely dtinth is another good idea. So the new person would do
Maybe we should move this to a discussion |
This was referenced Jan 20, 2022
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Jan 25, 2022
If the 16th char of the user-selected alias was a multi-byte unicode char, it would be incorrectly split in half, rendering it invalid. This commit makes the truncation unicode-aware. The fix was initially developed in ce370e9. It got lost during PR merge in commit a8853b6, most likely during conflict resolution due to code reorganizations in d94fd69. This commit re-applies the fix to new new place (CClientSettingsDlg::OnAliasTextChanged instead of the no longer existing CMusProfDlg::OnAliasTextChanged). It also moves the related inline function to the header to make it possible to include in the first place. Fixes jamulussoftware#1994 (for real). Fixes jamulussoftware#2274. Co-authored-by: Martin Kaistra <admin@djfun.de>
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Jan 25, 2022
If the 16th char of the user-selected alias was a multi-byte unicode char, it would be incorrectly split in half, rendering it invalid. This commit makes the truncation unicode-aware. The fix was initially developed in ce370e9. It got lost during PR merge in commit a8853b6, most likely during conflict resolution due to code reorganizations in d94fd69. This commit re-applies the fix to the new place (CClientSettingsDlg::OnAliasTextChanged instead of the no longer existing CMusProfDlg::OnAliasTextChanged). It also moves the related inline function to the header to make it possible to include in the first place. Fixes jamulussoftware#1994 (for real). Fixes jamulussoftware#2274. Co-authored-by: Martin Kaistra <admin@djfun.de>
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Jan 25, 2022
If the 16th char of the user-selected alias was a multi-byte unicode char, it would be incorrectly split in half, rendering it invalid. This commit makes the truncation unicode-aware. The fix was initially developed in ce370e9. It got lost during PR merge in commit a8853b6, most likely during conflict resolution due to code reorganizations in d94fd69. This commit re-applies the fix to the new place (CClientSettingsDlg::OnAliasTextChanged instead of the no longer existing CMusProfDlg::OnAliasTextChanged). It also moves the related inline function to the header to make it possible to include in the first place. Fixes jamulussoftware#1994 (for real). Fixes jamulussoftware#2274. Co-authored-by: Martin Kaistra <admin@djfun.de>
5 tasks
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Jan 25, 2022
If the 16th char of the user-selected alias was a multi-byte unicode char, it would be incorrectly split in half, rendering it invalid. This commit makes the truncation unicode-aware. The fix was initially developed in ce370e9. It got lost during PR merge in commit a8853b6, most likely during conflict resolution due to code reorganizations in d94fd69. This commit re-applies the fix to the new place (CClientSettingsDlg::OnAliasTextChanged instead of the no longer existing CMusProfDlg::OnAliasTextChanged). It also moves the related function to the header to make inclusion by other files possible in the first place. This also required dropping the `static` and `inline` keywords. Fixes jamulussoftware#1994 (for real). Fixes jamulussoftware#2274. Co-authored-by: Martin Kaistra <admin@djfun.de>
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Jan 25, 2022
If the 16th char of the user-selected alias was a multi-byte unicode char, it would be incorrectly split in half, rendering it invalid. This commit makes the truncation unicode-aware. The fix was initially developed in ce370e9. It got lost during PR merge in commit a8853b6, most likely during conflict resolution due to code reorganizations in d94fd69. This commit re-applies the fix to the new place (CClientSettingsDlg::OnAliasTextChanged instead of the no longer existing CMusProfDlg::OnAliasTextChanged). It also adds a function declaration to the header to make inclusion by other files possible in the first place. This also required dropping the `static` and `inline` keywords. Fixes jamulussoftware#1994 (for real). Fixes jamulussoftware#2274. Co-authored-by: Martin Kaistra <admin@djfun.de>
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Jan 25, 2022
If the 16th char of the user-selected alias was a multi-byte unicode char, it would be incorrectly split in half, rendering it invalid. This commit makes the truncation unicode-aware. The fix was initially developed in ce370e9. It got lost during PR merge in commit a8853b6, most likely during conflict resolution due to code reorganizations in d94fd69. This commit re-applies the fix to the new place (CClientSettingsDlg::OnAliasTextChanged instead of the no longer existing CMusProfDlg::OnAliasTextChanged). It also adds a function declaration to the header to make inclusion by other files possible in the first place. This also required dropping the `static` and `inline` keywords. Fixes jamulussoftware#1994 (for real). Fixes jamulussoftware#2274. Co-authored-by: Martin Kaistra <admin@djfun.de>
5 tasks
13 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
@djfun wrote a fix but didn't raise a PR, so here's the PR.
Context: Fixes an issue?
Yes. #1451. This still happens.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Needs testing.
What is missing until this pull request can be merged?
Needs testing.
Checklist
I've now created a branch off jamulussoftware/jamulus master and merged @djfun's changes to that, then fixed the conflicts.
I'll try it out now.