Use managed npm cache for node hooks by j178 · Pull Request #2075 · j178/prek

j178 · 2026-05-12T09:52:38Z

No description provided.

codecov · 2026-05-12T09:56:17Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.33%. Comparing base (7783bdc) to head (5fddf3d).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2075      +/-   ##
==========================================
- Coverage   92.33%   92.33%   -0.01%     
==========================================
  Files         119      119              
  Lines       24432    24436       +4     
==========================================
+ Hits        22559    22562       +3     
- Misses       1873     1874       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR introduces a dedicated, managed npm cache under $PREK_HOME/cache for language: node hooks so npm’s download/cache state is isolated from user/global environments and can be managed by prek’s cache GC.

Changes:

Add a new CacheBucket::Npm store bucket.
Set npm_config_cache for node hook install/run processes to use the managed store cache path, while clearing inherited npm cache/prefix env vars.
Register Node’s cache bucket usage so cache GC retains/removes the npm cache appropriately.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/prek/src/store.rs	Adds `CacheBucket::Npm` to represent the managed npm cache location under the store.
crates/prek/src/languages/node/node.rs	Forces `npm_config_cache` to the managed cache path and removes inherited npm cache/prefix env vars for install/run.
crates/prek/src/languages/mod.rs	Declares that `Language::Node` uses the `Npm` cache bucket so GC can manage it.

prek-ci-bot · 2026-05-12T10:01:27Z

📦 Cargo Bloat Comparison

Binary size change: +0.00% (26.1 MiB → 26.1 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_1_aes_gcm_encrypt_avx512
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_1_aes_gcm_decrypt_avx512
 0.3%   0.7%  91.9KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  83.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.2%   0.5%  65.5KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  60.3KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  53.3KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  48.8KiB              prek prek::run::{{closure}}
 0.2%   0.3%  43.4KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.5KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  32.1KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  28.4KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_1_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.6KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_1_edwards25519_scalarmuldouble
 0.1%   0.2%  26.4KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  24.5KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  23.5KiB             prek? <prek::cli::Command as clap_builder::derive::FromArgMatches>::from_arg_matches_mut
 0.1%   0.2%  22.5KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
41.6%  86.3%  10.9MiB                   And 23905 smaller methods. Use -n N to show more.
48.1% 100.0%  12.6MiB                   .text section size, the file size is 26.1MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_1_aes_gcm_encrypt_avx512
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_1_aes_gcm_decrypt_avx512
 0.3%   0.7%  91.5KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  86.1KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  74.5KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  65.4KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  53.3KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  48.7KiB              prek prek::run::{{closure}}
 0.2%   0.3%  43.8KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  33.1KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  32.1KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  29.0KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_1_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.6KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_1_edwards25519_scalarmuldouble
 0.1%   0.2%  26.2KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  23.9KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.5KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.5KiB      clap_builder clap_builder::parser::parser::Parser::get_matches_with
41.5%  86.2%  10.8MiB                   And 23921 smaller methods. Use -n N to show more.
48.1% 100.0%  12.6MiB                   .text section size, the file size is 26.1MiB

prek-ci-bot · 2026-05-12T10:01:28Z

⚡️ Hyperfine Benchmarks

Summary: 5 regressions, 3 improvements above the 10% threshold.

Environment

OS: Linux 6.17.0-1010-azure
CPU: 4 cores
prek version: prek 0.3.13+17 (ab4442f 2026-05-12)
Rust version: rustc 1.95.0 (59807616e 2026-04-14)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.0 ± 0.1	1.8	2.5	1.03 ± 0.06
`prek-head --version`	1.9 ± 0.1	1.8	2.3	1.00

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	7.7 ± 1.2	7.1	18.0	1.00
`prek-head list`	8.0 ± 2.3	7.2	25.3	1.04 ± 0.34

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	3.1 ± 3.2	2.5	25.0	1.10 ± 1.18
`prek-head validate-config .pre-commit-config.yaml`	2.8 ± 0.9	2.6	9.2	1.00

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.7 ± 3.5	2.1	27.2	1.00
`prek-head sample-config`	3.1 ± 6.4	2.1	47.3	1.16 ± 2.81

⚠️ Warning: Performance regression for prek sample-config: 16.1700% slower

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	118.1 ± 4.8	110.8	124.9	1.02 ± 0.05
`prek-head run --all-files`	115.6 ± 3.7	109.4	119.5	1.00

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	114.0 ± 2.7	107.8	117.1	1.00
`prek-head run --all-files`	115.3 ± 3.0	110.2	120.1	1.01 ± 0.04

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	115.8 ± 4.9	107.9	136.1	1.01 ± 0.06
`prek-head run --all-files`	114.5 ± 4.4	108.1	130.2	1.00

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	17.3 ± 0.7	16.4	19.7	1.00
`prek-head run trailing-whitespace --all-files`	17.5 ± 3.5	16.2	35.7	1.01 ± 0.20

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	69.3 ± 116.7	19.6	405.1	2.62 ± 4.55
`prek-head run end-of-file-fixer --all-files`	26.5 ± 11.6	20.2	70.4	1.00

✅ Performance improvement for prek run end-of-file-fixer --all-files: 61.7700% faster

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	12.5 ± 10.6	9.8	67.9	1.00
`prek-head run check-json --all-files`	20.9 ± 36.3	9.6	174.0	1.67 ± 3.23

⚠️ Warning: Performance regression for prek run check-json --all-files: 67.1400% slower

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	9.8 ± 0.3	9.4	10.4	1.00
`prek-head run check-yaml --all-files`	10.2 ± 2.1	9.1	21.2	1.03 ± 0.22

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	10.4 ± 2.4	9.4	22.5	1.00
`prek-head run check-toml --all-files`	19.1 ± 33.2	9.0	160.0	1.84 ± 3.23

⚠️ Warning: Performance regression for prek run check-toml --all-files: 84.1100% slower

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	9.9 ± 0.3	9.3	10.8	1.00
`prek-head run check-xml --all-files`	10.5 ± 3.8	9.2	30.7	1.06 ± 0.39

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	22.8 ± 23.8	12.3	110.2	1.11 ± 1.85
`prek-head run detect-private-key --all-files`	20.5 ± 26.7	12.8	161.2	1.00

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	19.2 ± 2.6	16.2	27.5	1.00 ± 0.20
`prek-head run fix-byte-order-marker --all-files`	19.2 ± 2.8	16.8	30.3	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	3.9 ± 0.0	3.8	4.0	1.01 ± 0.01
`prek-head install-hooks`	3.9 ± 0.0	3.9	3.9	1.00

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.0 ± 0.1	4.0	4.1	1.00
`prek-head install-hooks`	4.1 ± 0.1	4.0	4.2	1.03 ± 0.03

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	49.6 ± 28.1	39.4	139.6	1.00
`prek-head run`	52.4 ± 37.4	38.9	168.8	1.06 ± 0.96

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	21.3 ± 50.5	7.0	228.2	1.08 ± 3.15
`prek-head run --files '*.json'`	19.7 ± 33.5	7.0	131.6	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	10.4 ± 4.9	8.8	30.4	1.00
`prek-head run --dry-run --all-files`	15.7 ± 16.3	8.6	59.8	1.51 ± 1.73

⚠️ Warning: Performance regression for prek run --dry-run --all-files (measures init overhead): 51.4300% slower

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	17.9 ± 21.5	10.8	94.6	1.62 ± 1.95
`prek-head run check-hooks-apply --all-files`	11.1 ± 0.2	10.7	11.5	1.00

✅ Performance improvement for prek run check-hooks-apply --all-files: 38.1200% faster

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	13.9 ± 15.8	9.4	70.9	1.00
`prek-head run check-useless-excludes --all-files`	24.1 ± 37.6	9.5	142.4	1.74 ± 3.35

⚠️ Warning: Performance regression for prek run check-useless-excludes --all-files: 73.9500% slower

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	16.6 ± 29.0	8.8	121.5	1.80 ± 3.17
`prek-head run identity --all-files`	9.2 ± 2.3	8.5	17.4	1.00

✅ Performance improvement for prek run identity --all-files: 44.3400% faster

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [prek](https://github.com/j178/prek) | minor | `0.3.13` → `0.4.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>j178/prek (prek)</summary> ### [`v0.4.0`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#040) [Compare Source](j178/prek@v0.3.13...v0.4.0) Released on 2026-05-14. ##### Breaking changes These are narrow cleanup breaks in behavior that was either temporary or never worked correctly. Most users should not need to change anything. - Generated hook scripts no longer preserve `-q`, `-v`, or `--no-progress` passed to `prek install`. This only affects users who expected those global flags to be baked into installed hooks. ([#1966](j178/prek#1966)) - `language_version` no longer accepts direct executable paths. Use `language_version: system` for a system toolchain, or use a supported version request instead. This path form did not work reliably before, so existing working configs should be unaffected. ([#1831](j178/prek#1831)) ##### Enhancements - Expand tilde in `--config`, `--cd`, `--log-file` and `--git-dir` ([#2063](j178/prek#2063)) - Prevent auto-update cooldown downgrades ([#2055](j178/prek#2055)) - Use managed npm cache for node hooks ([#2075](j178/prek#2075)) ##### Bug fixes - Fix npm config env overrides for node hooks ([#2074](j178/prek#2074)) ##### Documentation - Add cookbook page for enabling Git 2.54 config-based global hooks ([#2061](j178/prek#2061)) ##### Contributors - [@j178](https://github.com/j178) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).

Copilot AI review requested due to automatic review settings May 12, 2026 09:52

j178 added the enhancement New feature or request label May 12, 2026

Use managed npm cache for node hooks

5fddf3d

Copilot started reviewing on behalf of j178 May 12, 2026 09:53 View session

j178 force-pushed the npm-cache branch from 0897d2f to 5fddf3d Compare May 12, 2026 09:54

Copilot AI reviewed May 12, 2026

View reviewed changes

Comment thread crates/prek/src/languages/node/node.rs

j178 merged commit 99ac4fb into master May 12, 2026
34 checks passed

j178 deleted the npm-cache branch May 12, 2026 10:58

BrewTestBot mentioned this pull request May 14, 2026

prek 0.4.0 Homebrew/homebrew-core#282772

Merged

Uh oh!

Conversation

j178 commented May 12, 2026

Uh oh!

codecov Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

prek-ci-bot Bot commented May 12, 2026

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot Bot commented May 12, 2026

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented May 12, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`