Remove direct path support from language_version by j178 · Pull Request #1831 · j178/prek

j178 · 2026-03-19T10:31:26Z

Summary

Remove direct path handling from language_version request parsing across languages

Notes

This path support never actually worked, so this likely should not be considered a breaking change.

Copilot

Pull request overview

This PR removes (non-working) support for specifying direct executable paths in language_version requests, simplifying request parsing and version matching across supported language installers.

Changes:

Dropped path-based parsing/variants from Bun/Go/Node/Python/Ruby language_version request types and updated matching APIs accordingly.
Simplified installer matching by removing the unused “toolchain path” parameter from matches(...).
Updated docs to stop advertising absolute-path language_version values.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
docs/languages.md	Removes documentation implying `language_version` can be an absolute executable path.
docs/configuration.md	Updates `language_version` docs to avoid advertising interpreter-name/path behavior that no longer applies.
crates/prek/src/languages/rust/version.rs	Simplifies `RustRequest::matches` signature and updates call sites/tests.
crates/prek/src/languages/rust/installer.rs	Updates matching calls to new `matches(...)` signature.
crates/prek/src/languages/ruby/version.rs	Removes path request variant and updates parsing/matching/tests.
crates/prek/src/languages/ruby/installer.rs	Updates matching calls to new `matches(...)` signature.
crates/prek/src/languages/python/version.rs	Removes path request variant and updates parsing/matching/tests.
crates/prek/src/languages/python/python.rs	Removes UV request conversion support for removed `Path` request variant.
crates/prek/src/languages/node/version.rs	Removes path request variant and updates parsing/matching/tests.
crates/prek/src/languages/node/installer.rs	Updates matching calls to new `matches(...)` signature.
crates/prek/src/languages/golang/version.rs	Removes path request variant and updates parsing/matching/tests.
crates/prek/src/languages/golang/installer.rs	Updates matching calls to new `matches(...)` signature.
crates/prek/src/languages/bun/version.rs	Removes path request variant and updates parsing/matching/tests.
crates/prek/src/languages/bun/installer.rs	Updates matching calls to new `matches(...)` signature.

codecov · 2026-03-19T10:34:56Z

Codecov Report

❌ Patch coverage is 97.01493% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.82%. Comparing base (c09510e) to head (37faf13).
⚠️ Report is 21 commits behind head on v04.

Files with missing lines	Patch %	Lines
crates/prek/src/languages/node/installer.rs	66.66%	1 Missing ⚠️
crates/prek/src/languages/rust/installer.rs	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              v04    #1831      +/-   ##
==========================================
+ Coverage   91.79%   91.82%   +0.02%     
==========================================
  Files          98       98              
  Lines       20119    20059      -60     
==========================================
- Hits        18469    18419      -50     
+ Misses       1650     1640      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

prek-ci-bot · 2026-03-19T10:37:54Z

📦 Cargo Bloat Comparison

Binary size change: +0.00% (24.8 MiB → 24.8 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  77.5KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  69.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  69.1KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  50.6KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  46.9KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.9KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.0KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble
 0.1%   0.2%  25.8KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  25.3KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  23.2KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  22.0KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  21.6KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.1%  86.0%  10.2MiB                   And 23384 smaller methods. Use -n N to show more.
47.8% 100.0%  11.9MiB                   .text section size, the file size is 24.8MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  77.0KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  72.6KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.6%  69.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  50.6KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  47.1KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.9KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.0KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.2KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  25.3KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  23.1KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  22.0KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  21.6KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.2%  86.0%  10.2MiB                   And 23349 smaller methods. Use -n N to show more.
47.9% 100.0%  11.9MiB                   .text section size, the file size is 24.8MiB

prek-ci-bot · 2026-03-19T10:37:54Z

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.14.0-1017-azure
CPU: 4 cores
prek version: prek 0.3.6+19 (1cd973a 2026-03-19)
Rust version: rustc 1.94.0 (4a4ef493e 2026-03-02)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	1.8 ± 0.1	1.6	2.3	1.00
`prek-head --version`	1.8 ± 0.1	1.6	2.3	1.01 ± 0.09

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	7.4 ± 0.1	7.1	7.8	1.00 ± 0.02
`prek-head list`	7.4 ± 0.1	7.1	7.8	1.00

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	2.5 ± 0.1	2.4	2.8	1.00
`prek-head validate-config .pre-commit-config.yaml`	2.5 ± 0.1	2.4	2.6	1.01 ± 0.04

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.0 ± 0.0	1.9	2.1	1.00
`prek-head sample-config`	2.0 ± 0.0	1.9	2.1	1.00 ± 0.03

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	98.7 ± 0.9	97.1	100.1	1.00
`prek-head run --all-files`	99.5 ± 1.7	97.7	102.5	1.01 ± 0.02

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	99.5 ± 1.8	96.7	102.6	1.00 ± 0.02
`prek-head run --all-files`	99.2 ± 1.2	97.3	101.1	1.00

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	100.2 ± 2.6	96.1	110.1	1.00
`prek-head run --all-files`	100.3 ± 2.6	96.2	112.6	1.00 ± 0.04

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	14.4 ± 0.2	14.1	14.8	1.00
`prek-head run trailing-whitespace --all-files`	14.5 ± 0.3	14.0	15.3	1.01 ± 0.02

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	19.4 ± 0.8	17.8	21.9	1.00 ± 0.07
`prek-head run end-of-file-fixer --all-files`	19.3 ± 1.1	17.3	21.8	1.00

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	8.9 ± 0.2	8.6	9.2	1.03 ± 0.04
`prek-head run check-json --all-files`	8.7 ± 0.2	8.3	9.3	1.00

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	8.5 ± 0.1	8.2	8.8	1.00
`prek-head run check-yaml --all-files`	8.8 ± 0.3	8.4	9.4	1.04 ± 0.04

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	8.6 ± 0.2	8.3	9.3	1.01 ± 0.03
`prek-head run check-toml --all-files`	8.5 ± 0.2	8.1	9.0	1.00

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	8.5 ± 0.2	8.1	9.1	1.01 ± 0.04
`prek-head run check-xml --all-files`	8.5 ± 0.3	8.1	9.2	1.00

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	13.9 ± 2.0	12.0	20.0	1.05 ± 0.16
`prek-head run detect-private-key --all-files`	13.2 ± 0.7	12.2	15.1	1.00

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	25.6 ± 22.7	15.1	105.4	1.53 ± 1.36
`prek-head run fix-byte-order-marker --all-files`	16.7 ± 0.8	15.3	17.9	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	3.8 ± 0.1	3.6	4.0	1.00 ± 0.04
`prek-head install-hooks`	3.8 ± 0.0	3.7	3.8	1.00

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	3.7 ± 0.0	3.7	3.8	1.00
`prek-head install-hooks`	3.8 ± 0.1	3.7	3.9	1.01 ± 0.03

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	35.8 ± 0.7	34.8	37.1	1.00
`prek-head run`	35.9 ± 0.8	34.7	37.7	1.00 ± 0.03

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	6.3 ± 0.1	6.2	6.4	1.00
`prek-head run --files '*.json'`	6.5 ± 0.3	6.2	7.3	1.02 ± 0.04

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	9.6 ± 0.2	9.3	10.0	1.00
`prek-head run --dry-run --all-files`	9.8 ± 0.3	9.4	10.9	1.03 ± 0.04

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	9.8 ± 0.2	9.5	10.4	1.04 ± 0.05
`prek-head run check-hooks-apply --all-files`	9.4 ± 0.4	8.9	10.0	1.00

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	9.1 ± 0.1	9.0	9.4	1.01 ± 0.02
`prek-head run check-useless-excludes --all-files`	9.0 ± 0.1	8.8	9.2	1.00

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	7.9 ± 0.5	7.5	9.3	1.01 ± 0.06
`prek-head run identity --all-files`	7.8 ± 0.1	7.6	8.0	1.00

## Summary Closes #1581 Remove direct path handling from `language_version` request parsing across languages ## Notes This path support never actually worked, so this likely should not be considered a breaking change.

Closes #1581 Remove direct path handling from `language_version` request parsing across languages This path support never actually worked, so this likely should not be considered a breaking change.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [prek](https://github.com/j178/prek) | minor | `0.3.13` → `0.4.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>j178/prek (prek)</summary> ### [`v0.4.0`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#040) [Compare Source](j178/prek@v0.3.13...v0.4.0) Released on 2026-05-14. ##### Breaking changes These are narrow cleanup breaks in behavior that was either temporary or never worked correctly. Most users should not need to change anything. - Generated hook scripts no longer preserve `-q`, `-v`, or `--no-progress` passed to `prek install`. This only affects users who expected those global flags to be baked into installed hooks. ([#1966](j178/prek#1966)) - `language_version` no longer accepts direct executable paths. Use `language_version: system` for a system toolchain, or use a supported version request instead. This path form did not work reliably before, so existing working configs should be unaffected. ([#1831](j178/prek#1831)) ##### Enhancements - Expand tilde in `--config`, `--cd`, `--log-file` and `--git-dir` ([#2063](j178/prek#2063)) - Prevent auto-update cooldown downgrades ([#2055](j178/prek#2055)) - Use managed npm cache for node hooks ([#2075](j178/prek#2075)) ##### Bug fixes - Fix npm config env overrides for node hooks ([#2074](j178/prek#2074)) ##### Documentation - Add cookbook page for enabling Git 2.54 config-based global hooks ([#2061](j178/prek#2061)) ##### Contributors - [@j178](https://github.com/j178) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).

Remove direct path support from language_version

1171e04

Copilot AI review requested due to automatic review settings March 19, 2026 10:31

j178 added the enhancement New feature or request label Mar 19, 2026

Copilot AI reviewed Mar 19, 2026

View reviewed changes

Comment thread crates/prek/src/languages/python/version.rs Outdated

Comment thread crates/prek/src/languages/python/version.rs

Comment thread crates/prek/src/languages/ruby/version.rs Outdated

Update Ruby tests for removed path support

37faf13

j178 changed the base branch from master to v04 March 25, 2026 06:27

j178 added the breaking Breaking changes label Mar 25, 2026

j178 merged commit 33e59be into v04 Mar 25, 2026
50 checks passed

j178 deleted the remove-path branch March 25, 2026 06:28

BrewTestBot mentioned this pull request May 14, 2026

prek 0.4.0 Homebrew/homebrew-core#282772

Merged

Uh oh!

Conversation

j178 commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

prek-ci-bot Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

j178 commented Mar 19, 2026 •

edited

Loading

codecov Bot commented Mar 19, 2026 •

edited

Loading

prek-ci-bot Bot commented Mar 19, 2026 •

edited

Loading

prek-ci-bot Bot commented Mar 19, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`