Support Android npm launcher#1979
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1979 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 116 116
Lines 23338 23338
=======================================
Hits 21525 21525
Misses 1813 1813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Android/Termux support to the npm distribution by introducing an Android arm64 platform package that reuses the existing static aarch64-unknown-linux-musl release artifact, enabling the wrapper launcher to resolve a compatible binary when process.platform === "android".
Changes:
- Add a new
PlatformSpecentry for@j178/prek-android-arm64. - Reuse the
prek-aarch64-unknown-linux-musl.tar.gzarchive for Android/arm64 packaging. - Ensure the wrapper’s generated
platforms.jsonandoptionalDependenciesinclude the new Android package.
This was referenced Apr 29, 2026
gtbuchanan
added a commit
to gtbuchanan/tooling
that referenced
this pull request
Apr 30, 2026
0.3.11 ships j178/prek#1979 + j178/prek#1982 — Android/Termux launcher support. The pre-commit fallback existed only because prek's binary couldn't load on Bionic; with the launcher fix it does. A separate uv-on-Bionic quirk remains: prek's bundled uv aborts during managed-Python discovery because libc detection fails on Bionic. Termux contributors should set `UV_LIBC=none` so uv falls back to system Python. Documented in the root README's new "Termux/Android setup" section. Closes #51. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the existing
@j178/prek-linux-arm64-muslpackage to cover Android/Termux, and omit package-levellibcmetadata for that shared package so npm can install it before the launcher selects the static musl binary.Closes #1977