Skip to content

Bump prek to ^0.3.11 and drop pre-commit fallback#82

Merged
gtbuchanan merged 1 commit into
mainfrom
fix-issue-51
Apr 30, 2026
Merged

Bump prek to ^0.3.11 and drop pre-commit fallback#82
gtbuchanan merged 1 commit into
mainfrom
fix-issue-51

Conversation

@gtbuchanan

@gtbuchanan gtbuchanan commented Apr 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Bumps @j178/prek catalog to ^0.3.11, which ships j178/prek#1979 + j178/prek#1982 (Android/Termux launcher support).
  • Removes the pre-commit Python fallback from gtb prepare. It existed only because prek's binary couldn't load on Bionic; with the launcher fix it does.
  • Adds a new "Termux/Android setup" section in the root README that consolidates the existing turbo-unavailable callout with a new note about UV_LIBC=none. The UV_LIBC workaround handles a separate uv-on-Bionic quirk: prek's bundled uv aborts during managed-Python discovery because Bionic isn't recognized as glibc or musl, so uv needs to be told to fall back to system Python. j178 confirmed in #51 that the fall-through is plausibly a uv bug, not a prek one — filing upstream is optional given the workaround.

Closes #51.

Test plan

  • pnpm -C packages/cli typecheck:ts
  • pnpm -C packages/cli lint:eslint
  • pnpm -C packages/cli test:vitest:fast — 194/194, including the 4 prepare.test.ts cases
  • Root pnpm lint:eslint (covers root README + workspace files)
  • pnpm exec prek install-hooks on Termux with UV_LIBC=none — succeeds end-to-end (Python venvs created, hooks installed)
  • pnpm exec prek run check-added-large-files on Termux with UV_LIBC=none — Python hook executes and passes
  • Full pnpm build on a non-Termux runner — Termux OOMs the full turbo pipeline, so the heavy build/slow/e2e tiers need to be validated by CI

Notes

  • The cross-spawn import was removed from prepare.ts since the only call site (the unset of core.hooksPath before pre-commit fallback) is gone. cross-spawn stays in the cli package — still used by pack-npm.ts and lib/process.ts.

🤖 Generated with Claude Code

0.3.11 ships j178/prek#1979 + j178/prek#1982 — Android/Termux launcher
support. The pre-commit fallback existed only because prek's binary
couldn't load on Bionic; with the launcher fix it does.

A separate uv-on-Bionic quirk remains: prek's bundled uv aborts
during managed-Python discovery because libc detection fails on
Bionic. Termux contributors should set `UV_LIBC=none` so uv falls
back to system Python. Documented in the root README's new
"Termux/Android setup" section.

Closes #51.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@gtbuchanan gtbuchanan merged commit 23489ab into main Apr 30, 2026
7 of 8 checks passed
@gtbuchanan gtbuchanan deleted the fix-issue-51 branch April 30, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove pre-commit fallback after prek Android fix

1 participant