Bump prek to ^0.3.11 and drop pre-commit fallback#82
Merged
Conversation
0.3.11 ships j178/prek#1979 + j178/prek#1982 — Android/Termux launcher support. The pre-commit fallback existed only because prek's binary couldn't load on Bionic; with the launcher fix it does. A separate uv-on-Bionic quirk remains: prek's bundled uv aborts during managed-Python discovery because libc detection fails on Bionic. Termux contributors should set `UV_LIBC=none` so uv falls back to system Python. Documented in the root README's new "Termux/Android setup" section. Closes #51. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@j178/prekcatalog to^0.3.11, which ships j178/prek#1979 + j178/prek#1982 (Android/Termux launcher support).gtb prepare. It existed only because prek's binary couldn't load on Bionic; with the launcher fix it does.UV_LIBC=none. TheUV_LIBCworkaround handles a separate uv-on-Bionic quirk: prek's bundleduvaborts during managed-Python discovery because Bionic isn't recognized as glibc or musl, souvneeds to be told to fall back to system Python. j178 confirmed in #51 that the fall-through is plausibly a uv bug, not a prek one — filing upstream is optional given the workaround.Closes #51.
Test plan
pnpm -C packages/cli typecheck:tspnpm -C packages/cli lint:eslintpnpm -C packages/cli test:vitest:fast— 194/194, including the 4prepare.test.tscasespnpm lint:eslint(covers root README + workspace files)pnpm exec prek install-hookson Termux withUV_LIBC=none— succeeds end-to-end (Python venvs created, hooks installed)pnpm exec prek run check-added-large-fileson Termux withUV_LIBC=none— Python hook executes and passespnpm buildon a non-Termux runner — Termux OOMs the full turbo pipeline, so the heavy build/slow/e2e tiers need to be validated by CINotes
cross-spawnimport was removed fromprepare.tssince the only call site (the unset ofcore.hooksPathbefore pre-commit fallback) is gone.cross-spawnstays in the cli package — still used bypack-npm.tsandlib/process.ts.🤖 Generated with Claude Code