Upgrade prow base OS to ubuntu bionic#505
Merged
istio-testing merged 2 commits intoistio:masterfrom Nov 4, 2019
Merged
Conversation
This is needed to unblock istio/istio#18577
jwendell
approved these changes
Nov 4, 2019
sdake
reviewed
Nov 4, 2019
docker/build-tools/Dockerfile
Outdated
| RUN apt-key add /tmp/docker-key | ||
| RUN add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu xenial stable" | ||
| RUN add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu bionic stable" | ||
| # RUN apt search docker-ce docker-ce-cli containerd.io |
Member
There was a problem hiding this comment.
Might add a little context for this RUN line so people don't think its stray debug.
Contributor
Author
There was a problem hiding this comment.
Probably should just remove it. I'm not sure adding it really helps.
sdake
approved these changes
Nov 4, 2019
Member
sdake
left a comment
There was a problem hiding this comment.
this looks good although it should be tested manually first as a distro change is a pretty significant change.
1.5 is probably the time to move off of xenial.
Cheers
-steve
Member
|
Our base image (even for 1.4) is bionic. So, I think it's good to keep them synced. It should be done earlier though... |
Shuanglu
pushed a commit
to Shuanglu/istio-tools
that referenced
this pull request
Jun 30, 2022
* Upgrade prow base OS to ubuntu bionic This is needed to unblock istio/istio#18577 * removing commented command.
Shuanglu
pushed a commit
to Shuanglu/istio-tools
that referenced
this pull request
Jul 6, 2022
* Upgrade prow base OS to ubuntu bionic This is needed to unblock istio/istio#18577 * removing commented command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to unblock istio/istio#18577