Various fixes for istio.io Ingress SDS test#18577
Conversation
ba8cb26 to
b4d3135
Compare
|
@howardjohn Is it possible to upgrade the version of curl we're using on the prow containers? The ingress SDS test is failing because I'm using the curl arg |
|
I would think so, it's in the tools repo under docker/build-tools.
hopefully as simple as changing a version number somewhere
Is that version of curl really new though, or can we assume users will have
it?
…On Sat, Nov 2, 2019, 4:43 PM Nathan Mittler ***@***.***> wrote:
@howardjohn <https://github.com/howardjohn> Is it possible to upgrade the
version of curl we're using on the prow containers? The ingress SDS test is
failing because I'm using the curl arg --retry-connrefused, which
requires curl 7.52.0 or later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18577?email_source=notifications&email_token=AAEYGXOSI45AOSPS4EU63B3QRYGBLA5CNFSM4JIHL4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5HNIQ#issuecomment-549090978>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXM5MONRUQLWCPEI3S3QRYGBLANCNFSM4JIHL4GQ>
.
|
Looks like the latest curl version is This is only required for running one specific test for istio.io. I'm not sure how concerned we have to be about this. Looks like the latest package available for xenial is 7.47.0, which seems to be what is installed on the container, judging by my logs I guess we have two options:
How important is the base image for prow? Can we change it? If not, is there any concern with building curl ourselves? |
This is needed to unblock istio/istio#18577
This is needed to unblock istio/istio#18577
* Upgrade prow base OS to ubuntu bionic This is needed to unblock istio/istio#18577 * removing commented command.
tests/integration/istioio/README.md
Outdated
There was a problem hiding this comment.
I think it makes sense to continue describing the configuration options here. The docs format/bash shell commands pattern that we're following for test writing doesn't assume a lot of Go knowledge. I'm not sure that we want to tell writers to read the source to figure out how to write tests.
There was a problem hiding this comment.
I'm a little torn on this. I would say that the docs must exist here in the source code for certain. The question is whether or not we duplicate some/all of this in the MD file. My concern is that this class is a bit in flux and it's going to be painful to keep this and the MD file in sync. If we're asking the docs team to write code anyway, I would think that reading comments on the library they're using would not be an incredibly high bar.
@geeknoid thoughts?
There was a problem hiding this comment.
Tests are written developers, it's fine to assume access to the source code and knowledge of Go.
This unblocks istio/istio#18577
This unblocks istio/istio#18577
Includes a new image for prow based on ubuntu bionic. Needed by istio#18577
|
/retest |
|
/test integ-istioio-k8s-tests_istio |
|
The error due to the fact that this command returns nothing in kind: export INGRESS_HOST=$(kubectl -n istio-system \
get service istio-ingressgateway -o jsonpath='{.status.loadBalancer.ingress[0].ip}')At the point this is called, we've deployed the istio ingress gateway. Do you know if ingresses behave differently in kind? Perhaps I need to add a wait before getting this field? |
8ded058 to
e0cfca9
Compare
|
there is no load balancer IP in kind, like with minikube. In the test framework we have some option like --istio.test.minikube (poorly named) that makes this work by not looking for the external IP and instead looks for a different IP (not exactly sure which one) |
49f8a2d to
ccbde29
Compare
|
@geeknoid @brian-avery PTAL |
|
/test pilot-e2e-envoyv2-v1alpha3_istio |
|
/test gencheck_istio |
This required several changes and new features: - Support for multiple verifiers - Support for custom output - Separate streams of command output (stdout, stderr) - Disallow duplicate snippet names - Eliminate intermediate files when evaluating templates
ccbde29 to
4d64feb
Compare
|
/test integ-galley-k8s-tests_istio |
Includes a new image for prow based on ubuntu bionic. Needed by istio#18577
This required several changes and new features: - Support for multiple verifiers - Support for custom output - Separate streams of command output (stdout, stderr) - Disallow duplicate snippet names - Eliminate intermediate files when evaluating templates
* Upgrade prow base OS to ubuntu bionic This is needed to unblock istio/istio#18577 * removing commented command.
* Upgrade prow base OS to ubuntu bionic This is needed to unblock istio/istio#18577 * removing commented command.
This required several changes and new features: