Skip to content

Update docker to ce/new enough to do FROM ... AS and copy --from#366

Merged
sebastienvas merged 3 commits intoistio:masterfrom
ldemailly:master
Aug 5, 2017
Merged

Update docker to ce/new enough to do FROM ... AS and copy --from#366
sebastienvas merged 3 commits intoistio:masterfrom
ldemailly:master

Conversation

@ldemailly
Copy link
Copy Markdown
Member

@ldemailly ldemailly commented Aug 5, 2017 •
edited
Loading

Try#2 after #365: Need to switch to CE to get new enough

Pushed gcr.io/istio-testing/prowbazel:0.2.1

Switching docker to 17.05.0~ce-0~ubuntu-xenial in order to get FROM ... AS and copy --from

Really fixes #364

@ldemailly
Update to newer docker
463205a 
Fixes istio#364
Ran make image and make push so gcr.io/istio-testing/prowbazel:0.2.0
Is there
@ldemailly
Merge remote-tracking branch 'istio/master'
c73419f
@ldemailly
Update docker to ce/new enough to do FROM ... AS and copy --from
55ddb63 
Need to switch to CE to get new enough
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 5, 2017
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 5, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ldemailly
We suggest the following additional approver: yutongz

Assign the PR to them by writing /assign @yutongz in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly mentioned this pull request Aug 5, 2017
Merged
@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Aug 5, 2017

@sebastienvas my first attempt didn't work (latest EE isn't new enough but this one is)

@ldemailly ldemailly mentioned this pull request Aug 5, 2017
Merged
@sebastienvas sebastienvas merged commit 950ea44 into istio:master Aug 5, 2017
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Aug 5, 2017

@ldemailly: I updated Prow config for you!.

Details

In response to this:

Try#2 after #365: Need to switch to CE to get new enough

Pushed gcr.io/istio-testing/prowbazel:0.2.1

Switching docker to 17.05.0~ce-0~ubuntu-xenial in order to get FROM ... AS and copy --from

Really fixes #364

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Aug 5, 2017

ty!!!

@sebastienvas
Copy link
Copy Markdown
Contributor

sebastienvas commented Aug 11, 2017

I am seeing this failure in one of the prow job

  • [[ 1000 -ne 0 ]]
  • SUDO=sudo
  • sudo service docker start
    /etc/init.d/docker: 103: ulimit: error setting limit (Operation not permitted)

@nlandolfi
Copy link
Copy Markdown
Contributor

nlandolfi commented Aug 11, 2017

which one? link?

@sebastienvas
Copy link
Copy Markdown
Contributor

sebastienvas commented Aug 11, 2017

I filed #370.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sebastienvas sebastienvas sebastienvas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

need newer docker

6 participants

@ldemailly @istio-merge-robot @istio-testing @sebastienvas @nlandolfi @googlebot