Skip to content

Update to newer docker#365

Merged
istio-merge-robot merged 1 commit intoistio:masterfrom
ldemailly:master
Aug 4, 2017
Merged

Update to newer docker#365
istio-merge-robot merged 1 commit intoistio:masterfrom
ldemailly:master

Conversation

@ldemailly
Copy link
Copy Markdown
Member

@ldemailly ldemailly commented Aug 4, 2017 •
edited
Loading

Fixes #364
Ran make image and make push so gcr.io/istio-testing/prowbazel:0.2.0
Is there

Updated docker to 1.13 (equivalent to docker 17; with support for layered builds)

@ldemailly
Update to newer docker
463205a 
Fixes istio#364
Ran make image and make push so gcr.io/istio-testing/prowbazel:0.2.0
Is there
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 4, 2017
@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Aug 4, 2017

@nlandolfi / @sebastienvas please review/merge (and maybe add me to the contributors too)
thanks!

This was referenced Aug 4, 2017
Merged
Merged
@nlandolfi
Copy link
Copy Markdown
Contributor

nlandolfi commented Aug 4, 2017

/lgtm

@sebastienvas
Copy link
Copy Markdown
Contributor

sebastienvas commented Aug 4, 2017

/lgtm
/approve no-issue

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 4, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly, nlandolfi, sebastienvas

Associated issue: 364

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 4, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 4, 2017

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit f673e22 into istio:master Aug 4, 2017
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Aug 4, 2017

@ldemailly: I updated Prow config for you!.

Details

In response to this:

Fixes #364
Ran make image and make push so gcr.io/istio-testing/prowbazel:0.2.0
Is there

Updated docker to 1.13 (equivalent to docker 17; with support for layered builds)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ldemailly ldemailly mentioned this pull request Aug 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sebastienvas sebastienvas sebastienvas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nlandolfi nlandolfi

@sebastienvas sebastienvas

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ldemailly @nlandolfi @sebastienvas @istio-merge-robot @istio-testing @googlebot