feat(stats): add support for canonical service labels#2658
Merged
istio-testing merged 2 commits intoistio:masterfrom Feb 7, 2020
Merged
feat(stats): add support for canonical service labels#2658istio-testing merged 2 commits intoistio:masterfrom
istio-testing merged 2 commits intoistio:masterfrom
Conversation
bianpengyuan
approved these changes
Feb 6, 2020
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
10e4697 to
69fe142
Compare
Contributor
Author
|
/test test-tsan_proxy |
kyessenov
reviewed
Feb 7, 2020
| socket_address: | ||
| address: 127.0.0.1 | ||
| port_value: 20083 | ||
| port_value: 20103 |
Contributor
Author
There was a problem hiding this comment.
??? generated file. Got changed by running that test.
Contributor
Author
|
/test test-tsan_proxy |
1 similar comment
Contributor
Author
|
/test test-tsan_proxy |
douglas-reid
added a commit
to douglas-reid/proxy
that referenced
this pull request
Feb 7, 2020
douglas-reid
added a commit
to douglas-reid/proxy
that referenced
this pull request
Feb 7, 2020
istio-testing
pushed a commit
that referenced
this pull request
Feb 11, 2020
* feat(stats): support grpc status codes in metrics (#2624) * fix(stats): remove policy-related dimensions (#2647) * feat(stats): add support for canonical service labels (#2658) * update istio/envoy SHA Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * add missing deps for cel Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * buildifier lint fix WORKSPACE respositories.bzl Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * restore file test path * commenting out RBE stuff Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * skip http mxc test Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support to the
statsextension for reporting{source|destination}_canonical_servicelabels to Istio metrics.This is part of the approved proposal for Istio Canonical Service. Note: the actual stats config in istio/istio bootstrap will need to be updated to match.
Signed-off-by: Douglas Reid douglas-reid@users.noreply.github.com