Skip to content

[release-1.5] Updates to stats labels#2660

Merged
istio-testing merged 9 commits intoistio:release-1.5from
douglas-reid:cherry-pick-1.5-stats-updates
Feb 11, 2020
Merged

[release-1.5] Updates to stats labels#2660
istio-testing merged 9 commits intoistio:release-1.5from
douglas-reid:cherry-pick-1.5-stats-updates

Conversation

@douglas-reid
Copy link
Copy Markdown
Contributor

@douglas-reid douglas-reid commented Feb 7, 2020

Manual cherry-pick of the following commits:

  • 5d061b6: Added grpc_response_status labels to the metrics
  • 47dcca4: Removed unused policy labels from the metrics
  • d20b4cb: Added {source|destination}_canonical_service labels to the metrics

These are cherry-picked together to save time, as these are all related changes in the same bit of code -- and all of those commits require checking-in a generated file.

This also updates the istio/envoy SHA dep to the latest commit from the istio/envoy@release-1.5 branch (required by the cherry-picks).

@douglas-reid douglas-reid requested a review from a team February 7, 2020 21:22
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 7, 2020
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 7, 2020
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
@douglas-reid
Copy link
Copy Markdown
Contributor Author

/test test-tsan_proxy_release-1.5

1 similar comment
@douglas-reid
Copy link
Copy Markdown
Contributor Author

/test test-tsan_proxy_release-1.5

@douglas-reid
Copy link
Copy Markdown
Contributor Author

@fpesce thanks!

@istio-testing istio-testing merged commit dc79048 into istio:release-1.5 Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants