Support Mixer TCP filter to send string type of attribute "connection.event"#1371
Merged
istio-merge-robot merged 1 commit intoistio:masterfrom Apr 9, 2018
Merged
Conversation
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiwzhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
diemtvu
added a commit
to diemtvu/istio
that referenced
this pull request
Apr 12, 2018
diemtvu
added a commit
to diemtvu/istio
that referenced
this pull request
Apr 12, 2018
rshriram
pushed a commit
to istio/istio
that referenced
this pull request
Apr 12, 2018
* Update proxy sha for authn filter config fix * Update to include tls option for authn filter. * Update test for istio/proxy#1371 * Update test for istio/proxy#1371
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Mixer need to keep tracking of TCP connection creation rate.
Support Mixer TCP filter to send attribute "connection.event".
In Check() call, "connection.event" is set to "open"
In periodical Report() call, "connection.event" is set to "continue"
In final Report() call, "connection.event" is set to "close"
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1369Special notes for your reviewer:
Release note: