Skip to content

Update proxy sha to 04/10#4851

Merged
rshriram merged 4 commits intoistio:masterfrom
diemtvu:proxy_update
Apr 12, 2018
Merged

Update proxy sha to 04/10#4851
rshriram merged 4 commits intoistio:masterfrom
diemtvu:proxy_update

Conversation

@diemtvu
Copy link
Copy Markdown
Contributor

@diemtvu diemtvu commented Apr 10, 2018

istio/proxy#1377 fix the authn filter proto.

@diemtvu diemtvu requested a review from rshriram April 10, 2018 18:40
@diemtvu
Copy link
Copy Markdown
Contributor Author

diemtvu commented Apr 10, 2018

/retest

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 11, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram

Assign the PR to them by writing /assign @rshriram in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diemtvu diemtvu changed the title Update proxy sha to #1377 Update proxy sha to 04/10 Apr 11, 2018
@diemtvu
Copy link
Copy Markdown
Contributor Author

diemtvu commented Apr 11, 2018

/retest

1 similar comment
@diemtvu
Copy link
Copy Markdown
Contributor Author

diemtvu commented Apr 11, 2018

/retest

@diemtvu
Copy link
Copy Markdown
Contributor Author

diemtvu commented Apr 11, 2018

/retest

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2018 •
edited
Loading

Codecov Report

Merging #4851 into master will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4851   +/-   ##
======================================
+ Coverage      72%     73%   +1%     
======================================
  Files         302     302           
  Lines       25274   25199   -75     
======================================
- Hits        18173   18155   -18     
+ Misses       6365    6319   -46     
+ Partials      736     725   -11
Impacted Files Coverage Δ
mixer/adapter/stackdriver/log/log.go 88% <0%> (-4%) ⬇️
mixer/adapter/statsd/statsd.go 96% <0%> (-1%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 67% <0%> (-1%) ⬇️
mixer/pkg/config/crd/store.go 99% <0%> (ø) ⬇️
mixer/adapter/rbac/rbacStore.go 84% <0%> (ø) ⬇️
mixer/adapter/circonus/circonus.go 71% <0%> (ø) ⬇️
mixer/adapter/dogstatsd/dogstatsd.go 100% <0%> (ø) ⬆️
mixer/pkg/protobuf/yaml/resolver.go 100% <0%> (ø) ⬆️
mixer/adapter/list/regexList.go 100% <0%> (ø) ⬆️
mixer/adapter/list/list.go 100% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f77a4...b1e0629. Read the comment docs.

@diemtvu
Copy link
Copy Markdown
Contributor Author

diemtvu commented Apr 11, 2018

/test e2e-bookInfo
/test e2e-simple

@diemtvu diemtvu added the lgtm label Apr 12, 2018
@rshriram rshriram merged commit 1f0df33 into istio:master Apr 12, 2018
@diemtvu diemtvu deleted the proxy_update branch July 27, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rshriram rshriram

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@diemtvu @istio-testing @rshriram @googlebot