Skip to content

Updates demo tests to use diff instead of copy of demo files#85

Merged
sebastienvas merged 4 commits intoistio:masterfrom
sebastienvas:demo
Mar 23, 2017
Merged

Updates demo tests to use diff instead of copy of demo files#85
sebastienvas merged 4 commits intoistio:masterfrom
sebastienvas:demo

Conversation

@sebastienvas
Copy link
Copy Markdown
Contributor

@sebastienvas sebastienvas commented Mar 23, 2017

  • Will catch demo incompatible changes as diff apply will fail.
  • Every file generation and updates required by the test happen outside of the workspace.

This change is Reviewable

@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

Copy link
Copy Markdown
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment. Other than that, LGTM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the above line do ? Bash has a bunch of vodoo stuff that not everyone knows:). So it might be good practice if we add comments to such constructs so that someone else could debug when needed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as well

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Contributor Author

@sebastienvas sebastienvas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

@sebastienvas sebastienvas merged commit 3a09418 into istio:master Mar 23, 2017
@sebastienvas sebastienvas deleted the demo branch March 23, 2017 23:16
zenlint pushed a commit to zenlint/istio that referenced this pull request Aug 30, 2017
rshriram pushed a commit that referenced this pull request Oct 30, 2017
Updates demo tests to use diff instead of copy of demo files

Former-commit-id: 3a09418
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
Updates demo tests to use diff instead of copy of demo files

Former-commit-id: 3a09418
guptasu pushed a commit to guptasu/istio that referenced this pull request Jun 11, 2018
* Update documentation on our API surface to line up with today's world. Various other small touchups

* Another round of touch-ups. Mostly bringing in comment lengths and annotating fields as required or optional in our config protos.
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
* use uuid for deduplication_id

* Only call uuid once.
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
* Emphasize that dry run is default

* Review comments
deva26 pushed a commit to deva26/istio that referenced this pull request Jun 24, 2020
* Add service def name. Use path for certs

* Typo in values
jacob-delgado pushed a commit that referenced this pull request Aug 24, 2021
istio-testing pushed a commit that referenced this pull request Aug 25, 2021
* [1.9] Security fixes (#80)

* release 1.9: use case-insensitive match for host field in authz (#75)

Same as https://github.com/istio-private/istio/pull/70

Signed-off-by: Yangmin Zhu <ymzhu@google.com>

* [1.9] Strip # part in URL by default and offer a flag to opt-out

Co-authored-by: Yangmin Zhu <ymzhu@google.com>

* add test for request with # character (#85)

* Update base image for 1.9.8 (#88)

* Update base image for 1.9.8

* Update Makefile.core.mk

Co-authored-by: Oliver Liu <yonggangl@google.com>
Co-authored-by: Yangmin Zhu <ymzhu@google.com>
libesz pushed a commit to libesz/istio that referenced this pull request Nov 11, 2021
asmigala pushed a commit to asmigala/istio that referenced this pull request Jul 24, 2024
…ase-1.22-merge_upstream_istio_release_1_22-b34c6a22

Automator: merge upstream changes to openshift-service-mesh/istio@release-1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants