Skip to content

Update bookinfo readme#80

Closed
andraxylia wants to merge 2 commits intomasterfrom
readme
Closed

Update bookinfo readme#80
andraxylia wants to merge 2 commits intomasterfrom
readme

Conversation

@andraxylia
Copy link
Copy Markdown
Contributor

@andraxylia andraxylia commented Mar 22, 2017 •
edited by mandarjog
Loading

User needs to first confirm basic app is working, before applying routing-rules.

This change is Reviewable

@andraxylia andraxylia requested a review from frankbu March 22, 2017 23:21
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 22, 2017

Jenkins job istio/presubmit passed

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Mar 23, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes labels Mar 23, 2017
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

12 similar comments
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

frankbu
frankbu approved these changes Mar 23, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

1 similar comment
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@rshriram rshriram added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Mar 23, 2017
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

2 similar comments
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@andraxylia andraxylia closed this Mar 23, 2017
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

@andraxylia andraxylia reopened this Mar 23, 2017
@andraxylia andraxylia closed this Mar 23, 2017
@andraxylia andraxylia deleted the readme branch March 23, 2017 16:19
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 23, 2017

Jenkins job istio/presubmit passed

zenlint pushed a commit to zenlint/istio that referenced this pull request Aug 30, 2017
@frankbu
traffic management doc improvements (istio#80)
85bd965 
* request timeout task

* traffic management docs improvements

* address review comments
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
@douglas-reid @geeknoid
Fix bazel.build to respect sandbox. (istio#80)
c3b6e13 
Former-commit-id: 502e3796828e167d7fe66000074e2e75e36ff69d
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@douglas-reid @geeknoid
Fix bazel.build to respect sandbox. (#80)
f490923 
Former-commit-id: 206c61f9366e29906e4153e5cf66e736a671afe0
guptasu pushed a commit to guptasu/istio that referenced this pull request Jun 11, 2018
@ZackButcher
Collapse AttributeDescriptor into a map<string, AttributeInfo> (istio#80
7d82318 
)

* Remove AttributeDescriptor, collapsing it into a map<string, AttributeInfo> in the AttributeManifest message.

* Add back comments about the requirements for attribute naming that were originally on the AttributeDescriptor message

* Add comments removed from attribute_descriptor.proto to AttributeManifest.
rajusharma pushed a commit to rajusharma/istio that referenced this pull request Jul 2, 2019
@mergify
support multiple app namespaces. (istio#80)
5ae17cf 
* support multiple app namespaces.

Signed-off-by: llcao <llcao@cn.ibm.com>

* expose appNamespaces with list.
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@richardwxn
Remove vendor entirely (istio#80)
549f216 
* Remove vendor entirely

* Update prow and circleci
deva26 pushed a commit to deva26/istio that referenced this pull request Jun 24, 2020
@hanahmily
Merge pull request istio#80 from tetrateio/gao-6.6.0.1
b041bd5 
Update OAP oal
jacob-delgado pushed a commit that referenced this pull request Aug 24, 2021
@yangminzhu
[1.9] Security fixes (#80)
084b417 
* release 1.9: use case-insensitive match for host field in authz (#75)

Same as https://github.com/istio-private/istio/pull/70

Signed-off-by: Yangmin Zhu <ymzhu@google.com>

* [1.9] Strip # part in URL by default and offer a flag to opt-out

Co-authored-by: Yangmin Zhu <ymzhu@google.com>
istio-testing pushed a commit that referenced this pull request Aug 25, 2021
@jacob-delgado @yangminzhu
[release-1.9] August 2021 security patches (#34860)
3a6950f 
* [1.9] Security fixes (#80)

* release 1.9: use case-insensitive match for host field in authz (#75)

Same as https://github.com/istio-private/istio/pull/70

Signed-off-by: Yangmin Zhu <ymzhu@google.com>

* [1.9] Strip # part in URL by default and offer a flag to opt-out

Co-authored-by: Yangmin Zhu <ymzhu@google.com>

* add test for request with # character (#85)

* Update base image for 1.9.8 (#88)

* Update base image for 1.9.8

* Update Makefile.core.mk

Co-authored-by: Oliver Liu <yonggangl@google.com>
Co-authored-by: Yangmin Zhu <ymzhu@google.com>
libesz pushed a commit to libesz/istio that referenced this pull request Nov 11, 2021
@yangminzhu
[1.9] Security fixes (istio#80)
e553d29 
* release 1.9: use case-insensitive match for host field in authz (istio#75)

Same as https://github.com/istio-private/istio/pull/70

Signed-off-by: Yangmin Zhu <ymzhu@google.com>

* [1.9] Strip # part in URL by default and offer a flag to opt-out

Co-authored-by: Yangmin Zhu <ymzhu@google.com>
antonioberben pushed a commit to antonioberben/istio that referenced this pull request Jan 29, 2024
Merge pull request istio#80 from naseemkullah/fix-workflow
d421a2e 
Bump chart to rerun release.
luksa pushed a commit to luksa/istio that referenced this pull request Oct 14, 2024
@openshift-merge-bot
Merge pull request istio#80 from openshift-service-mesh-bot/none-mast…
34a6ec3 
…er-merge_upstream_istio_master-6253864e

Automator: merge upstream changes to openshift-service-mesh/istio@master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frankbu frankbu frankbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andraxylia @istio-testing @googlebot @frankbu @rshriram