Skip to content

[DO NOT MERGE] Auto PR to update dependencies of istio#846

Closed
istio-testing wants to merge 1 commit intomasterfrom
autoUpdateDeps_eabe4c52db516924a0b5b5cdde490e42
Closed

[DO NOT MERGE] Auto PR to update dependencies of istio#846
istio-testing wants to merge 1 commit intomasterfrom
autoUpdateDeps_eabe4c52db516924a0b5b5cdde490e42

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

@istio-testing istio-testing commented Sep 18, 2017

This PR will be merged automatically once checks are successful.

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: douglas-reid

Assign the PR to them by writing /assign @douglas-reid in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-testing istio-testing deleted the autoUpdateDeps_eabe4c52db516924a0b5b5cdde490e42 branch September 18, 2017 13:49
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
Automatic merge from submit-queue

Initial Stackdriver Metrics Adapter

This PR isn't quite finished, there's a little more cleanup and testing I need to do, but there are a few questions/comments I want to start discussion on while I'm doing that cleanup:
- As we'd discussed about Mixer config, I've gone ahead and pushed the "how do I represent these metrics in Stackdriver" config into the Adapter's config. This raises the question: how much Stackdriver specific validation is it appropriate for us to do? Stackdriver has requirements around valid metric shapes; we _could_ ensure no metric has an invalid shape in Mixer, or we could trust the config and just send the shape we're told without attempting to validate. Part of the reason this PR took so long is that I went back and forth on this. Ultimately I decided against any of that style validation. Let me know what you think.
- There are quite a few things I want to run by the Stackdriver team, as well as a few feature requests. Most center on the allowed custom metric shapes.
- How we represent metrics is broken right now: Stackdriver does not support DELTA custom metrics, e.g. a counter. We report `request_count` as a counter. We need to figure out how we'll represent our counter metrics in Stackdriver (we can only use a gauge if we're careful or assume only a single Mixer). This is part of what I want to talk to Stackdriver team about.

Former-commit-id: 4eeaaaa5c3a0e345bb5acd34f3fe44f1466d7bc1
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
Automatic merge from submit-queue

Initial Stackdriver Metrics Adapter

This PR isn't quite finished, there's a little more cleanup and testing I need to do, but there are a few questions/comments I want to start discussion on while I'm doing that cleanup:
- As we'd discussed about Mixer config, I've gone ahead and pushed the "how do I represent these metrics in Stackdriver" config into the Adapter's config. This raises the question: how much Stackdriver specific validation is it appropriate for us to do? Stackdriver has requirements around valid metric shapes; we _could_ ensure no metric has an invalid shape in Mixer, or we could trust the config and just send the shape we're told without attempting to validate. Part of the reason this PR took so long is that I went back and forth on this. Ultimately I decided against any of that style validation. Let me know what you think.
- There are quite a few things I want to run by the Stackdriver team, as well as a few feature requests. Most center on the allowed custom metric shapes.
- How we represent metrics is broken right now: Stackdriver does not support DELTA custom metrics, e.g. a counter. We report `request_count` as a counter. We need to figure out how we'll represent our counter metrics in Stackdriver (we can only use a gauge if we're careful or assume only a single Mixer). This is part of what I want to talk to Stackdriver team about.

Former-commit-id: bc51b3433babe413a8d5cb0fab675e19d33fe445
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
* Doc fixes.

* Add high-level overview and diagrams for MCP (istio#805)

* document MCP

* add additional note on NACK behavior

* add a note about ignoring stale nonces

* Add envoy metrics service configuration to ProxyConfig (istio#803)

* Add envoy metrics service configuration to ProxyConfig

Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API.

* Update proto.lock

* Reorder metrics_service_address just after statsd_udp_address

* Update comment in the authN API to match with 1.1 behavior (istio#808)

* Rename metrics_service_address to clarify that it is for Envoy's API (istio#809)

Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API.

* Generate separate HTML page per proto under networking (istio#811)

* Generate separate pages for each networking proto

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* tweaks

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Fix interdoc references

* separate doc and go gen

* change dash to underscore

* fix

* more fixes

* makefile fix

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* remove bad target

* Revert "change dash to underscore"

This reverts commit 7fbced66f620fb60b0d5e18af916567e313a0109.

* final update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Revert "Generate separate HTML page per proto under networking (istio#811)"

This reverts commit 5f14eadd since it breaks the ability
to generate reference docs in istio.io

* Update to latest tools.

* Revert "Update to latest tools."

This reverts commit 231fadc5 which I accidentally pushed to the
wrong place.

* fix mcp update error diagram (istio#810)

* update istio/tools (istio#815)

* Revert "Revert "Generate separate HTML page per proto under networking (istio#811)"" (istio#818)

* Minor updates for building docker images. (istio#817)

* Add spell checking for docs. (istio#819)

* Add a bunch of words to the custom dictionary.

* Document exportTo restrictions (istio#820)

* Doc fixes. (istio#821)

* Proxy config: Add tls_certs_to_watch field (istio#824)

* Proxy config: Add tls_certs_to_watch field

* Address PR comment

* Revert "Proxy config: Add tls_certs_to_watch field (istio#824)" (istio#825)

This reverts commit e613e358ae8d4f331dd48904b0a2b176e11bf7f5.

* Update gateway and sidecar hosts doc (istio#826)

* Update gateway and sidecar hosts doc

* regen

* review comments

* Update API docs (service entry, gateway, sidecar) (istio#831)

* Update sidecar and gateway docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* gen docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update service entry

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* add configurable dns refresh rate to mesh for strict dns cluster,  (istio#832)

* add configurable dns refresh rate to mesh for strict dns cluster, issue istio#12181

* add lock file

* Hosts are not ignored in ServiceEntry for HTTPs (istio#833)

* Hosts are not ignored in ServiceEntry for HTTPs

* Clarify

* Reword

* Generate protos

* Address code review comments

* Fix typo

* generate

* make mixer config marshal deterministic (istio#846)

Signed-off-by: Kuat Yessenov <kuat@google.com>

* Fix some doc errors. (istio#854)

This started out to just fix a bad link to unblock work on
istio.io, but I ended up fixing a bunch of typos/incorrect format
throughout.

* Fix two more broken links. (istio#856)

* Fix CRD examples for release-1.1 (istio#859)

* fix MeshNetworks demo (istio#841)

* fix MeshNetworks demo

* generate

* update

* last minute doc fixes (istio#865)

Signed-off-by: Shriram Rajagopalan <rshriram@gmail.com>

* Clarify comment for server_name field in Mixer oop auth config (istio#800)

* add mixerclient config to istio.io reference docs (istio#827)

* Envoyfilter docs fix (istio#867)

* Tweaks to get the mixer client config docs to be published. (istio#868)

* Change where the Mixer client docs are published.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants