Skip to content

Add a check to figure if install/updateVersion.sh needs to be called#820

Merged
istio-merge-robot merged 1 commit intoistio:masterfrom
sebastienvas:update-version
Sep 15, 2017
Merged

Add a check to figure if install/updateVersion.sh needs to be called#820
istio-merge-robot merged 1 commit intoistio:masterfrom
sebastienvas:update-version

Conversation

@sebastienvas
Copy link
Copy Markdown
Contributor

@sebastienvas sebastienvas commented Sep 15, 2017

Fixes #643

none

@sebastienvas
Copy link
Copy Markdown
Contributor Author

@ldemailly this is the kind of example where my contribution is not required like @gnirodi said, this is a 15 minute fix.

Copy link
Copy Markdown
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@ldemailly
Copy link
Copy Markdown
Member

/lgtm
did you test it (by changing a template file?)

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

/test all [submit-queue is verifying that this PR is safe to merge]

@sebastienvas
Copy link
Copy Markdown
Contributor Author

I tested it by changing any file.

@istio-merge-robot
Copy link
Copy Markdown

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit ab37a75 into istio:master Sep 15, 2017
rshriram pushed a commit that referenced this pull request Oct 30, 2017
…820)

Automatic merge from submit-queue

Add a check to figure if install/updateVersion.sh needs to be called

Fixes #643

```release-note
none
```

Former-commit-id: ab37a75
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
…stio#820)

Automatic merge from submit-queue

Add a check to figure if install/updateVersion.sh needs to be called

Fixes istio#643

```release-note
none
```

Former-commit-id: ab37a75
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
…820)

Automatic merge from submit-queue

Add a check to figure if install/updateVersion.sh needs to be called

Fixes #643

```release-note
none
```

Former-commit-id: ab37a75
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
* Doc fixes.

* Add high-level overview and diagrams for MCP (istio#805)

* document MCP

* add additional note on NACK behavior

* add a note about ignoring stale nonces

* Add envoy metrics service configuration to ProxyConfig (istio#803)

* Add envoy metrics service configuration to ProxyConfig

Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API.

* Update proto.lock

* Reorder metrics_service_address just after statsd_udp_address

* Update comment in the authN API to match with 1.1 behavior (istio#808)

* Rename metrics_service_address to clarify that it is for Envoy's API (istio#809)

Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API.

* Generate separate HTML page per proto under networking (istio#811)

* Generate separate pages for each networking proto

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* tweaks

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Fix interdoc references

* separate doc and go gen

* change dash to underscore

* fix

* more fixes

* makefile fix

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* remove bad target

* Revert "change dash to underscore"

This reverts commit 7fbced66f620fb60b0d5e18af916567e313a0109.

* final update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Revert "Generate separate HTML page per proto under networking (istio#811)"

This reverts commit 5f14eadd since it breaks the ability
to generate reference docs in istio.io

* Update to latest tools.

* Revert "Update to latest tools."

This reverts commit 231fadc5 which I accidentally pushed to the
wrong place.

* fix mcp update error diagram (istio#810)

* update istio/tools (istio#815)

* Revert "Revert "Generate separate HTML page per proto under networking (istio#811)"" (istio#818)

* Minor updates for building docker images. (istio#817)

* Add spell checking for docs. (istio#819)

* Add a bunch of words to the custom dictionary.

* Document exportTo restrictions (istio#820)

* Doc fixes. (istio#821)

* Proxy config: Add tls_certs_to_watch field (istio#824)

* Proxy config: Add tls_certs_to_watch field

* Address PR comment

* Revert "Proxy config: Add tls_certs_to_watch field (istio#824)" (istio#825)

This reverts commit e613e358ae8d4f331dd48904b0a2b176e11bf7f5.

* Update gateway and sidecar hosts doc (istio#826)

* Update gateway and sidecar hosts doc

* regen

* review comments

* Update API docs (service entry, gateway, sidecar) (istio#831)

* Update sidecar and gateway docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* gen docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update service entry

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* add configurable dns refresh rate to mesh for strict dns cluster,  (istio#832)

* add configurable dns refresh rate to mesh for strict dns cluster, issue istio#12181

* add lock file

* Post-merge generation
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
* Doc fixes.

* Add high-level overview and diagrams for MCP (istio#805)

* document MCP

* add additional note on NACK behavior

* add a note about ignoring stale nonces

* Add envoy metrics service configuration to ProxyConfig (istio#803)

* Add envoy metrics service configuration to ProxyConfig

Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API.

* Update proto.lock

* Reorder metrics_service_address just after statsd_udp_address

* Update comment in the authN API to match with 1.1 behavior (istio#808)

* Rename metrics_service_address to clarify that it is for Envoy's API (istio#809)

Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API.

* Generate separate HTML page per proto under networking (istio#811)

* Generate separate pages for each networking proto

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* tweaks

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Fix interdoc references

* separate doc and go gen

* change dash to underscore

* fix

* more fixes

* makefile fix

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* remove bad target

* Revert "change dash to underscore"

This reverts commit 7fbced66f620fb60b0d5e18af916567e313a0109.

* final update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Revert "Generate separate HTML page per proto under networking (istio#811)"

This reverts commit 5f14eadd since it breaks the ability
to generate reference docs in istio.io

* Update to latest tools.

* Revert "Update to latest tools."

This reverts commit 231fadc5 which I accidentally pushed to the
wrong place.

* fix mcp update error diagram (istio#810)

* update istio/tools (istio#815)

* Revert "Revert "Generate separate HTML page per proto under networking (istio#811)"" (istio#818)

* Minor updates for building docker images. (istio#817)

* Add spell checking for docs. (istio#819)

* Add a bunch of words to the custom dictionary.

* Document exportTo restrictions (istio#820)

* Doc fixes. (istio#821)

* Proxy config: Add tls_certs_to_watch field (istio#824)

* Proxy config: Add tls_certs_to_watch field

* Address PR comment

* Revert "Proxy config: Add tls_certs_to_watch field (istio#824)" (istio#825)

This reverts commit e613e358ae8d4f331dd48904b0a2b176e11bf7f5.

* Update gateway and sidecar hosts doc (istio#826)

* Update gateway and sidecar hosts doc

* regen

* review comments

* Update API docs (service entry, gateway, sidecar) (istio#831)

* Update sidecar and gateway docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* gen docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update service entry

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* add configurable dns refresh rate to mesh for strict dns cluster,  (istio#832)

* add configurable dns refresh rate to mesh for strict dns cluster, issue istio#12181

* add lock file

* Hosts are not ignored in ServiceEntry for HTTPs (istio#833)

* Hosts are not ignored in ServiceEntry for HTTPs

* Clarify

* Reword

* Generate protos

* Address code review comments

* Fix typo

* generate

* make mixer config marshal deterministic (istio#846)

Signed-off-by: Kuat Yessenov <kuat@google.com>

* Fix some doc errors. (istio#854)

This started out to just fix a bad link to unblock work on
istio.io, but I ended up fixing a bunch of typos/incorrect format
throughout.

* Fix two more broken links. (istio#856)

* Fix CRD examples for release-1.1 (istio#859)

* fix MeshNetworks demo (istio#841)

* fix MeshNetworks demo

* generate

* update

* last minute doc fixes (istio#865)

Signed-off-by: Shriram Rajagopalan <rshriram@gmail.com>

* Clarify comment for server_name field in Mixer oop auth config (istio#800)

* add mixerclient config to istio.io reference docs (istio#827)

* Envoyfilter docs fix (istio#867)

* Tweaks to get the mixer client config docs to be published. (istio#868)

* Change where the Mixer client docs are published.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants