Skip to content

Update istio-pilot.yaml.tmpl#771

Closed
kyessenov wants to merge 1 commit intomasterfrom
kyessenov-patch-1
Closed

Update istio-pilot.yaml.tmpl#771
kyessenov wants to merge 1 commit intomasterfrom
kyessenov-patch-1

Conversation

@kyessenov
Copy link
Copy Markdown
Contributor

@kyessenov kyessenov commented Sep 13, 2017 •
edited by ldemailly
Loading

Release note:

NONE

@kyessenov kyessenov requested a review from ldemailly September 13, 2017 06:09
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Sep 13, 2017

/lgtm
proof is in the pudding though

ldemailly
ldemailly approved these changes Sep 13, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dog-science

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 13, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly mentioned this pull request Sep 13, 2017
Closed
andraxylia
andraxylia suggested changes Sep 13, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@andraxylia andraxylia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break cluster-wide, if istio-ingress is located in istio-system, in a different namespace than the application.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 13, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@kyessenov kyessenov closed this Sep 13, 2017
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Sep 13, 2017 •
edited
Loading

@kyessenov: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/new-e2e-rbac_no_auth.sh 8e82da6 link /test new-e2e-rbac_no_auth
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov kyessenov deleted the kyessenov-patch-1 branch September 13, 2017 06:48
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
@qiwzhang
Send report for requests rejected by other filters. (istio#771)
5356314
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
@hklai
add response headers (istio#769) (istio#771)
d0444f6 
Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@andraxylia andraxylia andraxylia requested changes

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ldemailly ldemailly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kyessenov @ldemailly @istio-merge-robot @istio-testing @andraxylia @googlebot