Skip to content

Correct match with clusterrole#769

Merged
andraxylia merged 1 commit intomasterfrom
unique
Sep 13, 2017
Merged

Correct match with clusterrole#769
andraxylia merged 1 commit intomasterfrom
unique

Conversation

@andraxylia
Copy link
Copy Markdown
Contributor

@andraxylia andraxylia commented Sep 13, 2017

Use the correct unique clusterrole in the clusterrolebinding.

ldemailly
ldemailly approved these changes Sep 13, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoping the logs will be error free/we got it right this time

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Sep 13, 2017 •
edited
Loading

/lgtm
(conditional on error free logs including deletes/cleanup)

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 13, 2017

Adding do-not-merge because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-action-required", "release-note-experimental" or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

@istio-merge-robot istio-merge-robot added the do-not-merge Block automatic merging of a PR. label Sep 13, 2017
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 13, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Sep 13, 2017 •
edited
Loading

@andraxylia: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/new-e2e-rbac_no_auth.sh 1cd573e link /test new-e2e-rbac_no_auth
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andraxylia andraxylia mentioned this pull request Sep 13, 2017
Merged
@andraxylia andraxylia merged commit c5bec60 into master Sep 13, 2017
@andraxylia andraxylia deleted the unique branch September 13, 2017 05:31
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Sep 13, 2017

fantastic, looks like the only slightly suspicious error left in this run was

W0913 05:28:39.313] Error from server (NotFound): error when deleting "/tmp/demo_test286663287/route-rule-all-v1.yaml": routerules.config.istio.io "reviews-default" not found

which is pretty good

rshriram pushed a commit that referenced this pull request Oct 30, 2017
@andraxylia
Correct match with clusterrole (#769)
e8bb4a3 
Former-commit-id: c5bec60
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
@andraxylia
Correct match with clusterrole (istio#769)
633f048 
Former-commit-id: c5bec60
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
@andraxylia
Correct match with clusterrole (#769)
c8cef7e 
Former-commit-id: c5bec60
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
@kyessenov @istio-testing
add response headers (istio#769)
0dd68ef 
Signed-off-by: Kuat Yessenov <kuat@google.com>
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
@hklai
add response headers (istio#769) (istio#771)
d0444f6 
Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ldemailly ldemailly

Labels

do-not-merge Block automatic merging of a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andraxylia @ldemailly @istio-merge-robot @istio-testing @googlebot