Improve config validation health checks#7605
Merged
rshriram merged 1 commit intoistio:release-1.0from Aug 14, 2018
Merged
Conversation
Readiness and liveliness probes were failing on some providers because GET requests were blocking for multiple seconds. Mitigate the issue by decreasing the frequency of GET (to avoid possible throttling) and increase the acceptable health check interval from 4s to 10s. Shorm term fix for istio#7586. Longer term fix requires switching to proper controller-style reconciliation. That work should be aligned with the sidecar injector.
Codecov Report
@@ Coverage Diff @@
## release-1.0 #7605 +/- ##
============================================
+ Coverage 72% 72% +1%
============================================
Files 358 358
Lines 30990 31091 +101
============================================
+ Hits 22123 22242 +119
+ Misses 7923 7901 -22
- Partials 944 948 +4
Continue to review full report at Codecov.
|
Contributor
Contributor
|
/lgtm Though I don't think I understand your comment about long term fix being reconciliation. Can you elaborate? |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayj, ozevren The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
We should use a SharedInformer instead of polling. I updated the original comment message to reflect this. |
ostromart
approved these changes
Aug 2, 2018
|
@ayj i would like to help with switching to shared informers, whats the process ? can i create an issue and start working on it. Can you point to which components you specifically meant ? |
rshriram
approved these changes
Aug 14, 2018
ayj
added a commit
to ayj/istio
that referenced
this pull request
Aug 21, 2018
Readiness and liveliness probes were failing on some providers because GET requests were blocking for multiple seconds. Mitigate the issue by decreasing the frequency of GET (to avoid possible throttling) and increase the acceptable health check interval from 4s to 10s. Shorm term fix for istio#7586. Longer term fix requires switching to proper controller-style reconciliation. That work should be aligned with the sidecar injector.
rshriram
pushed a commit
that referenced
this pull request
Aug 22, 2018
* Improve config validation health checks (#7605) Readiness and liveliness probes were failing on some providers because GET requests were blocking for multiple seconds. Mitigate the issue by decreasing the frequency of GET (to avoid possible throttling) and increase the acceptable health check interval from 4s to 10s. Shorm term fix for #7586. Longer term fix requires switching to proper controller-style reconciliation. That work should be aligned with the sidecar injector. * decouple validation webhook's health checking and reconciliation loop (#7986) The validation webhook's health file updates and configuration reconciliation were invoked from the same goroutine. Delays in checking and updating the k8s configuration could result in the health file not being updated in time to pass the health checks. Use istio.io/istio/pkg/probe to decouple the two code paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness and liveliness probes were failing on some providers because
GET requests were blocking for multiple seconds. Mitigate the issue
by decreasing the frequency of GET (to avoid possible throttling) and
increase the acceptable health check interval from 4s to 10s.
Short term fix for #7586. Longer
term fix requires switching to use SharedInformer.