Improve config validation health checking #8118
Merged
rshriram merged 2 commits intoistio:masterfrom Aug 22, 2018
Merged
Conversation
Readiness and liveliness probes were failing on some providers because GET requests were blocking for multiple seconds. Mitigate the issue by decreasing the frequency of GET (to avoid possible throttling) and increase the acceptable health check interval from 4s to 10s. Shorm term fix for istio#7586. Longer term fix requires switching to proper controller-style reconciliation. That work should be aligned with the sidecar injector.
…istio#7986) The validation webhook's health file updates and configuration reconciliation were invoked from the same goroutine. Delays in checking and updating the k8s configuration could result in the health file not being updated in time to pass the health checks. Use istio.io/istio/pkg/probe to decouple the two code paths.
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cmluciano
reviewed
Aug 22, 2018
|
|
||
| if wh.healthCheckInterval != 0 && wh.healthCheckFile != "" { | ||
| wh.healthProbe.RegisterProbe(wh.healthController, "validation") | ||
| wh.healthProbe.SetAvailable(errors.New("not ready")) |
Member
There was a problem hiding this comment.
Can we add more context or info to this error message?
| - --tlsCertFile=/etc/istio/certs/cert-chain.pem | ||
| - --tlsKeyFile=/etc/istio/certs/key.pem | ||
| - --healthCheckInterval=2s | ||
| - --healthCheckInterval=1s |
Member
There was a problem hiding this comment.
Do we have any open issues affecting this interval?
rshriram
approved these changes
Aug 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Galley readiness and liveness improves #7605 and #7986 have already been merged into 1.0 branch. This PR merges those same changes into the master branch.