Skip to content

Kiali v0.5.0 on Ansible Installer#6930

Closed
gbaufake wants to merge 1 commit intoistio:masterfrom
gbaufake:kiali-addon-v0.5.0-ansible
Closed

Kiali v0.5.0 on Ansible Installer#6930
gbaufake wants to merge 1 commit intoistio:masterfrom
gbaufake:kiali-addon-v0.5.0-ansible

Conversation

@gbaufake
Copy link
Copy Markdown
Member

@gbaufake gbaufake commented Jul 9, 2018

Hi Istio Team,

As #6929, I am sending this PR to update Kiali (v0.5.0) on Ansible Installer as well

More information about Kiali v0.5.0 - https://medium.com/kialiproject/kiali-sprint-7-istio-0-8-support-4df62e5291f2

Best Regards,
Guilherme Baufaker Rêgo

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 9, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gbaufake
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake

Assign the PR to them by writing /assign @sdake in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gbaufake
Copy link
Copy Markdown
Member Author

gbaufake commented Jul 9, 2018 •
edited
Loading

cc @sdake @gyliu513 @ymesika @geoand

gyliu513
gyliu513 reviewed Jul 10, 2018
View reviewed changes
install/ansible/istio/vars/main.yml

istio_k8s_install_path: "install/kubernetes" No newline at end of file
istio_k8s_install_path: "install/kubernetes"
kiali_version: v0.5.0
Copy link
Copy Markdown
Member

@gyliu513 gyliu513 Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not keep this in install_addons.yml?

Copy link
Copy Markdown
Member Author

@gbaufake gbaufake Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed from that just to make all vars on the same place.
Should I return to install_addons.yml?

Copy link
Copy Markdown
Member

@gyliu513 gyliu513 Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see and I'm ok to move this to same place.

Same as #6985 , as master is frozen, can you please create PR against 1.0 branch?

@gyliu513
Copy link
Copy Markdown
Member

gyliu513 commented Jul 10, 2018

/ok-to-test

@gbaufake gbaufake mentioned this pull request Jul 12, 2018
Merged
@gbaufake
Copy link
Copy Markdown
Member Author

gbaufake commented Jul 12, 2018

closing in favor of #7042

@gbaufake gbaufake closed this Jul 12, 2018
@gbaufake gbaufake mentioned this pull request Aug 27, 2018
Closed
@gbaufake gbaufake deleted the kiali-addon-v0.5.0-ansible branch September 17, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costinm costinm Awaiting requested review from costinm

@ostromart ostromart Awaiting requested review from ostromart

1 more reviewer

@gyliu513 gyliu513 gyliu513 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gbaufake @istio-testing @gyliu513 @googlebot