Skip to content

Kiali v0.5.0 on Helm Installer#6929

Closed
gbaufake wants to merge 2 commits intoistio:masterfrom
gbaufake:kiali-addon-v0.5.0-helm
Closed

Kiali v0.5.0 on Helm Installer#6929
gbaufake wants to merge 2 commits intoistio:masterfrom
gbaufake:kiali-addon-v0.5.0-helm

Conversation

@gbaufake
Copy link
Copy Markdown
Member

@gbaufake gbaufake commented Jul 9, 2018

Hi Istio Team,

Kiali was updated to 0.5.0 (fsupport for Istio 0.8.) - more info on https://medium.com/kialiproject/kiali-sprint-7-istio-0-8-support-4df62e5291f2.

Best Regards,
Guilherme Baufaker Rêgo

@istio-testing istio-testing requested review from sbezverk and sdake July 9, 2018 14:42
@gbaufake
Copy link
Copy Markdown
Member Author

gbaufake commented Jul 9, 2018

cc @sdake @gyliu513 @ymesika

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2018 •
edited
Loading

Codecov Report

Merging #6929 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #6929    +/-   ##
=======================================
- Coverage      71%     71%   -<1%     
=======================================
  Files         369     369            
  Lines       32122   31601   -521     
=======================================
- Hits        22607   22196   -411     
+ Misses       8588    8492    -96     
+ Partials      927     913    -14
Impacted Files Coverage Δ
mixer/adapter/stackdriver/log/log.go 65% <0%> (-3%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 67% <0%> (-1%) ⬇️
mixer/adapter/prometheus/server.go 95% <0%> (-1%) ⬇️
mixer/adapter/kubernetesenv/cache.go 92% <0%> (-1%) ⬇️
galley/pkg/mcp/client/client.go 99% <0%> (-1%) ⬇️
mixer/pkg/protobuf/yaml/encoder.go 99% <0%> (ø) ⬇️
mixer/adapter/stdio/stdio.go 100% <0%> (ø) ⬆️
mixer/adapter/solarwinds/solarwinds.go 0% <0%> (ø) ⬆️
mixer/adapter/memquota/rollingWindow.go 100% <0%> (ø) ⬆️
mixer/adapter/circonus/circonus.go 72% <0%> (+1%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bba996...b4045c6. Read the comment docs.

@gyliu513
Copy link
Copy Markdown
Member

gyliu513 commented Jul 9, 2018

/ok-to-test

gyliu513
gyliu513 approved these changes Jul 9, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbaufake, gyliu513

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gbaufake gbaufake mentioned this pull request Jul 9, 2018
Closed
@gbaufake gbaufake changed the title Updating Kiali to 0.5.0 on Helm Installer Kiali to 0.5.0 on Helm Installer Jul 9, 2018
@gbaufake gbaufake changed the title Kiali to 0.5.0 on Helm Installer Kiali v0.5.0 on Helm Installer Jul 9, 2018
@sdake
Copy link
Copy Markdown
Member

sdake commented Jul 10, 2018

@gbaufake if this works against release-1.0, can you submit this PR against that branch? master is currently frozen (thats what the needs-admin check is about). Might as well have latest and greatest, especially is Kiali is broken in release-1.0 (which you seem to indicate as the rev to 0.8 happened).

Cheers
-steve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 10, 2018

New changes are detected. LGTM label has been removed.

@gbaufake
Copy link
Copy Markdown
Member Author

gbaufake commented Jul 10, 2018

@sdake
OK. Kiali next release should be ready for Istio 1.0
Considering that, should I open a PR for Kiali 0.5.0 on 0.8.0 branch or wait until next kiali version then submit an update PR to master?
Best Regards,
Guilherme Baufaker Rêgo

@gyliu513
Copy link
Copy Markdown
Member

gyliu513 commented Jul 10, 2018

@gbaufake I think you can submit this PR to 1.0 branch.

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Jul 11, 2018

yes please move to 1.0 branch, given that we are unlikely to do a point release for 0.8..

@gbaufake gbaufake mentioned this pull request Jul 11, 2018
Merged
@gbaufake
Copy link
Copy Markdown
Member Author

gbaufake commented Jul 11, 2018

Closing in favor of #7007

@gbaufake gbaufake closed this Jul 11, 2018
@gbaufake gbaufake mentioned this pull request Jul 12, 2018
Merged
@gbaufake gbaufake deleted the kiali-addon-v0.5.0-helm branch September 17, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbezverk sbezverk Awaiting requested review from sbezverk

@sdake sdake Awaiting requested review from sdake

1 more reviewer

@gyliu513 gyliu513 gyliu513 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gyliu513 gyliu513

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gbaufake @gyliu513 @istio-testing @sdake @rshriram @googlebot