Skip to content

Add namespace to kiali chart secrets#6985

Merged
rshriram merged 1 commit intoistio:release-1.0from
objectiser:kialisecret2
Jul 11, 2018
Merged

Add namespace to kiali chart secrets#6985
rshriram merged 1 commit intoistio:release-1.0from
objectiser:kialisecret2

Conversation

@objectiser
Copy link
Copy Markdown
Contributor

Replaces #6926, being based on the release-1.0 branch.

@objectiser
Copy link
Copy Markdown
Contributor Author

/assign @gyliu513

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2018

Codecov Report

Merging #6985 into release-1.0 will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           release-1.0   #6985   +/-   ##
===========================================
+ Coverage           71%     71%   +1%     
===========================================
  Files              360     360           
  Lines            31197   31234   +37     
===========================================
+ Hits             22043   22116   +73     
+ Misses            8285    8251   -34     
+ Partials           869     867    -2
Impacted Files Coverage Δ
mixer/adapter/bypass/util.go 7% <0%> (-3%) ⬇️
mixer/adapter/stackdriver/log/log.go 65% <0%> (-3%) ⬇️
mixer/adapter/rbac/rbacStore.go 76% <0%> (-3%) ⬇️
mixer/adapter/signalfx/metrics.go 41% <0%> (-2%) ⬇️
pilot/pkg/model/egress_rules.go 95% <0%> (-2%) ⬇️
mixer/adapter/fluentd/fluentd.go 74% <0%> (-1%) ⬇️
mixer/adapter/rbac/rbac.go 10% <0%> (-1%) ⬇️
mixer/adapter/bypass/bypass.go 62% <0%> (-1%) ⬇️
mixer/adapter/memquota/rollingWindow.go 100% <0%> (ø) ⬆️
mixer/adapter/memquota/keys.go 100% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a37e4b...15537d3. Read the comment docs.

Copy link
Copy Markdown
Member

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, objectiser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram rshriram merged commit 40d0cae into istio:release-1.0 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants