Skip to content

Add namespace to kiali chart secrets#6926

Closed
objectiser wants to merge 1 commit intoistio:masterfrom
objectiser:kialisecret
Closed

Add namespace to kiali chart secrets#6926
objectiser wants to merge 1 commit intoistio:masterfrom
objectiser:kialisecret

Conversation

@objectiser
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, objectiser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gyliu513
Copy link
Copy Markdown
Member

/ok-to-test

@gyliu513
Copy link
Copy Markdown
Member

/test e2e-simple

@objectiser
Copy link
Copy Markdown
Contributor Author

Closing in favour of #6985, as it is based on release-1.0 branch.

@objectiser objectiser closed this Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants