Skip to content

Remove broker related code, test, and build files#6890

Merged
rshriram merged 1 commit intoistio:release-1.0from
ayj:release-1.0-remove-broker
Jul 9, 2018
Merged

Remove broker related code, test, and build files#6890
rshriram merged 1 commit intoistio:release-1.0from
ayj:release-1.0-remove-broker

Conversation

@ayj
Copy link
Copy Markdown
Contributor

@ayj ayj commented Jul 6, 2018

The broker is not under active development at this time. Most of the
code is configuration related which will need to be rewritten from
scratch when we switch over to Galley/MCP. Furthermore, the CRD tests
are adding unnecessary load on the k8s api-server and causing test
flakes in some scenarios.

Broker APIs are removing in istio/api#573 (pending). This PR can be rebased to remove the vendor'd broker APIs once that PR is merged.

@googlebot
Copy link
Copy Markdown
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ayj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

Assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jul 6, 2018
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 6, 2018
@ayj ayj force-pushed the release-1.0-remove-broker branch from d7a932a to 2395c07 Compare July 6, 2018 20:19
@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Jul 6, 2018
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 6, 2018
@ayj ayj removed request for nmittler, ostromart and ozevren July 6, 2018 20:19
Copy link
Copy Markdown
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove vendor as well

@rshriram rshriram merged commit e50c6bf into istio:release-1.0 Jul 9, 2018
rshriram pushed a commit that referenced this pull request Jul 10, 2018
@ayj ayj deleted the release-1.0-remove-broker branch October 17, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants