Skip to content

Fix racetest following #6890#6965

Merged
rshriram merged 1 commit intoistio:release-1.0from
ymesika:removeBrokerRacetest
Jul 10, 2018
Merged

Fix racetest following #6890#6965
rshriram merged 1 commit intoistio:release-1.0from
ymesika:removeBrokerRacetest

Conversation

@ymesika
Copy link
Copy Markdown
Member

@ymesika ymesika commented Jul 10, 2018

In #6890 by @ayj the broker code got removed.
It was removed from the racetest make file but not from CircleCI's config which makes the test to fail since then.

Add to #6730

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2018 •
edited
Loading

Codecov Report

Merging #6965 into release-1.0 will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.0   #6965    +/-   ##
============================================
+ Coverage           71%     71%    +1%     
============================================
  Files              360     360            
  Lines            31158   31343   +185     
============================================
+ Hits             22057   22198   +141     
- Misses            8238    8271    +33     
- Partials           863     874    +11
Impacted Files Coverage Δ
mixer/adapter/rbac/controller.go 29% <0%> (-24%) ⬇️
...olarwinds/internal/papertrail/papertrail_logger.go 59% <0%> (-21%) ⬇️
galley/pkg/mcp/client/client.go 81% <0%> (-12%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 84% <0%> (-4%) ⬇️
galley/pkg/kube/listener.go 93% <0%> (-2%) ⬇️
mixer/adapter/fluentd/fluentd.go 74% <0%> (-1%) ⬇️
mixer/adapter/rbac/rbacStore.go 76% <0%> (ø) ⬇️
mixer/adapter/servicecontrol/reportbuilder.go 89% <0%> (ø) ⬇️
mixer/adapter/redisquota/redisquota.go 90% <0%> (ø) ⬇️
mixer/adapter/memquota/memquota.go 100% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ef14b...b644b9b. Read the comment docs.

@ayj
Copy link
Copy Markdown
Contributor

ayj commented Jul 10, 2018

Thanks @ymesika. I forgot that ag doesn't search hidden directories by default =/

ayj
ayj approved these changes Jul 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@ayj ayj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 10, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ayj, ymesika
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

Assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram rshriram merged commit ef1fd59 into istio:release-1.0 Jul 10, 2018
@ymesika ymesika deleted the removeBrokerRacetest branch July 11, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costinm costinm Awaiting requested review from costinm

2 more reviewers

@ayj ayj ayj approved these changes

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ayj ayj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ymesika @ayj @istio-testing @rshriram @googlebot