Skip to content

Revert "Improve push squashing"#6677

Merged
hklai merged 8 commits intomasterfrom
revert-6641-costin-cachepush
Jun 27, 2018
Merged

Revert "Improve push squashing"#6677
hklai merged 8 commits intomasterfrom
revert-6641-costin-cachepush

Conversation

@hklai
Copy link
Copy Markdown
Contributor

@hklai hklai commented Jun 27, 2018

Reverts #6641

Prow postsubmit had started failing at this PR (and all prow presubmit tests are failing right now). Sending this out to verify.

Copy link
Copy Markdown
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: costinm, hklai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai hklai merged commit a90f565 into master Jun 27, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 27, 2018

@hklai: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-dashboard.sh 3b19ed9 link /test e2e-dashboard
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj ayj mentioned this pull request Jun 27, 2018
@hklai hklai deleted the revert-6641-costin-cachepush branch June 28, 2018 19:06
quanjielin pushed a commit to quanjielin/istio that referenced this pull request Jul 2, 2018
* Revert "Remove v2 transition commands since everything is now v2 (istio#6665)"

This reverts commit 6339eb6.

* Revert "Pilot param clusterRegistriesNamespace should default to pilot namespace (istio#6446)"

This reverts commit b9294f7.

* Revert "iptable just "return" by uid as the parameter u indicates (istio#6561)"

This reverts commit 22a0b88.

* Revert "Remove node agent service, residue from flexvolume driver. (istio#6651)"

This reverts commit db3da82.

* Revert "Continuously reapply galley CA bundle to prevent overwrite (istio#6599)"

This reverts commit f9e8fd8.

* Revert "Do not count typeConfigs if it is error. (istio#6527)"

This reverts commit eb1de31.

* Revert "Make racetest green - Fixed data races and flakiness (istio#6625)"

This reverts commit 30b8ecb.

* Revert "Improve push squashing (istio#6641)"

This reverts commit 399cd2d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants