Remove v2 transition commands since everything is now v2#6665
Merged
rshriram merged 3 commits intoistio:masterfrom Jun 27, 2018
Merged
Remove v2 transition commands since everything is now v2#6665rshriram merged 3 commits intoistio:masterfrom
rshriram merged 3 commits intoistio:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GregHanson Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6665 +/- ##
=======================================
- Coverage 68% 68% -<1%
=======================================
Files 361 361
Lines 31725 31493 -232
=======================================
- Hits 21476 21200 -276
- Misses 9383 9427 +44
Partials 866 866
Continue to review full report at Codecov.
|
f8cd4b6 to
08fe19a
Compare
Collaborator
|
@GregHanson: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rshriram
reviewed
Jun 27, 2018
| --namespace=istio-system \ | ||
| --set global.hub=${HUB} \ | ||
| --values install/kubernetes/helm/istio/values-envoyv2-transition.yaml \ | ||
| --set gateways.istio-ingressgateway.type=LoadBalancer \ |
Member
There was a problem hiding this comment.
isn't this needed in the generate_yaml above?
Member
There was a problem hiding this comment.
ignore.. its set by default to load balancer..
rshriram
approved these changes
Jun 27, 2018
Member
|
@GregHanson ready to push or need more changes? |
Member
Author
|
@rshriram good to merge |
hklai
added a commit
that referenced
this pull request
Jun 27, 2018
…)" This reverts commit 6339eb6.
hklai
added a commit
that referenced
this pull request
Jun 27, 2018
* Revert "Remove v2 transition commands since everything is now v2 (#6665)" This reverts commit 6339eb6. * Revert "Pilot param clusterRegistriesNamespace should default to pilot namespace (#6446)" This reverts commit b9294f7. * Revert "iptable just "return" by uid as the parameter u indicates (#6561)" This reverts commit 22a0b88. * Revert "Remove node agent service, residue from flexvolume driver. (#6651)" This reverts commit db3da82. * Revert "Continuously reapply galley CA bundle to prevent overwrite (#6599)" This reverts commit f9e8fd8. * Revert "Do not count typeConfigs if it is error. (#6527)" This reverts commit eb1de31. * Revert "Make racetest green - Fixed data races and flakiness (#6625)" This reverts commit 30b8ecb. * Revert "Improve push squashing (#6641)" This reverts commit 399cd2d.
quanjielin
pushed a commit
to quanjielin/istio
that referenced
this pull request
Jul 2, 2018
* remove v2 transition commands since everything is now v2 * changes for transition_loadbalancer_ingressgateway command
quanjielin
pushed a commit
to quanjielin/istio
that referenced
this pull request
Jul 2, 2018
* Revert "Remove v2 transition commands since everything is now v2 (istio#6665)" This reverts commit 6339eb6. * Revert "Pilot param clusterRegistriesNamespace should default to pilot namespace (istio#6446)" This reverts commit b9294f7. * Revert "iptable just "return" by uid as the parameter u indicates (istio#6561)" This reverts commit 22a0b88. * Revert "Remove node agent service, residue from flexvolume driver. (istio#6651)" This reverts commit db3da82. * Revert "Continuously reapply galley CA bundle to prevent overwrite (istio#6599)" This reverts commit f9e8fd8. * Revert "Do not count typeConfigs if it is error. (istio#6527)" This reverts commit eb1de31. * Revert "Make racetest green - Fixed data races and flakiness (istio#6625)" This reverts commit 30b8ecb. * Revert "Improve push squashing (istio#6641)" This reverts commit 399cd2d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.