[Important Fix] Add release name (NS) to the Statsd address in mesh config#6349
[Important Fix] Add release name (NS) to the Statsd address in mesh config#6349istio-testing merged 1 commit intoistio:masterfrom ymesika:configmapFix
Conversation
|
/assign @gyliu513 |
|
/assign @rshriram |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gyliu513, ymesika The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ymesika: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Any idea why this was not caught in the tests? Also this is the only fix that is needed on top of the RC so far. We probably will just create a release branch, and cherrypick this to the RC. |
|
@hklai Thanks for clarifying |
|
@ymesika Well my question remains. Why was the problem not caught by any automatic tests? If not, can we add some? |
|
My guess is that we run all test related stuff in the same ns: Istio pods + test services pods. |
Add release name to the Statsd UDP address (#6349)
In recent PR of mine (#6133) I moved the statsd address to the global values.
The value in the configmap should be with the NS because otherwise pods with injected
istio-proxyoutside of theistio-systemnamespace won't be able to connect to the statsd destination causing the istio-proxy container to crash.