Skip to content

Add release name to the Statsd UDP address (#6349)#6413

Merged
hklai merged 1 commit intoistio:release-1.0.0-snapshot.0from
rkpagadala:release-1.0.0-snapshot.0
Jun 20, 2018
Merged

Add release name to the Statsd UDP address (#6349)#6413
hklai merged 1 commit intoistio:release-1.0.0-snapshot.0from
rkpagadala:release-1.0.0-snapshot.0

Conversation

@rkpagadala
Copy link
Copy Markdown
Contributor

@rkpagadala rkpagadala commented Jun 20, 2018

Cherrpick required fix into branch 1.0.0-snapshot.0
Add release name to the Statsd UDP address (#6349)

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Jun 20, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jun 20, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 20, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkpagadala
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia

Assign the PR to them by writing /assign @andraxylia in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rkpagadala rkpagadala added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Jun 20, 2018
@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Jun 20, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 20, 2018 •
edited
Loading

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh 2c0ccaf link /test istio-pilot-e2e
prow/e2e-bookInfoTests.sh 2c0ccaf link /test e2e-bookInfo
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai hklai merged commit e74a7fc into istio:release-1.0.0-snapshot.0 Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rkpagadala @googlebot @istio-testing @hklai @ymesika