remove 1.23 compatibility profile#56023
Merged
istio-testing merged 2 commits intoistio:masterfrom Apr 21, 2025
Merged
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Collaborator
|
@ramaraochavali: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
zirain
approved these changes
Apr 21, 2025
howardjohn
reviewed
Apr 21, 2025
| ManagedGatewayController = env.Register("PILOT_GATEWAY_API_CONTROLLER_NAME", "istio.io/gateway-controller", | ||
| "Gateway API controller name. istiod will only reconcile Gateway API resources referencing a GatewayClass with this controller name").Get() | ||
|
|
||
| EnableInboundRetryPolicy = env.Register("ENABLE_INBOUND_RETRY_POLICY", true, |
Member
There was a problem hiding this comment.
A bit concerned about this. Wondering if its wise for us to have retries that cannot be disabled at all?
That being said, these retries are extremely conservative and will almost never actually trigger so maybe it doesn't matter much
Contributor
Author
There was a problem hiding this comment.
I think latter. If we want to have it configurable, probably we should do it via MeshConfig but do not think it is needed immediately.
stevenctl
approved these changes
Apr 21, 2025
yxun
pushed a commit
to yxun/istio
that referenced
this pull request
Apr 23, 2025
* remove 1.23 compatibility profile Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * fix ut Signed-off-by: Rama Chavali <rama.rao@salesforce.com> --------- Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
tjons
pushed a commit
to tjons/istio
that referenced
this pull request
Apr 26, 2025
* remove 1.23 compatibility profile Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * fix ut Signed-off-by: Rama Chavali <rama.rao@salesforce.com> --------- Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
fjglira
pushed a commit
to fjglira/istio
that referenced
this pull request
Sep 26, 2025
* upstream/master: remove 1.23 compatibility profile (istio#56023) Create ambient multinetwork flag (istio#55991) krt: make krt and kube client indexes named (istio#55999) Automator: update proxy@master in istio/istio@master (istio#56026) fix istio-revision-tag-default MutatingWebhookConfigurations is not created during installation (istio#56004) doc: fix typo in accesslog test (istio#55117) fix(networking): Add absolute FQDNs (trailing dot) to VirtualHost domains (istio#56008)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we EOL 1.23 removing the compatibilty profile in Master for 1.23. There are still few more env vars that need to be removed, I will do a follow-up.