Skip to content

doc: fix typo in accesslog test#55117

Merged
istio-testing merged 1 commit intoistio:masterfrom
psxjoy:first-fix-typo
Apr 21, 2025
Merged

doc: fix typo in accesslog test#55117
istio-testing merged 1 commit intoistio:masterfrom
psxjoy:first-fix-typo

Conversation

@psxjoy
Copy link
Copy Markdown
Contributor

@psxjoy psxjoy commented Feb 14, 2025 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:
In pilot/pkg/networking/core/accesslog_test.go file, newTestEnviroment should be named as newTestEnvironment.

@psxjoy psxjoy requested a review from a team as a code owner February 14, 2025 17:07
@istio-policy-bot istio-policy-bot added kind/docs release-notes-none Indicates a PR that does not require release notes. labels Feb 14, 2025
@istio-policy-bot
Copy link
Copy Markdown

istio-policy-bot commented Feb 14, 2025

😊 Welcome @psxjoy! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Feb 14, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2025
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 14, 2025

Hi @psxjoy. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zirain
Copy link
Copy Markdown
Member

zirain commented Feb 17, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 17, 2025
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Mar 19, 2025
@psxjoy
Copy link
Copy Markdown
Contributor Author

psxjoy commented Mar 24, 2025

Hi, @zirain ,I think we can proceed with the PR process now. What do you think?

@zirain
Copy link
Copy Markdown
Member

zirain commented Mar 24, 2025

not stale

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Mar 24, 2025
@zirain
Copy link
Copy Markdown
Member

zirain commented Mar 24, 2025

/retest

MorrisLaw
MorrisLaw approved these changes Apr 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MorrisLaw MorrisLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sridhargaddam
Copy link
Copy Markdown
Contributor

sridhargaddam commented Apr 20, 2025

CC: @istio/wg-networking-maintainers-pilot

@istio-testing istio-testing merged commit cefb69b into istio:master Apr 21, 2025
2 checks passed
@psxjoy psxjoy deleted the first-fix-typo branch April 22, 2025 07:58
yxun pushed a commit to yxun/istio that referenced this pull request Apr 23, 2025
@psxjoy @yxun
doc: fix typo in accesslog test (istio#55117)
bafe64d
tjons pushed a commit to tjons/istio that referenced this pull request Apr 26, 2025
@psxjoy @tjons
doc: fix typo in accesslog test (istio#55117)
acca9e8
fjglira pushed a commit to fjglira/istio that referenced this pull request Sep 26, 2025
Automator: merge upstream changes to openshift-service-mesh/istio@master
c8c08a8 
* upstream/master:
  remove 1.23 compatibility profile (istio#56023)
  Create ambient multinetwork flag (istio#55991)
  krt: make krt and kube client indexes named (istio#55999)
  Automator: update proxy@master in istio/istio@master (istio#56026)
  fix istio-revision-tag-default MutatingWebhookConfigurations is not created during installation (istio#56004)
  doc: fix typo in accesslog test (istio#55117)
  fix(networking): Add absolute FQDNs (trailing dot) to VirtualHost domains (istio#56008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

@zirain zirain zirain approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

+1 more reviewer

@MorrisLaw MorrisLaw MorrisLaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@psxjoy @istio-policy-bot @istio-testing @zirain @sridhargaddam @howardjohn @MorrisLaw