Conversation
| @@ -0,0 +1,8 @@ | |||
| **Release note**: | |||
| <!-- Steps to write your release note: | |||
| 1. Use the release-note-* labels to set the release note state (if you have access) | |||
There was a problem hiding this comment.
So there are two way to set release-note related labels for mungegithub. One, if you have access to set label directly, just do it. Or if someone don't have access to do it or you want to add more details in release-note, then pr creator can add release message to pr description using this template. Prow will automatically add "release-note" label. If you add "None", "release-note-none" label will be added. Take a look at this pr, will help understand what's happening. If you don't do any of these two, "release-note-needed" will be added to block merging.
There was a problem hiding this comment.
Thx! I wanted to ask that during the demo, what does release-note-none mean/is it a good thing ? (my guess is it means skip the PR in release notes ? can you confirm ? so should be the exception right ?)
also what are the other release-note-* we envision (beside none and needed)
There was a problem hiding this comment.
Yes, you are right. So totally, we have "release-note" "release-note-none" and "release-note-needed". When people do release, just select all PRs with "release-note" label and you get every release notes. If we don't care about this PR in release just add "release-note-none" or leave "None". "needed" label is the way to enforce people to do this basically :)
|
/test all |
|
/release-note-none |
|
@ldemailly Could you comment "/approve no-issue" and "lgtm" such that mungegithub can take care of this :) |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly, yutongz Associated issue requirement bypassed by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
will the bot auto rebase ? then auto merge ? |
|
Automatic merge from submit-queue |
|
The bot did it's job! |
) This PR adds a part of the mixer config API. Add GET and PUT on /scopes/{scope}/subjects/{subject}/rules other operations will follow. These 2 operations will be sufficient for demo. Add a KVStore abstraction that config manager and API server both use Create a FSStore (file system KV Store) (redis to follow) Add scope/subject resolve and override logic. TODO Notes. Until redis KVStore is in, mixer itself starts an API server on port 9094. Config API server will moved to its own command. Add hidden options configIdentityAttribute and configIdentityAttributeDomain Former-commit-id: 77ffe0c18f25a762ad3b116cf7faf637fed8ac88
Automatic merge from submit-queue Add PR template PR template to help adding release-note Former-commit-id: f8644a9
This PR adds a part of the mixer config API.
Add GET and PUT on /scopes/{scope}/subjects/{subject}/rules
other operations will follow. These 2 operations will be sufficient for demo.
Add a KVStore abstraction that config manager and API server both use
Create a FSStore (file system KV Store) (redis to follow)
Add scope/subject resolve and override logic.
TODO Notes.
Until redis KVStore is in, mixer itself starts an API server on port 9094.
Config API server will moved to its own command.
Add hidden options configIdentityAttribute and configIdentityAttributeDomain
Former-commit-id: 089b9a1959faf2d492b92ba9d084f0d7d3b3766a
Automatic merge from submit-queue Add PR template PR template to help adding release-note Former-commit-id: f8644a9
Automatic merge from submit-queue Add PR template PR template to help adding release-note Former-commit-id: f8644a9
Co-authored-by: openshift-service-mesh-bot <null>
PR template to help adding release-note