Merged
Conversation
nlandolfi
reviewed
Aug 1, 2017
mungegithub/deployment/README.md
Outdated
|
|
||
| > Note: Do not comment "/approve" or add "approved" label unless you are 100% sure you want this change, because after you say that, the pr will be merge any minutes. | ||
|
|
||
| > Note: The PR will be self-approved if the PR creator is in OWNERS file and this PR is associated with at lease one issue. |
Contributor
Author
|
@nlandolfi PTAL |
Contributor
|
/lgtm |
sebastienvas
approved these changes
Aug 3, 2017
Contributor
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gyliu513, nlandolfi, sebastienvas, yutongz Associated issue requirement bypassed by: sebastienvas The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
soloio-bot
pushed a commit
to soloio-bot/test-infra
that referenced
this pull request
Jun 22, 2023
Remove testgrid notifications to upstream's oncall group from mention, also update the service account for prow deployer to use the prow-deployer service account which should allow us to deploy updates via PRs instead of manually. Signed-off-by: Daniel Hawton <daniel.hawton@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: