[vendor-change] dep init + prune changes for 0.8 by ldemailly · Pull Request #4651 · istio/istio

ldemailly · 2018-03-30T02:14:12Z

ldemailly · 2018-03-30T02:15:00Z

matching vendor PR istio/old_vendor-istio_repo#45

ldemailly · 2018-03-30T03:06:51Z

bin/gobuild.sh /Users/ldemailly/go/out/darwin_amd64/release/sidecar-injector istio.io/istio/pkg/version ./pilot/cmd/sidecar-injector
# istio.io/istio/vendor/k8s.io/kubernetes/pkg/util/parsers
vendor/k8s.io/kubernetes/pkg/util/parsers/parsers.go:36:16: undefined: reference.ParseNormalizedNamed

probably means I have the wrong github.com/docker/distribution/reference

codecov · 2018-03-30T20:33:59Z

Codecov Report

Merging #4651 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4651    +/-   ##
=======================================
- Coverage      75%     75%   -<1%     
=======================================
  Files         297     297            
  Lines       24710   24638    -72     
=======================================
- Hits        18438   18369    -69     
+ Misses       5512    5508     -4     
- Partials      760     761     +1

Impacted Files	Coverage Δ
pilot/pkg/config/memory/monitor.go	`82% <0%> (-9%)`	⬇️
mixer/adapter/stackdriver/stackdriver.go	`64% <0%> (-6%)`	⬇️
mixer/adapter/redisquota/redisquota.go	`86% <0%> (-3%)`	⬇️
pilot/pkg/model/authentication.go	`77% <0%> (-3%)`	⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go	`69% <0%> (-1%)`	⬇️
mixer/adapter/servicecontrol/reportprocessor.go	`79% <0%> (-1%)`	⬇️
mixer/adapter/servicecontrol/quotaprocessor.go	`83% <0%> (-1%)`	⬇️
pilot/pkg/serviceregistry/kube/controller.go	`63% <0%> (-1%)`	⬇️
mixer/adapter/list/regexList.go	`100% <0%> (ø)`	⬆️
mixer/adapter/prometheus/prometheus.go	`100% <0%> (ø)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6349f14...9c3b7f7. Read the comment docs.

ldemailly · 2018-03-30T21:12:56Z

going to let someone from pilot fix this

kyessenov · 2018-03-30T21:41:56Z

/lgtm
/approve

kyessenov

cc @rlenglet: this should bring the go-control-plane updat to istio.

ldemailly · 2018-03-30T22:56:19Z

mixer failure is unrelated readiness issue

prow is overloaded

will merge

kyessenov · 2018-03-30T22:59:05Z

/lgtm
/approve

istio-testing · 2018-03-30T22:59:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wattli

Assign the PR to them by writing /assign @wattli in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

istio-testing · 2018-03-30T23:03:37Z

New changes are detected. LGTM label has been removed.

* dep init + prune changes for 0.8 * dep init + prune changes for 0.8 - try#2 with k8s 1.9 instead of 1.10 * start of changes for istio/api#439 - will continue on my mac * Rest of fixes for Name->Host Matching istio/api#439 * Compiling! * More Name->Host fun * Use our glog * Make go generate ./mixer/... runnable * Partial fix for name->host * Update back api * Revert destination name->host * need fortio to be buildable from vendor, grpc health is a dependency * switching vendor to master post istio/old_vendor-istio_repo#45 merge

dep init + prune changes for 0.8

17a5e85

googlebot added the cla: yes label Mar 30, 2018

ldemailly changed the title ~~dep init + prune changes for 0.8~~ [vendor-change] dep init + prune changes for 0.8 Mar 30, 2018

dep init + prune changes for 0.8 - try#2 with k8s 1.9 instead of 1.10

b65fe42

ldemailly mentioned this pull request Mar 30, 2018

Rename Destination.name to Destination.host istio/api#439

Merged

ldemailly added 2 commits March 30, 2018 02:52

start of changes for istio/api#439 - will continue on my mac

115515c

Rest of fixes for Name->Host

0b19d49

Matching istio/api#439

ldemailly requested a review from rshriram March 30, 2018 03:05

ldemailly added 3 commits March 30, 2018 11:30

Merge branch 'master' into dep_reset_0_8

c4b0f9f

Compiling!

748b908

More Name->Host fun

4d491bc

ldemailly changed the title ~~[vendor-change] dep init + prune changes for 0.8~~ [vendor-change] dep init + prune changes for 0.8 + destination Name->Host (v1alpha3) Mar 30, 2018

ldemailly added 4 commits March 30, 2018 13:39

Merge branch 'master' into dep_reset_0_8

960ac5a

Use our glog

783e081

Make go generate ./mixer/... runnable

fc99c94

Partial fix for name->host

0c8a26e

ldemailly closed this Mar 30, 2018

ldemailly mentioned this pull request Mar 30, 2018

update vendor for 0.8 cycle #4482

Closed

ldemailly reopened this Mar 30, 2018

Update back api

0b5c388

ldemailly changed the title ~~[vendor-change] dep init + prune changes for 0.8 + destination Name->Host (v1alpha3)~~ [vendor-change] dep init + prune changes for 0.8 Mar 30, 2018

ldemailly requested review from kyessenov and removed request for rshriram March 30, 2018 21:38

istio-testing assigned kyessenov Mar 30, 2018

istio-testing added the lgtm label Mar 30, 2018

kyessenov reviewed Mar 30, 2018

View reviewed changes

kyessenov approved these changes Mar 30, 2018

View reviewed changes

This was referenced Mar 30, 2018

Update Envoy dependency to support transparent listeners istio/proxy#1338

Merged

Use iptables TPROXY instead of REDIRECT for inbound traffic #4654

Merged

Revert destination name->host

396bdb0

istio-testing removed the lgtm label Mar 30, 2018

ldemailly added 2 commits March 30, 2018 14:52

Merge branch 'master' into dep_reset_0_8

2478c85

need fortio to be buildable from vendor, grpc health is a dependency

4b9da15

istio-testing added the lgtm label Mar 30, 2018

switching vendor to master post istio/old_vendor-istio_repo#45 merge

9c3b7f7

istio-testing removed the lgtm label Mar 30, 2018

ldemailly merged commit 9e64e71 into master Mar 30, 2018

ldemailly deleted the dep_reset_0_8 branch March 30, 2018 23:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vendor-change] dep init + prune changes for 0.8#4651

[vendor-change] dep init + prune changes for 0.8#4651
ldemailly merged 16 commits intomasterfrom
dep_reset_0_8

ldemailly commented Mar 30, 2018 •

edited

Loading

Uh oh!

ldemailly commented Mar 30, 2018

Uh oh!

ldemailly commented Mar 30, 2018

Uh oh!

codecov bot commented Mar 30, 2018 •

edited

Loading

Uh oh!

ldemailly commented Mar 30, 2018

Uh oh!

kyessenov commented Mar 30, 2018

Uh oh!

kyessenov left a comment

Uh oh!

ldemailly commented Mar 30, 2018

Uh oh!

kyessenov commented Mar 30, 2018

Uh oh!

istio-testing commented Mar 30, 2018

Uh oh!

istio-testing commented Mar 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ldemailly commented Mar 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldemailly commented Mar 30, 2018

Uh oh!

ldemailly commented Mar 30, 2018

Uh oh!

codecov bot commented Mar 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ldemailly commented Mar 30, 2018

Uh oh!

kyessenov commented Mar 30, 2018

Uh oh!

kyessenov left a comment

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Mar 30, 2018

Uh oh!

kyessenov commented Mar 30, 2018

Uh oh!

istio-testing commented Mar 30, 2018

Uh oh!

istio-testing commented Mar 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ldemailly commented Mar 30, 2018 •

edited

Loading

codecov bot commented Mar 30, 2018 •

edited

Loading