Rename Destination.name to Destination.host#439
Merged
rshriram merged 5 commits intoistio:masterfrom Mar 29, 2018
Merged
Conversation
added 3 commits
March 13, 2018 15:56
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
frankbu
approved these changes
Mar 29, 2018
Collaborator
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Collaborator
|
|
Collaborator
|
|
Member
Author
|
merging due to CLA issue |
Member
|
can you make the istio/istio changes asap ? trying to update dependencies (for 0.8 istio/istio#4651) |
Member
|
nvm I guess you'd need to make a vendor change to do that, so I'll make those changes |
ldemailly
added a commit
to istio/istio
that referenced
this pull request
Mar 30, 2018
ldemailly
added a commit
to istio/istio
that referenced
this pull request
Mar 30, 2018
ldemailly
added a commit
to istio/istio
that referenced
this pull request
Mar 30, 2018
* dep init + prune changes for 0.8 * dep init + prune changes for 0.8 - try#2 with k8s 1.9 instead of 1.10 * start of changes for istio/api#439 - will continue on my mac * Rest of fixes for Name->Host Matching istio/api#439 * Compiling! * More Name->Host fun * Use our glog * Make go generate ./mixer/... runnable * Partial fix for name->host * Update back api * Revert destination name->host * need fortio to be buildable from vendor, grpc health is a dependency * switching vendor to master post istio/old_vendor-istio_repo#45 merge
Member
|
it's too many changes so please make the necessary changes in thanks! |
bianpengyuan
pushed a commit
to bianpengyuan/istio
that referenced
this pull request
Apr 5, 2018
* dep init + prune changes for 0.8 * dep init + prune changes for 0.8 - try#2 with k8s 1.9 instead of 1.10 * start of changes for istio/api#439 - will continue on my mac * Rest of fixes for Name->Host Matching istio/api#439 * Compiling! * More Name->Host fun * Use our glog * Make go generate ./mixer/... runnable * Partial fix for name->host * Update back api * Revert destination name->host * need fortio to be buildable from vendor, grpc health is a dependency * switching vendor to master post istio/old_vendor-istio_repo#45 merge
incfly
pushed a commit
to incfly/api
that referenced
this pull request
Jun 13, 2018
* Cancel check call on destroy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shriram Rajagopalan shriramr@vmware.com